diff mbox

[4/6] drm/qxl: Remove dead code

Message ID 1466788520-21325-5-git-send-email-frank.binns@imgtec.com (mailing list archive)
State New, archived
Headers show

Commit Message

Frank Binns June 24, 2016, 5:15 p.m. UTC 
From: Thierry Reding <treding@nvidia.com>

The QXL driver sets DRIVER_MODESET unconditionally, so testing for the
absence of the feature will always fail.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 drivers/gpu/drm/qxl/qxl_kms.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Daniel Vetter July 12, 2016, 11:09 a.m. UTC | #1 
On Fri, Jun 24, 2016 at 06:15:18PM +0100, Frank Binns wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> The QXL driver sets DRIVER_MODESET unconditionally, so testing for the
> absence of the feature will always fail.
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>

Applied to drm-misc.
-Daniel

> ---
>  drivers/gpu/drm/qxl/qxl_kms.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/qxl/qxl_kms.c b/drivers/gpu/drm/qxl/qxl_kms.c
> index 2319800..12b8dff 100644
> --- a/drivers/gpu/drm/qxl/qxl_kms.c
> +++ b/drivers/gpu/drm/qxl/qxl_kms.c
> @@ -310,10 +310,6 @@ int qxl_driver_load(struct drm_device *dev, unsigned long flags)
>  	struct qxl_device *qdev;
>  	int r;
>  
> -	/* require kms */
> -	if (!drm_core_check_feature(dev, DRIVER_MODESET))
> -		return -ENODEV;
> -
>  	qdev = kzalloc(sizeof(struct qxl_device), GFP_KERNEL);
>  	if (qdev == NULL)
>  		return -ENOMEM;
> -- 
> 2.7.4
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff mbox

Patch

diff --git a/drivers/gpu/drm/qxl/qxl_kms.c b/drivers/gpu/drm/qxl/qxl_kms.c
index 2319800..12b8dff 100644
--- a/drivers/gpu/drm/qxl/qxl_kms.c
+++ b/drivers/gpu/drm/qxl/qxl_kms.c
@@ -310,10 +310,6 @@  int qxl_driver_load(struct drm_device *dev, unsigned long flags)
 	struct qxl_device *qdev;
 	int r;
 
-	/* require kms */
-	if (!drm_core_check_feature(dev, DRIVER_MODESET))
-		return -ENODEV;
-
 	qdev = kzalloc(sizeof(struct qxl_device), GFP_KERNEL);
 	if (qdev == NULL)
 		return -ENOMEM;