From patchwork Wed Jul 13 12:44:13 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: weiyj_lk@163.com X-Patchwork-Id: 9229169 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 69DB06075D for ; Thu, 14 Jul 2016 08:08:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5BBB426D08 for ; Thu, 14 Jul 2016 08:08:28 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5017B28178; Thu, 14 Jul 2016 08:08:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BCE3926D08 for ; Thu, 14 Jul 2016 08:08:26 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 71BF56E887; Thu, 14 Jul 2016 08:08:25 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from m12-15.163.com (m12-15.163.com [220.181.12.15]) by gabe.freedesktop.org (Postfix) with ESMTP id 1F4596E2D3 for ; Wed, 13 Jul 2016 13:00:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=zlDiv pBa4QUVxDHPMdBSfOvDA+hEx2XyjLiB8wtAoeE=; b=EfWuJn8JmvuerGcAHuXzx i2A6RGNXy+xzvBn3prU5TYVfVf2PlwjO+EYXdZv4JcGIdQxtTrqVQnQgGYT28AiP IUOowb776jw8F5JQTiey6d/l9HzvvgfSy3bjIQpwDOP6aqMVkLOhF/Sblllk38Zp piuVwnO0qHqylVsn94PDvs= Received: from localhost.localdomain.localdomain (unknown [180.102.101.186]) by smtp11 (Coremail) with SMTP id D8CowADXNtOdN4ZXbUc+DA--.42116S2; Wed, 13 Jul 2016 20:44:14 +0800 (CST) From: weiyj_lk@163.com To: Xinliang Liu , Xinwei Kong , Chen Feng , David Airlie Subject: [PATCH -next] drm/hisilicon: Remove redundant dev_err call in ade_dts_parse() Date: Wed, 13 Jul 2016 12:44:13 +0000 Message-Id: <1468413853-2500-1-git-send-email-weiyj_lk@163.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-CM-TRANSID: D8CowADXNtOdN4ZXbUc+DA--.42116S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7Wr4kCw4kuF47tr4DGr45Jrb_yoWDKFg_Gr WUuFn3XrnI9Fyjvw1DXFnxZryayF1q9rWrGw4ftayft343Zr18t3s8ZrWq9ry3XanagFnx C3yrKF1S9Fn7ujkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUe5PE3UUUUU== X-Originating-IP: [180.102.101.186] X-CM-SenderInfo: pzhl5yxbonqiywtou0bp/xtbByh6l1lO+ke-h5gAAsz X-Mailman-Approved-At: Thu, 14 Jul 2016 08:08:24 +0000 Cc: Wei Yongjun , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Wei Yongjun There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun --- drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c index 805f432..3aea3bb 100644 --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c @@ -944,10 +944,8 @@ static int ade_dts_parse(struct platform_device *pdev, struct ade_hw_ctx *ctx) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); ctx->base = devm_ioremap_resource(dev, res); - if (IS_ERR(ctx->base)) { - DRM_ERROR("failed to remap ade io base\n"); + if (IS_ERR(ctx->base)) return PTR_ERR(ctx->base); - } ctx->reset = devm_reset_control_get(dev, NULL); if (IS_ERR(ctx->reset))