From patchwork Tue Jul 19 12:01:37 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: weiyj_lk@163.com X-Patchwork-Id: 9237645 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1478E6075D for ; Tue, 19 Jul 2016 14:31:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0509727569 for ; Tue, 19 Jul 2016 14:31:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EDC66277D9; Tue, 19 Jul 2016 14:31:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2F78527569 for ; Tue, 19 Jul 2016 14:31:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1FD296E254; Tue, 19 Jul 2016 14:30:37 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from m12-12.163.com (m12-12.163.com [220.181.12.12]) by gabe.freedesktop.org (Postfix) with ESMTP id 61B5E6E3D6 for ; Tue, 19 Jul 2016 12:17:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=XEwbQ C0Y6jIWbVfkfL+tqmqSEy3AzRsIIS59IM1k4wM=; b=bdTjyIVFQug0fGMRe2+9I ZLz6NYY8pRq26E1gTlxrbBlhF82gO/YouOl93MYjDujQ+KUTFgan9wY4D7VOzDgp YTA7Yvc9n4qYEOAEC7fcFsE7YOkOluLXV9DFCYqiON5gFfBVHcYrKbuxzMw6eQA9 xoibdc7FS1ODRBeak9Sn6w= Received: from localhost.localdomain.localdomain (unknown [180.110.255.208]) by smtp8 (Coremail) with SMTP id DMCowACHrxeiFo5XtsSAAQ--.39244S2; Tue, 19 Jul 2016 20:01:39 +0800 (CST) From: Wei Yongjun To: Alexey Brodkin , David Airlie Subject: [PATCH -next] drm/arc: Remove redundant dev_err call in arcpgu_load() Date: Tue, 19 Jul 2016 12:01:37 +0000 Message-Id: <1468929697-8648-1-git-send-email-weiyj_lk@163.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-CM-TRANSID: DMCowACHrxeiFo5XtsSAAQ--.39244S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7Wr4kCw4kuF47tr4DGr45Jrb_yoWDXrc_Cr WDZwn7XwnIyF4qqF98C3W5AFy3tFsF9FWfXF1qqa43tryUX3y2gryqkw18Xr1DXwsIkFZ8 Aws8Xr4ayrsxCjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU0WKZJUUUUU== X-Originating-IP: [180.110.255.208] X-CM-SenderInfo: pzhl5yxbonqiywtou0bp/xtbBDQOr1laDoIKktQAAsV X-Mailman-Approved-At: Tue, 19 Jul 2016 14:30:31 +0000 Cc: Wei Yongjun , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Wei Yongjun There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun Acked-by: Alexey Brodkin --- drivers/gpu/drm/arc/arcpgu_drv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/arc/arcpgu_drv.c b/drivers/gpu/drm/arc/arcpgu_drv.c index 0226ec0..ef1d702 100644 --- a/drivers/gpu/drm/arc/arcpgu_drv.c +++ b/drivers/gpu/drm/arc/arcpgu_drv.c @@ -104,10 +104,8 @@ static int arcpgu_load(struct drm_device *drm) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); arcpgu->regs = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(arcpgu->regs)) { - dev_err(drm->dev, "Could not remap IO mem\n"); + if (IS_ERR(arcpgu->regs)) return PTR_ERR(arcpgu->regs); - } dev_info(drm->dev, "arc_pgu ID: 0x%x\n", arc_pgu_read(arcpgu, ARCPGU_REG_ID));