| Message ID | 1469106874-4912-1-git-send-email-ykk@rock-chips.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Jul 21, 2016 at 9:14 AM, Yakir Yang <ykk@rock-chips.com> wrote: > According to page 16 of Sharp LQ123P1JX31 datasheet, we need to add the > missing delay timing. Panel prepare time should be t1 (0.5ms~10ms) plus > t3 (0ms~100ms), and panel enable time should equal to t7 (0ms~50ms), and > panel unprepare time should be t11 (1ms~50ms) plus t12 (500ms~). > > Signed-off-by: Yakir Yang <ykk@rock-chips.com> Reviewed-by: Sean Paul <seanpaul@chromium.org> > --- > drivers/gpu/drm/panel/panel-simple.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 85143d1..f178998 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -1384,6 +1384,11 @@ static const struct panel_desc sharp_lq123p1jx31 = { > .width = 259, > .height = 173, > }, > + .delay = { > + .prepare = 110, > + .enable = 50, > + .unprepare = 550, > + }, > }; > > static const struct drm_display_mode shelly_sca07010_bfn_lnn_mode = { > -- > 1.9.1 > >
Sean, On 07/21/2016 10:30 PM, Sean Paul wrote: > On Thu, Jul 21, 2016 at 9:14 AM, Yakir Yang <ykk@rock-chips.com> wrote: >> According to page 16 of Sharp LQ123P1JX31 datasheet, we need to add the >> missing delay timing. Panel prepare time should be t1 (0.5ms~10ms) plus >> t3 (0ms~100ms), and panel enable time should equal to t7 (0ms~50ms), and >> panel unprepare time should be t11 (1ms~50ms) plus t12 (500ms~). >> >> Signed-off-by: Yakir Yang <ykk@rock-chips.com> > Reviewed-by: Sean Paul <seanpaul@chromium.org> Thanks :-D - Yakir >> --- >> drivers/gpu/drm/panel/panel-simple.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c >> index 85143d1..f178998 100644 >> --- a/drivers/gpu/drm/panel/panel-simple.c >> +++ b/drivers/gpu/drm/panel/panel-simple.c >> @@ -1384,6 +1384,11 @@ static const struct panel_desc sharp_lq123p1jx31 = { >> .width = 259, >> .height = 173, >> }, >> + .delay = { >> + .prepare = 110, >> + .enable = 50, >> + .unprepare = 550, >> + }, >> }; >> >> static const struct drm_display_mode shelly_sca07010_bfn_lnn_mode = { >> -- >> 1.9.1 >> >> > >
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 85143d1..f178998 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1384,6 +1384,11 @@ static const struct panel_desc sharp_lq123p1jx31 = { .width = 259, .height = 173, }, + .delay = { + .prepare = 110, + .enable = 50, + .unprepare = 550, + }, }; static const struct drm_display_mode shelly_sca07010_bfn_lnn_mode = {
According to page 16 of Sharp LQ123P1JX31 datasheet, we need to add the missing delay timing. Panel prepare time should be t1 (0.5ms~10ms) plus t3 (0ms~100ms), and panel enable time should equal to t7 (0ms~50ms), and panel unprepare time should be t11 (1ms~50ms) plus t12 (500ms~). Signed-off-by: Yakir Yang <ykk@rock-chips.com> --- drivers/gpu/drm/panel/panel-simple.c | 5 +++++ 1 file changed, 5 insertions(+)