@@ -961,6 +961,14 @@ analogix_dp_detect(struct drm_connector *connector, bool force)
{
struct analogix_dp_device *dp = to_dp(connector);
+ /*
+ * Panle would prepare for several times here, but don't worry it
+ * would only enable the hardware at the first prepare time.
+ */
+ if (dp->plat_data->panel)
+ if (drm_panel_prepare(dp->plat_data->panel))
+ DRM_ERROR("failed to setup the panel\n");
+
if (analogix_dp_detect_hpd(dp))
return connector_status_disconnected;
@@ -1077,6 +1085,13 @@ static void analogix_dp_bridge_disable(struct drm_bridge *bridge)
pm_runtime_put_sync(dp->dev);
+ if (dp->plat_data->panel) {
+ if (drm_panel_unprepare(dp->plat_data->panel)) {
+ DRM_ERROR("failed to turnoff the panel\n");
+ return;
+ }
+ }
+
dp->dpms_mode = DRM_MODE_DPMS_OFF;
}
@@ -1333,13 +1348,6 @@ int analogix_dp_bind(struct device *dev, struct drm_device *drm_dev,
phy_power_on(dp->phy);
- if (dp->plat_data->panel) {
- if (drm_panel_prepare(dp->plat_data->panel)) {
- DRM_ERROR("failed to setup the panel\n");
- return -EBUSY;
- }
- }
-
analogix_dp_init_dp(dp);
ret = devm_request_threaded_irq(&pdev->dev, dp->irq,
Some panels (like Sharp LQ123P1JX31) need to be turn off when eDP controller stop to send valid video signal, otherwhise panel would go burn in, and keep flicker and flicker. So it's better to turn off the panel when eDP need to disable, and we need to turn on the panel in connector->detect() callback, so that driver would detect panel status rightly. Signed-off-by: Yakir Yang <ykk@rock-chips.com> --- Changes in v1.1: - unprepare the panel at the end of bridge->disable() function drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 22 +++++++++++++++------- 1 file changed, 15 insertions(+), 7 deletions(-)