diff mbox

[06/21] drm/etnaviv: Don't set drm_device->platformdev

Message ID 1471034937-651-6-git-send-email-daniel.vetter@ffwll.ch (mailing list archive)
State New, archived
Headers show

Commit Message

Daniel Vetter Aug. 12, 2016, 8:48 p.m. UTC 
It's deprecated and only should be used by drivers which still use
drm_platform_init, not by anyone else.

And indeed it's entirely unused and can be nuked.

Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Russell King <rmk+kernel@arm.linux.org.uk>
Cc: Christian Gmeiner <christian.gmeiner@gmail.com>
Reviewed-by: Sean Paul <seanpaul@chromium.org>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 drivers/gpu/drm/etnaviv/etnaviv_drv.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Lucas Stach Aug. 15, 2016, 9:07 a.m. UTC | #1 
Am Freitag, den 12.08.2016, 22:48 +0200 schrieb Daniel Vetter:
> It's deprecated and only should be used by drivers which still use
> drm_platform_init, not by anyone else.
> 
> And indeed it's entirely unused and can be nuked.
> 
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> Cc: Christian Gmeiner <christian.gmeiner@gmail.com>
> Reviewed-by: Sean Paul <seanpaul@chromium.org>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>

Yeah, I've had this on my list of cleanups to do, so:
Acked-by: Lucas Stach <l.stach@pengutronix.de>

I suppose you are taking this through the misc tree, if not please ping
me.
> ---
>  drivers/gpu/drm/etnaviv/etnaviv_drv.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
> index ffd1b32caa8d..0c00947d15f2 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
> @@ -533,8 +533,6 @@ static int etnaviv_bind(struct device *dev)
>  	if (!drm)
>  		return -ENOMEM;
>  
> -	drm->platformdev = to_platform_device(dev);
> -
>  	priv = kzalloc(sizeof(*priv), GFP_KERNEL);
>  	if (!priv) {
>  		dev_err(dev, "failed to allocate private data\n");
diff mbox

Patch

diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
index ffd1b32caa8d..0c00947d15f2 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
@@ -533,8 +533,6 @@  static int etnaviv_bind(struct device *dev)
 	if (!drm)
 		return -ENOMEM;
 
-	drm->platformdev = to_platform_device(dev);
-
 	priv = kzalloc(sizeof(*priv), GFP_KERNEL);
 	if (!priv) {
 		dev_err(dev, "failed to allocate private data\n");