From patchwork Sun Aug 21 18:06:32 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 9292767 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E97EA600CB for ; Mon, 22 Aug 2016 00:40:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DC5BD287DE for ; Mon, 22 Aug 2016 00:40:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D0F8D287F4; Mon, 22 Aug 2016 00:40:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8FAA7287DE for ; Mon, 22 Aug 2016 00:40:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D9F346E2A4; Mon, 22 Aug 2016 00:40:00 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id F3A936E205 for ; Sun, 21 Aug 2016 18:06:47 +0000 (UTC) Received: from workstation4.fritz.box ([109.91.48.91]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0LzKyn-1b6Efv05SL-014Sf2; Sun, 21 Aug 2016 20:06:38 +0200 From: Heinrich Schuchardt To: Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= Subject: [PATCH 1/1] drm/amdgpu/gmc7: remove dead code Date: Sun, 21 Aug 2016 20:06:32 +0200 Message-Id: <1471802792-3059-1-git-send-email-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.1.4 X-Provags-ID: V03:K0:9EoP59Wm+81CwqV0l7Gg1XRSPK1QLv3VCQKvpzha3g0I/P50Clz 58UehP1vpqdWv39M1myaU/vxgyUd8jtETP55SfhrRJ7gMNvVX8pDzudnZptzCl8LHBBvud5 LJ8LN+be7l6WKgt8FzmF/Do7AMjNh6BRG5TkRgJg9QnscM9FoBkjbjbFFN6Rd5d+7wWcI1Z okR4AdnmFtxjgBBMZvtkg== X-UI-Out-Filterresults: notjunk:1; V01:K0:u5xR3wzg8q0=:YPejMeJIKuUJeyvD4bjvpE 9oIc5QdvAvEDJ/16d8UbNzpqzeSByxiyxmBXuPCFusHADycxjWhLjfna2h8TOF0v80N8GLg/a yV9zMsOmfkuOz3Jibtuf/VRAdlJ7KI8SPhHG989SqSSqsbHv0SK0VkFYP8M0LN/VzptNnn+he Kq3/fTqyjH702SYdvkMRJXGkHwloyI26Mx+CncjyGRqHSDWF2LneFDJGNQ0TMq3FsTAG9D2Z1 RZVyjj7ITjYUzwltJFPrtx4RsVXWHKFwKfyQFYn1j+9jPTNSPJQbn4+8QOQNx8oEHtg1rtT/5 bzC/3Lr9ldogLk4CIFln1e1GDzyaOY0+FxS5wl9Q+QzW0PfttXcBD9updksRC32xF3cbztjFP JGWz1XfDqrBVUizii0xeE6bhK3NOnChSSlYGWuB1A4bJNoCXyEjBY3uIoNZtlHzNC+Bb6OkcR 5VrbyfvcWIC+/245P40o1E+YHrmmMRgpEjqe6W139ZPIaqB7jaIMVwqooEX+4P7qwWkT+MzBN X2BhZU8HnYS0p5c6ZAoOgRZSta47J8AIYIfDkyRbScA7iZKrpYVSOTUQmbYmMpdYsQLjRoE1O QdIH0Fj0Z/5kFX7EzaWKkOBrFciRw/MABNrJl0JiYQfyUIVn8j+cMJicxIFZ4Ki4k77p0an0K 0R5cyAG3lX8gFdnMMV6xAVn8mi69Dosqpg+M/rXLvLBy9AoXveOSl1+Sow3WErbKV3ZWjk1EA f0W5mcEwvlwvJ+HFYb6ygmNpu90Uki9szjFopSpLZ0YXl1KSv7dbW1sDsDc= X-Mailman-Approved-At: Mon, 22 Aug 2016 00:39:59 +0000 Cc: Tom St Denis , Heinrich Schuchardt , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Ken Wang X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP In an if block for (running == 0) running cannot be non-zero. Signed-off-by: Heinrich Schuchardt --- drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c index 0b0f086..1239463 100644 --- a/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c @@ -203,11 +203,6 @@ static int gmc_v7_0_mc_load_microcode(struct amdgpu_device *adev) running = REG_GET_FIELD(RREG32(mmMC_SEQ_SUP_CNTL), MC_SEQ_SUP_CNTL, RUN); if (running == 0) { - if (running) { - blackout = RREG32(mmMC_SHARED_BLACKOUT_CNTL); - WREG32(mmMC_SHARED_BLACKOUT_CNTL, blackout | 1); - } - /* reset the engine and set to writable */ WREG32(mmMC_SEQ_SUP_CNTL, 0x00000008); WREG32(mmMC_SEQ_SUP_CNTL, 0x00000010); @@ -239,9 +234,6 @@ static int gmc_v7_0_mc_load_microcode(struct amdgpu_device *adev) break; udelay(1); } - - if (running) - WREG32(mmMC_SHARED_BLACKOUT_CNTL, blackout); } return 0;