From patchwork Sun Aug 21 18:10:41 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 9292775 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 78857600CB for ; Mon, 22 Aug 2016 00:40:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6B521287DE for ; Mon, 22 Aug 2016 00:40:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6028F28802; Mon, 22 Aug 2016 00:40:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 0018F287DE for ; Mon, 22 Aug 2016 00:40:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 034496E2A7; Mon, 22 Aug 2016 00:40:14 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 528F96E205 for ; Sun, 21 Aug 2016 18:10:54 +0000 (UTC) Received: from workstation4.fritz.box ([109.91.48.91]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0MUoma-1bejg42AUW-00Y9o5; Sun, 21 Aug 2016 20:10:48 +0200 From: Heinrich Schuchardt To: Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= Subject: [PATCH 1/1] drm/amdgpu/gmc8: remove dead code Date: Sun, 21 Aug 2016 20:10:41 +0200 Message-Id: <1471803041-3214-1-git-send-email-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.1.4 X-Provags-ID: V03:K0:KVwRCjyPGvtzWbieVN9VBkyzU+CGgQosawpA598kblnQ1q8AuSU b8lwx/arKHcWoO8eWF+jp9wkSNkQe1c5U3rJG31ySszErRF23ItjWDfdF1Q6tUvblkfxWYc 0EmTBL0vpe91sE5lnHGYTy3nOHNr5NZYYU0OPAYzCKvqBmoozISPXZMxBv/zQvCxh6RpADK jYxUbGKZMN2LkmKK6pKuw== X-UI-Out-Filterresults: notjunk:1; V01:K0:6Wa1CBVrCfM=:m0ESjeuoVddlcGiRd0vBKr LB6uW2PUBD5qjOpgKl7aNqdbzgbYM3HLsTCX6oPJFRGJL1ptiPcExCSiTd160Os8ucDM3nRr3 An8DuTVftiHRIm6jsN75VE951647NX7TGPuLNT/ouWk0utbpuNAAubCsIkqeO7dFkrp2XoLtD iCCUqKWMsooD1k3PDsFg1TgZLinTsjzqY0JcuSTzg+o6kuWLUHfFR6KCOxYZbF7Hg2vML4rRj fyzX7N9ovfDl63X9H6xMkMVkMEmgZ1NbIZWqU06nWSRMX5JwFMF0NBSly8mdxYzYPK8U3EP1q y4xLcZlUhgVKRy6UP1B0Loli/yzFBA7shYJhIieilay//zrRKuOeQuuL8KCEr3EWdULXl9VCK 6Sz8x7XHMN2f0fcI1G5rRoAgqhYEy672Vk8HZ6R+CnI/lilNG66+Mtb7dUky8iFqbqbfH/z6Q Puu0kCzXNjamz8+V1zsuKKWa2c/iewjuT6c5zD6HcsXjLTmF5GyV9OE9IQtKIEfK3awRmKEEZ bN4TNrk1YN8sjedt2Wlpi7BL1Ax+ZHcNN269IbjLTv1Oe/JNH6JnzbSd1NhDoiTPMiwYKoHZY fbEqJU8WTzxDStOwBu8qiRLz3fzFMH/7irrjRjaLR8hzAtjfhb3By+LVRoohup7QyjuvTyNQg 713mF4dNRgVk6wQiTtq+/ILzC3i/ozc56eDMVbSj5P3hXXP/Zxq6oiT0Sj8mylnbNmbfUdRxe UiLeHewh58qNLRlKZb3TWr+8m7eTEV25yrSz1oBUGB6SL/M16HblvYypFR4= X-Mailman-Approved-At: Mon, 22 Aug 2016 00:39:59 +0000 Cc: Tom St Denis , Heinrich Schuchardt , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Eric Huang , Ken Wang , Flora Cui X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP In an if block for (running == 0) running cannot be non-zero. Signed-off-by: Heinrich Schuchardt --- drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c index 2aee2c6..92407cb 100644 --- a/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c @@ -287,11 +287,6 @@ static int gmc_v8_0_mc_load_microcode(struct amdgpu_device *adev) running = REG_GET_FIELD(RREG32(mmMC_SEQ_SUP_CNTL), MC_SEQ_SUP_CNTL, RUN); if (running == 0) { - if (running) { - blackout = RREG32(mmMC_SHARED_BLACKOUT_CNTL); - WREG32(mmMC_SHARED_BLACKOUT_CNTL, blackout | 1); - } - /* reset the engine and set to writable */ WREG32(mmMC_SEQ_SUP_CNTL, 0x00000008); WREG32(mmMC_SEQ_SUP_CNTL, 0x00000010); @@ -323,9 +318,6 @@ static int gmc_v8_0_mc_load_microcode(struct amdgpu_device *adev) break; udelay(1); } - - if (running) - WREG32(mmMC_SHARED_BLACKOUT_CNTL, blackout); } return 0;