From patchwork Fri Aug 26 14:25:25 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 9301531 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 893D460757 for ; Fri, 26 Aug 2016 15:01:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7AEF129576 for ; Fri, 26 Aug 2016 15:01:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6E6D3295A8; Fri, 26 Aug 2016 15:01:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 79B9D29576 for ; Fri, 26 Aug 2016 15:01:02 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B77146EAE8; Fri, 26 Aug 2016 15:00:59 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pf0-x242.google.com (mail-pf0-x242.google.com [IPv6:2607:f8b0:400e:c00::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8321B6EACD for ; Fri, 26 Aug 2016 14:25:51 +0000 (UTC) Received: by mail-pf0-x242.google.com with SMTP id y134so4992619pfg.3 for ; Fri, 26 Aug 2016 07:25:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=W8MNZgUYeQBtUYzb0v43/IF0sgCbdHg+UtQpnlMxpN4=; b=VlYpYMOolXcQzvJ6X0NUIuRyU/IuRzin0MAZjoWuoZXwyvOBCXg+J3ArJE/LNcEmN5 wUb1twaHN3rLZIlTpsUbatH+U+fFQvOoe7VzTi2gc0P861LvxrBRTFOUC1XBoKXf8jYO G7vm8Dlz79ZE8p0o9+sj46k9E707Lc9CAz+OeeNTTDImbQomAGZKUYi9hCw+7pKrrffu IDo99+VWVCefNqE9htTR0sMptw23cCN9fqiCpyA6DfzNS2R2teNyC4qlClAsDmvvXrAl EHn/O6HbKKvdFpKc0fKBcYc5DTqK2Irq0rwEJuBt0ja081kwm1PpidymAXEFVAQsTj4u ZW1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=W8MNZgUYeQBtUYzb0v43/IF0sgCbdHg+UtQpnlMxpN4=; b=N7Fuot0Ska0oufajMfvC+bI9TveGvE6vPA8Ptv75Rl25Aqnd7aE1f0r53Rky6KtQeL yjXV5AD3SsmRJDqATH3XBLDEJXrvA+pmGhtVjkpX0/xOe1pViGAa6wyvIlZI81FEtHoy NRY//8vUmgVrqm744PUIl11KAyViqAfPPSsrCGkLd1NTYGvM2Q6erkGtfRG+rzYPJsWz 9j4bBAwDBu+Pg1KjIgtJG9E2WITOWJXiS3DhswAI978lgqzd7lGeKGYs+CPBYeLyDM5H xrZQUpjNOCsNtt5SXSN/fk32ynniemWyWrnZXiJea6AxzAdepGdbYnjFm7QBgPIQ4kPO ULPA== X-Gm-Message-State: AE9vXwNJobEdIHtqX13ODMKiXaI4tc88U4bk8pWv/XfagjiwGccmfrCUfpKO5QAAzHEcyg== X-Received: by 10.98.14.72 with SMTP id w69mr6398760pfi.119.1472221551160; Fri, 26 Aug 2016 07:25:51 -0700 (PDT) Received: from localhost.localdomain.localdomain (ec2-52-192-197-227.ap-northeast-1.compute.amazonaws.com. [52.192.197.227]) by smtp.gmail.com with ESMTPSA id o80sm29282871pfa.67.2016.08.26.07.25.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Aug 2016 07:25:50 -0700 (PDT) From: Wei Yongjun To: Maxime Ripard , David Airlie , Chen-Yu Tsai Subject: [PATCH -next] drm/sun4i: Remove redundant dev_err call in sun4i_tcon_init_regmap() Date: Fri, 26 Aug 2016 14:25:25 +0000 Message-Id: <1472221525-27706-1-git-send-email-weiyj.lk@gmail.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-Mailman-Approved-At: Fri, 26 Aug 2016 15:00:21 +0000 Cc: Wei Yongjun , linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Wei Yongjun There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun --- drivers/gpu/drm/sun4i/sun4i_tcon.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c index 2145ecf..9180e7e 100644 --- a/drivers/gpu/drm/sun4i/sun4i_tcon.c +++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c @@ -374,10 +374,8 @@ static int sun4i_tcon_init_regmap(struct device *dev, res = platform_get_resource(pdev, IORESOURCE_MEM, 0); regs = devm_ioremap_resource(dev, res); - if (IS_ERR(regs)) { - dev_err(dev, "Couldn't map the TCON registers\n"); + if (IS_ERR(regs)) return PTR_ERR(regs); - } tcon->regs = devm_regmap_init_mmio(dev, regs, &sun4i_tcon_regmap_config);