From patchwork Sun Aug 28 15:28:46 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrea Arcangeli X-Patchwork-Id: 9303023 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DBD0D60757 for ; Mon, 29 Aug 2016 00:41:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CE36C287DA for ; Mon, 29 Aug 2016 00:41:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C2B17287E3; Mon, 29 Aug 2016 00:41:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 85DC7287DA for ; Mon, 29 Aug 2016 00:41:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5AEC26E3EE; Mon, 29 Aug 2016 00:41:14 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3AD066E274 for ; Sun, 28 Aug 2016 15:28:49 +0000 (UTC) Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8260A83F38; Sun, 28 Aug 2016 15:28:48 +0000 (UTC) Received: from mail.random (ovpn-116-50.ams2.redhat.com [10.36.116.50]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u7SFSkPk014567 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 28 Aug 2016 11:28:48 -0400 From: Andrea Arcangeli To: =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= , Dave Airlie Subject: [PATCH 1/1] drm: i915: don't use OpRegion for XPS 13 IvyBridge Date: Sun, 28 Aug 2016 17:28:46 +0200 Message-Id: <1472398126-1095-2-git-send-email-aarcange@redhat.com> In-Reply-To: <1472398126-1095-1-git-send-email-aarcange@redhat.com> References: <1472398126-1095-1-git-send-email-aarcange@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Sun, 28 Aug 2016 15:28:48 +0000 (UTC) X-Mailman-Approved-At: Mon, 29 Aug 2016 00:40:34 +0000 Cc: dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Skylake was already singled out, but it doesn't cover the XPS 13 L332X model which is based on IvyBridge. The commit that introduced the regression is 1d6da87a3241deb13d073c4125d19ed0e5a0c62c The Skylake workaround for the regression was introduced in commit aeddda06c1a704bb97c8a7bfe7a472120193bd56 Signed-off-by: Andrea Arcangeli --- drivers/gpu/drm/i915/intel_opregion.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c index adca262..ca17ab6 100644 --- a/drivers/gpu/drm/i915/intel_opregion.c +++ b/drivers/gpu/drm/i915/intel_opregion.c @@ -1073,12 +1073,14 @@ intel_opregion_get_panel_type(struct drm_i915_private *dev_priv) } /* - * FIXME On Dell XPS 13 9350 the OpRegion panel type (0) gives us - * low vswing for eDP, whereas the VBT panel type (2) gives us normal - * vswing instead. Low vswing results in some display flickers, so - * let's simply ignore the OpRegion panel type on SKL for now. + * FIXME On Dell XPS 13 9350 and Dell XPS 13 L322X the + * OpRegion panel type (0) gives us low vswing for eDP, + * whereas the VBT panel type (2) gives us normal vswing + * instead. Low vswing results in some display flickers, so + * let's simply ignore the OpRegion panel type on SKL and + * IVYBRIDGE for now. */ - if (IS_SKYLAKE(dev_priv)) { + if (IS_SKYLAKE(dev_priv) || IS_IVYBRIDGE(dev_priv)) { DRM_DEBUG_KMS("Ignoring OpRegion panel type (%d)\n", ret - 1); return -ENODEV; }