| Message ID | 1472475747-30296-1-git-send-email-baoyou.xie@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 30 August 2016 at 00:01, Sean Paul <seanpaul@google.com> wrote: > On Mon, Aug 29, 2016 at 9:02 AM, Baoyou Xie <baoyou.xie@linaro.org> wrote: > > We get 1 warning when build kernel with W=1: > > drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c:937:1: warning: no > previous prototype for 'gm107_grctx_generate_tpcid' [-Wmissing-prototypes] > > > > In fact, this function is only used in the file in which it is > > declared and don't need a declaration, but can be made static. > > so this patch marks this function with 'static'. > > > > It would make things a lot easier if you either consolidated all of > these static changes into one patch, or released them as a series. > > Do you mean that I need to consolidate all of them into one patch this time? or next time? > Sean > > > > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> > > --- > > drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c > b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c > > index 6d3c501..4c4b5ab 100644 > > --- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c > > +++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c > > @@ -933,7 +933,7 @@ gm107_grctx_generate_attrib(struct gf100_grctx > *info) > > } > > } > > > > -void > > +static void > > gm107_grctx_generate_tpcid(struct gf100_gr *gr) > > { > > struct nvkm_device *device = gr->base.engine.subdev.device; > > -- > > 2.7.4 > > >
On Tuesday 30 August 2016, Baoyou Xie wrote: > On 30 August 2016 at 00:01, Sean Paul <seanpaul@google.com> wrote: > > > On Mon, Aug 29, 2016 at 9:02 AM, Baoyou Xie <baoyou.xie@linaro.org> wrote: > > > We get 1 warning when build kernel with W=1: > > > drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c:937:1: warning: no > > previous prototype for 'gm107_grctx_generate_tpcid' [-Wmissing-prototypes] > > > > > > In fact, this function is only used in the file in which it is > > > declared and don't need a declaration, but can be made static. > > > so this patch marks this function with 'static'. > > > > > > > It would make things a lot easier if you either consolidated all of > > these static changes into one patch, or released them as a series. > > > > > Do you mean that I need to consolidate all of them into one patch this > time? or next time? I'd suggest consolidating the 'nouveau' changes into a single patch, as this is one (very big) driver and resend that one. Arnd
dear all:
I have resend a patch, which consolidate the 'nouveau' changes into it,
its subject is "drm/nouveau: silence warnings reported during builds with
W=1".
FYI.
On 30 August 2016 at 20:40, Arnd Bergmann <arnd@arndb.de> wrote:
> On Tuesday 30 August 2016, Baoyou Xie wrote:
> > On 30 August 2016 at 00:01, Sean Paul <seanpaul@google.com> wrote:
> >
> > > On Mon, Aug 29, 2016 at 9:02 AM, Baoyou Xie <baoyou.xie@linaro.org>
> wrote:
> > > > We get 1 warning when build kernel with W=1:
> > > > drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c:937:1: warning: no
> > > previous prototype for 'gm107_grctx_generate_tpcid'
> [-Wmissing-prototypes]
> > > >
> > > > In fact, this function is only used in the file in which it is
> > > > declared and don't need a declaration, but can be made static.
> > > > so this patch marks this function with 'static'.
> > > >
> > >
> > > It would make things a lot easier if you either consolidated all of
> > > these static changes into one patch, or released them as a series.
> > >
> > >
> > Do you mean that I need to consolidate all of them into one patch this
> > time? or next time?
>
> I'd suggest consolidating the 'nouveau' changes into a single patch,
> as this is one (very big) driver and resend that one.
>
> Arnd
>
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c index 6d3c501..4c4b5ab 100644 --- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c +++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c @@ -933,7 +933,7 @@ gm107_grctx_generate_attrib(struct gf100_grctx *info) } } -void +static void gm107_grctx_generate_tpcid(struct gf100_gr *gr) { struct nvkm_device *device = gr->base.engine.subdev.device;
We get 1 warning when build kernel with W=1: drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c:937:1: warning: no previous prototype for 'gm107_grctx_generate_tpcid' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static. so this patch marks this function with 'static'. Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> --- drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)