| Message ID | 1473863952-7658-5-git-send-email-yamada.masahiro@socionext.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Masahiro, 2016-09-14 Masahiro Yamada <yamada.masahiro@socionext.com>: > Remove unneeded variables and assignments. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > drivers/gpu/drm/qxl/qxl_draw.c | 7 ++----- > drivers/gpu/drm/qxl/qxl_release.c | 7 ++----- > 2 files changed, 4 insertions(+), 10 deletions(-) Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk> Gustavo
2016-09-14 Masahiro Yamada <yamada.masahiro@socionext.com>: > Remove unneeded variables and assignments. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > drivers/gpu/drm/qxl/qxl_draw.c | 7 ++----- > drivers/gpu/drm/qxl/qxl_release.c | 7 ++----- > 2 files changed, 4 insertions(+), 10 deletions(-) For patches 1 to 4: Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk> Gustavo
On Thu, Sep 15, 2016 at 9:47 AM, Gustavo Padovan <gustavo@padovan.org> wrote: > 2016-09-14 Masahiro Yamada <yamada.masahiro@socionext.com>: > >> Remove unneeded variables and assignments. >> >> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> >> --- >> >> drivers/gpu/drm/qxl/qxl_draw.c | 7 ++----- >> drivers/gpu/drm/qxl/qxl_release.c | 7 ++----- >> 2 files changed, 4 insertions(+), 10 deletions(-) > > For patches 1 to 4: > > Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk> Applied to drm-misc Sean > > Gustavo > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/qxl/qxl_draw.c b/drivers/gpu/drm/qxl/qxl_draw.c index ffe8853..9b728ed 100644 --- a/drivers/gpu/drm/qxl/qxl_draw.c +++ b/drivers/gpu/drm/qxl/qxl_draw.c @@ -57,11 +57,8 @@ static struct qxl_rect *drawable_set_clipping(struct qxl_device *qdev, static int alloc_drawable(struct qxl_device *qdev, struct qxl_release **release) { - int ret; - ret = qxl_alloc_release_reserved(qdev, sizeof(struct qxl_drawable), - QXL_RELEASE_DRAWABLE, release, - NULL); - return ret; + return qxl_alloc_release_reserved(qdev, sizeof(struct qxl_drawable), + QXL_RELEASE_DRAWABLE, release, NULL); } static void diff --git a/drivers/gpu/drm/qxl/qxl_release.c b/drivers/gpu/drm/qxl/qxl_release.c index f599cd0..cd83f05 100644 --- a/drivers/gpu/drm/qxl/qxl_release.c +++ b/drivers/gpu/drm/qxl/qxl_release.c @@ -203,12 +203,9 @@ static long qxl_fence_wait(struct fence *fence, bool intr, signed long timeout) static int qxl_release_bo_alloc(struct qxl_device *qdev, struct qxl_bo **bo) { - int ret; /* pin releases bo's they are too messy to evict */ - ret = qxl_bo_create(qdev, PAGE_SIZE, false, true, - QXL_GEM_DOMAIN_VRAM, NULL, - bo); - return ret; + return qxl_bo_create(qdev, PAGE_SIZE, false, true, + QXL_GEM_DOMAIN_VRAM, NULL, bo); } int qxl_release_list_add(struct qxl_release *release, struct qxl_bo *bo)
Remove unneeded variables and assignments. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- drivers/gpu/drm/qxl/qxl_draw.c | 7 ++----- drivers/gpu/drm/qxl/qxl_release.c | 7 ++----- 2 files changed, 4 insertions(+), 10 deletions(-)