From patchwork Mon Sep 19 09:34:19 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Griffin X-Patchwork-Id: 9340883 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B63906077A for ; Tue, 20 Sep 2016 02:43:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A33B929B7A for ; Tue, 20 Sep 2016 02:43:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 97EF628FF9; Tue, 20 Sep 2016 02:43:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9255628FF9 for ; Tue, 20 Sep 2016 02:43:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7A7EE6E5E1; Tue, 20 Sep 2016 02:43:29 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm0-x22d.google.com (mail-wm0-x22d.google.com [IPv6:2a00:1450:400c:c09::22d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7DB186E2F6 for ; Mon, 19 Sep 2016 09:34:29 +0000 (UTC) Received: by mail-wm0-x22d.google.com with SMTP id w84so65988507wmg.1 for ; Mon, 19 Sep 2016 02:34:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=9Se6TwhOOl2oUIcULKMsoEElqpnU5nz+SPdWM+8NqJU=; b=C0QOFiOplvw4IAvuDjAE/RMDb+23aS2j7TVBo1k+UvKEb7ViAZPrKqBGDMCmdvUD62 A5ZE448TFEJICgu7r82DWkCBeSv0oxLWm9m8+X/yg8hiN/Rk/QYxhMzkmbpqmGh41OCl nadH9PRSnhHUsbISAFto/hQUT17ltg2NbWT4k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=9Se6TwhOOl2oUIcULKMsoEElqpnU5nz+SPdWM+8NqJU=; b=GT1vStLSGiDJbSEocnJ4gx7iEmad3oU9sj5GZfCUQdGHObea0d2n9IEl/s7qfO8IR8 5HChbPm5O9ULyq2tRavmj0RlYBZRXN4n41bWxh/11cL6ysuw/4AxH7Epbr01APVqbMpp OKbxWDq2P9m0gZBJ0otlT2ou1bY1Qd6/h29ya6s0ZayWKdnxqCkTqU2X9v0IjbZGeMpK nV9CRXwVqWDb3/zspi7bacuql05HUIUxH6irvVFQwbpKSGkcPoPlJ2Q4w2CpsAhzGgct xErkjpz0Xm1olsmiZbLWBAYLZFFKqA9U5Ie/l5XRE2vCsTVdQ1mgoo6zoAvNE+gxmzcQ WEAQ== X-Gm-Message-State: AE9vXwN7ARxF3Xaah3dbs50N+3maRahgT5Zjwj6KG+xsizjIvIrDxpEtgY08kbF6SUY/3gD7 X-Received: by 10.28.91.11 with SMTP id p11mr7836773wmb.98.1474277667231; Mon, 19 Sep 2016 02:34:27 -0700 (PDT) Received: from localhost.localdomain (cpc89244-aztw30-2-0-cust4998.18-1.cable.virginm.net. [86.31.179.135]) by smtp.gmail.com with ESMTPSA id 137sm21119431wmi.16.2016.09.19.02.34.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 19 Sep 2016 02:34:26 -0700 (PDT) From: Peter Griffin To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@stlinux.com, airlied@linux.ie, kraxel@redhat.com, vinod.koul@intel.com, sfr@canb.auug.org.au, bjorn.andersson@linaro.org Subject: [PATCH 1/2] drm/virtio: kconfig: Fix recursive dependency issue. Date: Mon, 19 Sep 2016 10:34:19 +0100 Message-Id: <1474277660-5196-2-git-send-email-peter.griffin@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1474277660-5196-1-git-send-email-peter.griffin@linaro.org> References: <1474277660-5196-1-git-send-email-peter.griffin@linaro.org> X-Mailman-Approved-At: Tue, 20 Sep 2016 02:42:21 +0000 Cc: peter.griffin@linaro.org, lee.jones@linaro.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP ST_SLIM_REMOTEPROC must select REMOTEPROC, which exposes the following recursive dependency. [..] drivers/video/fbdev/Kconfig:5:error: recursive dependency detected! For a resolution refer to Documentation/kbuild/kconfig-language.txt subsection "Kconfig recursive dependency limitations" drivers/video/fbdev/Kconfig:5: symbol FB is selected by DRM_KMS_FB_HELPER For a resolution refer to Documentation/kbuild/kconfig-language.txt subsection "Kconfig recursive dependency limitations" drivers/gpu/drm/Kconfig:42: symbol DRM_KMS_FB_HELPER depends on DRM_KMS_HELPER For a resolution refer to Documentation/kbuild/kconfig-language.txt subsection "Kconfig recursive dependency limitations" drivers/gpu/drm/Kconfig:36: symbol DRM_KMS_HELPER is selected by DRM_VIRTIO_GPU For a resolution refer to Documentation/kbuild/kconfig-language.txt subsection "Kconfig recursive dependency limitations" drivers/gpu/drm/virtio/Kconfig:1: symbol DRM_VIRTIO_GPU depends on VIRTIO For a resolution refer to Documentation/kbuild/kconfig-language.txt subsection "Kconfig recursive dependency limitations" drivers/virtio/Kconfig:1: symbol VIRTIO is selected by REMOTEPROC For a resolution refer to Documentation/kbuild/kconfig-language.txt subsection "Kconfig recursive dependency limitations" drivers/remoteproc/Kconfig:4: symbol REMOTEPROC is selected by ST_SLIM_REMOTEPROC For a resolution refer to Documentation/kbuild/kconfig-language.txt subsection "Kconfig recursive dependency limitations" drivers/remoteproc/Kconfig:103: symbol ST_SLIM_REMOTEPROC is selected by ST_FDMA For a resolution refer to Documentation/kbuild/kconfig-language.txt subsection "Kconfig recursive dependency limitations" drivers/dma/Kconfig:440: symbol ST_FDMA depends on DMADEVICES For a resolution refer to Documentation/kbuild/kconfig-language.txt subsection "Kconfig recursive dependency limitations" drivers/dma/Kconfig:5: symbol DMADEVICES is selected by SND_SOC_SH4_SIU For a resolution refer to Documentation/kbuild/kconfig-language.txt subsection "Kconfig recursive dependency limitations" sound/soc/sh/Kconfig:29: symbol SND_SOC_SH4_SIU is selected by SND_SIU_MIGOR For a resolution refer to Documentation/kbuild/kconfig-language.txt subsection "Kconfig recursive dependency limitations" sound/soc/sh/Kconfig:64: symbol SND_SIU_MIGOR depends on I2C For a resolution refer to Documentation/kbuild/kconfig-language.txt subsection "Kconfig recursive dependency limitations" drivers/i2c/Kconfig:7: symbol I2C is selected by FB_DDC For a resolution refer to Documentation/kbuild/kconfig-language.txt subsection "Kconfig recursive dependency limitations" drivers/video/fbdev/Kconfig:63: symbol FB_DDC is selected by FB_CYBER2000_DDC For a resolution refer to Documentation/kbuild/kconfig-language.txt subsection "Kconfig recursive dependency limitations" drivers/video/fbdev/Kconfig:378: symbol FB_CYBER2000_DDC depends on FB_CYBER2000 For a resolution refer to Documentation/kbuild/kconfig-language.txt subsection "Kconfig recursive dependency limitations" drivers/video/fbdev/Kconfig:366: symbol FB_CYBER2000 depends on FB which is due to drivers/gpu/drm/virtio/Kconfig depending on VIRTIO. Fix by dropping depend and switching to select VIRTIO. Signed-off-by: Peter Griffin --- drivers/gpu/drm/virtio/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/virtio/Kconfig b/drivers/gpu/drm/virtio/Kconfig index e1afc3d..90357d9 100644 --- a/drivers/gpu/drm/virtio/Kconfig +++ b/drivers/gpu/drm/virtio/Kconfig @@ -1,6 +1,7 @@ config DRM_VIRTIO_GPU tristate "Virtio GPU driver" - depends on DRM && VIRTIO + depends on DRM + select VIRTIO select DRM_KMS_HELPER select DRM_TTM help