| Message ID | 1474747650-10306-1-git-send-email-christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sat, Sep 24, 2016 at 10:07:30PM +0200, Christophe JAILLET wrote: > 'brick' has been allocated by 'devm_kzalloc', so there is no need here to > free it explicitly. > There is only one caller of 'tegra_clk_sor_brick_register()'. This function > is a probe function which correctly checks and handles the return value of > 'tegra_clk_sor_brick_register()'. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > drivers/gpu/drm/tegra/sor.c | 2 -- > 1 file changed, 2 deletions(-) Applied, with a slightly reworded commit message. Thanks, Thierry
diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c index 74d0540b8d4c..a8f528925009 100644 --- a/drivers/gpu/drm/tegra/sor.c +++ b/drivers/gpu/drm/tegra/sor.c @@ -349,8 +349,6 @@ static struct clk *tegra_clk_sor_brick_register(struct tegra_sor *sor, brick->hw.init = &init; clk = devm_clk_register(sor->dev, &brick->hw); - if (IS_ERR(clk)) - kfree(brick); return clk; }
'brick' has been allocated by 'devm_kzalloc', so there is no need here to free it explicitly. There is only one caller of 'tegra_clk_sor_brick_register()'. This function is a probe function which correctly checks and handles the return value of 'tegra_clk_sor_brick_register()'. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/gpu/drm/tegra/sor.c | 2 -- 1 file changed, 2 deletions(-)