| Message ID | 1476124552-23449-1-git-send-email-hshi@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Oct 10, 2016 at 2:35 PM, Haixia Shi <hshi@chromium.org> wrote: > The AUO t215hvn01 is a 21.5" 1920x1080 panel. > > v2: fix alphabetical order > > Signed-off-by: Haixia Shi <hshi@chromium.org> > Tested-by: Haixia Shi <hshi@chromium.org> > Reviewed-by: Stéphane Marchesin <marcheu@chromium.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> > --- > drivers/gpu/drm/panel/panel-simple.c | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 113db3c..54dbb98 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -555,6 +555,33 @@ static const struct panel_desc auo_b133htn01 = { > }, > }; > > +static const struct drm_display_mode auo_t215hvn01_mode = { > + .clock = 148800, > + .hdisplay = 1920, > + .hsync_start = 1920 + 88, > + .hsync_end = 1920 + 88 + 44, > + .htotal = 1920 + 88 + 44 + 148, > + .vdisplay = 1080, > + .vsync_start = 1080 + 4, > + .vsync_end = 1080 + 4 + 5, > + .vtotal = 1080 + 4 + 5 + 36, > + .vrefresh = 60, > +}; > + > +static const struct panel_desc auo_t215hvn01 = { > + .modes = &auo_t215hvn01_mode, > + .num_modes = 1, > + .bpc = 8, > + .size = { > + .width = 430, > + .height = 270, > + }, > + .delay = { > + .disable = 5, > + .unprepare = 1000, > + } > +}; > + > static const struct drm_display_mode avic_tm070ddh03_mode = { > .clock = 51200, > .hdisplay = 1024, > @@ -1575,6 +1602,9 @@ static const struct of_device_id platform_of_match[] = { > .compatible = "auo,b133xtn01", > .data = &auo_b133xtn01, > }, { > + .compatible = "auo,t215hvn01.0", > + .data = &auo_t215hvn01, > + }, { > .compatible = "avic,tm070ddh03", > .data = &avic_tm070ddh03, > }, { > -- > 2.8.0.rc3.226.g39d4020 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
On 10 October 2016 at 19:35, Haixia Shi <hshi@chromium.org> wrote: > The AUO t215hvn01 is a 21.5" 1920x1080 panel. > > v2: fix alphabetical order > Thanks for this and dropping the CHOMIUM/Reviewed-on tags. > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -1575,6 +1602,9 @@ static const struct of_device_id platform_of_match[] = { > .compatible = "auo,b133xtn01", > .data = &auo_b133xtn01, > }, { > + .compatible = "auo,t215hvn01.0", We haven't had any compatible strings which end with .0 (or any other number for that matter) for drm panels. The DT binding documentation should mention why, yet there doesn't seem to be a patch for that ? You want one (be that separate patch or part of this one), regardless if the simple panel driver is used or not. If you want to be extra nice to Thierry/Rob H you can even add a link to the spec/data sheet :-) -Emil
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 113db3c..54dbb98 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -555,6 +555,33 @@ static const struct panel_desc auo_b133htn01 = { }, }; +static const struct drm_display_mode auo_t215hvn01_mode = { + .clock = 148800, + .hdisplay = 1920, + .hsync_start = 1920 + 88, + .hsync_end = 1920 + 88 + 44, + .htotal = 1920 + 88 + 44 + 148, + .vdisplay = 1080, + .vsync_start = 1080 + 4, + .vsync_end = 1080 + 4 + 5, + .vtotal = 1080 + 4 + 5 + 36, + .vrefresh = 60, +}; + +static const struct panel_desc auo_t215hvn01 = { + .modes = &auo_t215hvn01_mode, + .num_modes = 1, + .bpc = 8, + .size = { + .width = 430, + .height = 270, + }, + .delay = { + .disable = 5, + .unprepare = 1000, + } +}; + static const struct drm_display_mode avic_tm070ddh03_mode = { .clock = 51200, .hdisplay = 1024, @@ -1575,6 +1602,9 @@ static const struct of_device_id platform_of_match[] = { .compatible = "auo,b133xtn01", .data = &auo_b133xtn01, }, { + .compatible = "auo,t215hvn01.0", + .data = &auo_t215hvn01, + }, { .compatible = "avic,tm070ddh03", .data = &avic_tm070ddh03, }, {