From patchwork Mon Oct 31 11:59:56 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rongrong Zou X-Patchwork-Id: 9406767 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DD04760721 for ; Tue, 1 Nov 2016 01:08:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9AD8F28ADB for ; Tue, 1 Nov 2016 01:08:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8E15829385; Tue, 1 Nov 2016 01:08:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C36CC28ADB for ; Tue, 1 Nov 2016 01:08:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0DDA06E39D; Tue, 1 Nov 2016 01:08:29 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-yb0-x244.google.com (mail-yb0-x244.google.com [IPv6:2607:f8b0:4002:c09::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1A2C46E289 for ; Mon, 31 Oct 2016 12:05:20 +0000 (UTC) Received: by mail-yb0-x244.google.com with SMTP id e129so198903yba.2 for ; Mon, 31 Oct 2016 05:05:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=pwfISgAoGcMKtb3HVUjTBsGNQeCBB7HF799MKkHGrHs=; b=q0LfHrHEBR4r36CcG53yl8fBqgaEio7DvI7v3/nCcL6FuZ/mJn5Z+7CI3zXUis+UgL 5YwD9aj/c17IpgyzXd5AMPgqmWpY4Yk4kkBvaq3sKvnApoYFPAJKjw3kgLRp4drePyyP LijPZDPx71WArz9jS7Wl+zx8lbUporDVAoeTrtykwrLNbqpfQxS0IOClUlBk/rsogkNr XdCIBS6xAQk1aV1idW7glT1DzbBQxQFKqV2AElyQEbu1nH+nD6QzGn+bfydY03Mzpyhe nb1Nfx4p38+9PL06LVeNhv7OIfom0Ww1+KXiz/jCmeXoj/KVcsl5J1omvaVGmEU6vPOb SxMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=pwfISgAoGcMKtb3HVUjTBsGNQeCBB7HF799MKkHGrHs=; b=BD17tP3sL7f+AY0NWE2QUKrb/ronnL77hAhgzwFh0frIwV38Hx45OIRZbdKZr6pUnj 71FHlGSPFRUKg0YIRu6zD9ytCVpCt3FtSIP0h3YuPRrG6fU8Ok5hAeGppe9aMfesZNw7 OWpMmk7VPZfvG+0lC9Twr4nN0V4O4ZlKBdCI7/SbiXKWiqifGkFVTg+6204pQ5DF/x9W r8OQoFs0vUqu+7cjyyDvjO2g021irYtS+I50+4rpfSii0GC/Ktu8BZcF/iiW+ddQp7BG cWEUm8/G9WUww8/WqhQ4+zvWZNowwBiwNwfhKPxRJsOq/V75T9JrZXKmMQdes/RWQ+1I mzYA== X-Gm-Message-State: ABUngvep1uBXsBfelLf1dwIA6zFVEsGqPvw6oOJ36Okc3jWLojBDPaFlYefnTR3bXwOq+w== X-Received: by 10.37.230.201 with SMTP id d192mr24464092ybh.84.1477915519250; Mon, 31 Oct 2016 05:05:19 -0700 (PDT) Received: from localhost.localdomain ([119.145.15.121]) by smtp.gmail.com with ESMTPSA id i18sm1350666ywe.44.2016.10.31.05.01.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 31 Oct 2016 05:05:18 -0700 (PDT) From: Rongrong Zou To: airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, emil.l.velikov@gmail.com, tomeu.vizoso@collabora.com, benjamin.gaignard@linaro.org, robh@kernel.org, daniel@fooishbar.org, architt@codeaurora.org, corbet@lwn.net, xinliang.liu@linaro.org Subject: [PATCH] drm: update the documentation of drm_framebuffer_unregister_private Date: Mon, 31 Oct 2016 19:59:56 +0800 Message-Id: <1477915196-100299-1-git-send-email-zourongrong@gmail.com> X-Mailer: git-send-email 1.9.1 X-Mailman-Approved-At: Tue, 01 Nov 2016 01:08:23 +0000 Cc: linuxarm@huawei.com, james.xiong@huawei.com, shenhui@huawei.com, guohanjun@huawei.com, lijianhua@huawei.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Add obvious description to drm_framebuffer_unregister_private() to explain it is deprecated. Signed-off-by: Rongrong Zou --- drivers/gpu/drm/drm_framebuffer.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/drm_framebuffer.c b/drivers/gpu/drm/drm_framebuffer.c index 398efd6..d2b0507 100644 --- a/drivers/gpu/drm/drm_framebuffer.c +++ b/drivers/gpu/drm/drm_framebuffer.c @@ -751,6 +751,11 @@ struct drm_framebuffer *drm_framebuffer_lookup(struct drm_device *dev, * those used for fbdev. Note that the caller must hold a reference of it's own, * i.e. the object may not be destroyed through this call (since it'll lead to a * locking inversion). + * + * NOTE: This function is deprecated. For driver-private framebuffers it is not + * recommended to embed a framebuffer struct info fbdev struct, instead, a + * framebuffer pointer is preferred and drm_framebuffer_unreference() should be + * called when the framebuffer is to be cleaned up. */ void drm_framebuffer_unregister_private(struct drm_framebuffer *fb) {