From patchwork Wed Nov 9 03:53:34 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Caesar Wang X-Patchwork-Id: 9418463 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DADDC6022E for ; Wed, 9 Nov 2016 03:53:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CCBDF286BE for ; Wed, 9 Nov 2016 03:53:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BE3F128DB7; Wed, 9 Nov 2016 03:53:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4A9DA286BE for ; Wed, 9 Nov 2016 03:53:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4D2706E627; Wed, 9 Nov 2016 03:53:53 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pf0-f194.google.com (mail-pf0-f194.google.com [209.85.192.194]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4C0766E627 for ; Wed, 9 Nov 2016 03:53:52 +0000 (UTC) Received: by mail-pf0-f194.google.com with SMTP id n85so21887860pfi.3 for ; Tue, 08 Nov 2016 19:53:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=bqPhyuvsxh+sqqblzG31AFWW8+H1u8wArBzB7KhtMM8=; b=TBHz9Ntr2XL4b4CaIuAZbLVw/bWlGgRGH690aiNaBRWW5K9imU5+9u5cecwKtOHUvB JPNdF72NQxBySBnRaoMYfktcidUKlHsVu0HcI+F15KHLU4y7GuxHW9KGGECqtcla7S7S 5hiuUG01vxgPTXdOv5ADDC0naH/Z2fbtBKBeQ5+ifrefsMcEQjPM/dRO1EigTCxa2J9D cVy3jt5VxAwSXKjBDX2JyYVzQaM6qJQKwn9n7ZPRN5Cwhj5BY4ESa7S5CizQiLgSz8xh 7twSrPkwoi2KX4MVlGtRsFR/hWqYvbIp5UI8enc5KQMcVBSVi82ee4Fo+fMOl+/TEIYb JF1A== X-Gm-Message-State: ABUngvdPY2Ny8BulQgN4WMtD43pN8by557t9Qv+gDujX+4E0DllB7FlePZed/gCY9VeT8Q== X-Received: by 10.98.85.135 with SMTP id j129mr29253771pfb.28.1478663631966; Tue, 08 Nov 2016 19:53:51 -0800 (PST) Received: from localhost.localdomain ([103.29.142.67]) by smtp.gmail.com with ESMTPSA id s3sm51285927pfe.27.2016.11.08.19.53.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 08 Nov 2016 19:53:51 -0800 (PST) From: Caesar Wang To: seanpaul@chromium.org Subject: drm/bridge: analogix_dp: clear psr_support when disable_bridge Date: Wed, 9 Nov 2016 11:53:34 +0800 Message-Id: <1478663614-9914-1-git-send-email-wxt@rock-chips.com> X-Mailer: git-send-email 2.7.4 Cc: zain wang , tomeu.vizoso@collabora.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, marcheu@chromium.org, Caesar Wang X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: zain wang Don't run psr work during enabling bridge when you restart ui, it may make link training fail since there is a race between them in AUX CH resource. Signed-off-by: zain wang Signed-off-by: Caesar Wang Cc: Tomeu Vizoso Cc: dri-devel@lists.freedesktop.org Cc: Sean Paul --- BTW: - The training issue is gone with this patch, there are four machines have passed the 10000 cycles with S2R tests. - Verified on ChromeOS kernelv4.4. drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index 6e0447f..4431f62 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -1117,6 +1117,7 @@ static void analogix_dp_bridge_disable(struct drm_bridge *bridge) if (ret) DRM_ERROR("failed to setup the panel ret = %d\n", ret); + dp->psr_support = false; dp->dpms_mode = DRM_MODE_DPMS_OFF; }