From patchwork Wed Nov 9 12:36:36 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 9419157 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2139260512 for ; Wed, 9 Nov 2016 12:36:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 110B7287C3 for ; Wed, 9 Nov 2016 12:36:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 03FC929210; Wed, 9 Nov 2016 12:36:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RCVD_IN_SORBS_SPAM,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id CD087287C3 for ; Wed, 9 Nov 2016 12:36:49 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8A2276E686; Wed, 9 Nov 2016 12:36:48 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pf0-x244.google.com (mail-pf0-x244.google.com [IPv6:2607:f8b0:400e:c00::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id EADC86E686 for ; Wed, 9 Nov 2016 12:36:47 +0000 (UTC) Received: by mail-pf0-x244.google.com with SMTP id i88so132655pfk.2 for ; Wed, 09 Nov 2016 04:36:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id; bh=to8E9xGApgXDbw0/DnSMvGOE4VIojQddj3fRblSTnCU=; b=B7SWUQ9PhhPBzacTUhWytxemK7nyCEVS94N4TdXK+wqziL7ZXs1Hk2olwVaG35iuiE ib+5xWQfGUmY3zCEYlQNPz3bYKUk+th9YOacxSUFPONsdyuxyHbiIJq01amXcqiFtw28 Y/ZgpGrVpMdRR2Togf1kT3SoVPd6v6HJhbrV4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=to8E9xGApgXDbw0/DnSMvGOE4VIojQddj3fRblSTnCU=; b=IEqYJ8kqMmoTwM0z0+ufY2OyoKHDto5RIb4hSRe4wIEUnIJeQFx74ZEGu5EZqLF/B8 68LUKKd1/xjvV+FceLNFYaPhzb7jMeXfFSfCOXrJq/cSrGTrkjiw+9Ohic4bUapW+4gV KmwMYQtcPk6om2wX/qlKO+uoBa80cebp65Smb3Vicz/Lind467uiDm7TqIX13P1NzMhB i4X4Jvqx1NpyUpkct4PdW98Z1I5h+zvkrIokAAT8ucMBwwP1i/p2MAzfq24+WPUopY1v uX/c9phlePaP6E2ZKsCpcKITrF9MlkQJ7zNDuqiD4aOlTgJyJsnuI+UeT/dZmQznymOL d4VA== X-Gm-Message-State: ABUngvfroR3mn8hO23yUn1+sVpLPkke0z4VPRyMMyLEW+NS5rj0II0vGJnskoHzawgKwhw== X-Received: by 10.99.174.5 with SMTP id q5mr14624979pgf.128.1478695007564; Wed, 09 Nov 2016 04:36:47 -0800 (PST) Received: from dvetter-linux.ger.corp.intel.com ([2a02:168:56b5:0:121d:c427:25b6:1d5c]) by smtp.gmail.com with ESMTPSA id l7sm55639780pfg.35.2016.11.09.04.36.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Nov 2016 04:36:47 -0800 (PST) From: Daniel Vetter To: DRI Development Subject: [PATCH] drm_fourcc: Document linear modifier Date: Wed, 9 Nov 2016 13:36:36 +0100 Message-Id: <1478694996-4200-1-git-send-email-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.7.4 Cc: Daniel Vetter , hoegsberg@google.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Not setting the fb modifiers flag is something different from setting the fb modifiers to 0 (which means explicitly linear). We kinda failed to document that properly. Spotted by Kristian. Cc: hoegsberg@google.com Signed-off-by: Daniel Vetter Reviewed-by: Kristian H. Kristensen --- include/uapi/drm/drm_fourcc.h | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h index da49f69e4d7e..2fca7e1f6aab 100644 --- a/include/uapi/drm/drm_fourcc.h +++ b/include/uapi/drm/drm_fourcc.h @@ -172,6 +172,16 @@ extern "C" { * authoritative source for all of these. */ +/* + * Linear Layout + * + * Just plain linear layout. Note that this is different from no specifying any + * modifier (e.g. not setting DRM_MODE_FB_MODIFIERS in the DRM_ADDFB2 ioctl), + * which tells the driver to also take driver-internal information into account + * and so might actually result in a tiled framebuffer. + */ +#define DRM_FORMAT_MOD_LINEAR fourcc_mod_code(NONE, 0) + /* Intel framebuffer modifiers */ /*