| Message ID | 1480687631-22196-1-git-send-email-tomi.valkeinen@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Tomi, Thank you for the patch. On Friday 02 Dec 2016 16:07:10 Tomi Valkeinen wrote: > drm_universal_plane_init() and drm_plane_init() take "unsigned long > possible_crtcs" parameter, but then stuff it into uint32_t. Change the > parameter to uint32_t. > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/gpu/drm/drm_plane.c | 4 ++-- > include/drm/drm_plane.h | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c > index 419ac313c36f..3bf9276f5bcf 100644 > --- a/drivers/gpu/drm/drm_plane.c > +++ b/drivers/gpu/drm/drm_plane.c > @@ -79,7 +79,7 @@ static unsigned int drm_num_planes(struct drm_device *dev) > * Zero on success, error code on failure. > */ > int drm_universal_plane_init(struct drm_device *dev, struct drm_plane > *plane, - unsigned long possible_crtcs, > + uint32_t possible_crtcs, > const struct drm_plane_funcs *funcs, > const uint32_t *formats, unsigned int format_count, > enum drm_plane_type type, > @@ -196,7 +196,7 @@ void drm_plane_unregister_all(struct drm_device *dev) > * Zero on success, error code on failure. > */ > int drm_plane_init(struct drm_device *dev, struct drm_plane *plane, > - unsigned long possible_crtcs, > + uint32_t possible_crtcs, > const struct drm_plane_funcs *funcs, > const uint32_t *formats, unsigned int format_count, > bool is_primary) > diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h > index 5b38eb94783b..db3bbdeb36d5 100644 > --- a/include/drm/drm_plane.h > +++ b/include/drm/drm_plane.h > @@ -513,7 +513,7 @@ struct drm_plane { > extern __printf(8, 9) > int drm_universal_plane_init(struct drm_device *dev, > struct drm_plane *plane, > - unsigned long possible_crtcs, > + uint32_t possible_crtcs, > const struct drm_plane_funcs *funcs, > const uint32_t *formats, > unsigned int format_count, > @@ -521,7 +521,7 @@ int drm_universal_plane_init(struct drm_device *dev, > const char *name, ...); > extern int drm_plane_init(struct drm_device *dev, > struct drm_plane *plane, > - unsigned long possible_crtcs, > + uint32_t possible_crtcs, > const struct drm_plane_funcs *funcs, > const uint32_t *formats, unsigned int format_count, > bool is_primary);
On Fri, Dec 02, 2016 at 04:07:10PM +0200, Tomi Valkeinen wrote: > drm_universal_plane_init() and drm_plane_init() take "unsigned long > possible_crtcs" parameter, but then stuff it into uint32_t. Change the > parameter to uint32_t. > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > --- > drivers/gpu/drm/drm_plane.c | 4 ++-- > include/drm/drm_plane.h | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c > index 419ac313c36f..3bf9276f5bcf 100644 > --- a/drivers/gpu/drm/drm_plane.c > +++ b/drivers/gpu/drm/drm_plane.c > @@ -79,7 +79,7 @@ static unsigned int drm_num_planes(struct drm_device *dev) > * Zero on success, error code on failure. > */ > int drm_universal_plane_init(struct drm_device *dev, struct drm_plane *plane, > - unsigned long possible_crtcs, > + uint32_t possible_crtcs, > const struct drm_plane_funcs *funcs, > const uint32_t *formats, unsigned int format_count, > enum drm_plane_type type, > @@ -196,7 +196,7 @@ void drm_plane_unregister_all(struct drm_device *dev) > * Zero on success, error code on failure. > */ > int drm_plane_init(struct drm_device *dev, struct drm_plane *plane, > - unsigned long possible_crtcs, > + uint32_t possible_crtcs, > const struct drm_plane_funcs *funcs, > const uint32_t *formats, unsigned int format_count, > bool is_primary) > diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h > index 5b38eb94783b..db3bbdeb36d5 100644 > --- a/include/drm/drm_plane.h > +++ b/include/drm/drm_plane.h > @@ -513,7 +513,7 @@ struct drm_plane { > extern __printf(8, 9) > int drm_universal_plane_init(struct drm_device *dev, > struct drm_plane *plane, > - unsigned long possible_crtcs, > + uint32_t possible_crtcs, > const struct drm_plane_funcs *funcs, > const uint32_t *formats, > unsigned int format_count, > @@ -521,7 +521,7 @@ int drm_universal_plane_init(struct drm_device *dev, > const char *name, ...); > extern int drm_plane_init(struct drm_device *dev, > struct drm_plane *plane, > - unsigned long possible_crtcs, > + uint32_t possible_crtcs, > const struct drm_plane_funcs *funcs, > const uint32_t *formats, unsigned int format_count, > bool is_primary); > -- > 2.7.4
diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c index 419ac313c36f..3bf9276f5bcf 100644 --- a/drivers/gpu/drm/drm_plane.c +++ b/drivers/gpu/drm/drm_plane.c @@ -79,7 +79,7 @@ static unsigned int drm_num_planes(struct drm_device *dev) * Zero on success, error code on failure. */ int drm_universal_plane_init(struct drm_device *dev, struct drm_plane *plane, - unsigned long possible_crtcs, + uint32_t possible_crtcs, const struct drm_plane_funcs *funcs, const uint32_t *formats, unsigned int format_count, enum drm_plane_type type, @@ -196,7 +196,7 @@ void drm_plane_unregister_all(struct drm_device *dev) * Zero on success, error code on failure. */ int drm_plane_init(struct drm_device *dev, struct drm_plane *plane, - unsigned long possible_crtcs, + uint32_t possible_crtcs, const struct drm_plane_funcs *funcs, const uint32_t *formats, unsigned int format_count, bool is_primary) diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h index 5b38eb94783b..db3bbdeb36d5 100644 --- a/include/drm/drm_plane.h +++ b/include/drm/drm_plane.h @@ -513,7 +513,7 @@ struct drm_plane { extern __printf(8, 9) int drm_universal_plane_init(struct drm_device *dev, struct drm_plane *plane, - unsigned long possible_crtcs, + uint32_t possible_crtcs, const struct drm_plane_funcs *funcs, const uint32_t *formats, unsigned int format_count, @@ -521,7 +521,7 @@ int drm_universal_plane_init(struct drm_device *dev, const char *name, ...); extern int drm_plane_init(struct drm_device *dev, struct drm_plane *plane, - unsigned long possible_crtcs, + uint32_t possible_crtcs, const struct drm_plane_funcs *funcs, const uint32_t *formats, unsigned int format_count, bool is_primary);
drm_universal_plane_init() and drm_plane_init() take "unsigned long possible_crtcs" parameter, but then stuff it into uint32_t. Change the parameter to uint32_t. Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> --- drivers/gpu/drm/drm_plane.c | 4 ++-- include/drm/drm_plane.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)