| Message ID | 1482923186-22430-1-git-send-email-jani.nikula@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Dec 28, 2016 at 01:06:26PM +0200, Jani Nikula wrote: > No reason not to be const. > > Signed-off-by: Jani Nikula <jani.nikula@intel.com> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> > --- > drivers/gpu/drm/drm_edid.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index 67d6a73731d8..4ff04aa84dd0 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -91,7 +91,7 @@ struct detailed_mode_closure { > #define LEVEL_GTF2 2 > #define LEVEL_CVT 3 > > -static struct edid_quirk { > +static const struct edid_quirk { > char vendor[4]; > int product_id; > u32 quirks; > @@ -1478,7 +1478,7 @@ EXPORT_SYMBOL(drm_edid_duplicate); > * > * Returns true if @vendor is in @edid, false otherwise > */ > -static bool edid_vendor(struct edid *edid, char *vendor) > +static bool edid_vendor(struct edid *edid, const char *vendor) > { > char edid_vendor[3]; > > @@ -1498,7 +1498,7 @@ static bool edid_vendor(struct edid *edid, char *vendor) > */ > static u32 edid_get_quirks(struct edid *edid) > { > - struct edid_quirk *quirk; > + const struct edid_quirk *quirk; > int i; > > for (i = 0; i < ARRAY_SIZE(edid_quirk_list); i++) { > -- > 2.1.4 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Wed, 28 Dec 2016, Daniel Vetter <daniel@ffwll.ch> wrote: > On Wed, Dec 28, 2016 at 01:06:26PM +0200, Jani Nikula wrote: >> No reason not to be const. >> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com> > > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Pushed, thanks for the review. BR, Jani. > >> --- >> drivers/gpu/drm/drm_edid.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c >> index 67d6a73731d8..4ff04aa84dd0 100644 >> --- a/drivers/gpu/drm/drm_edid.c >> +++ b/drivers/gpu/drm/drm_edid.c >> @@ -91,7 +91,7 @@ struct detailed_mode_closure { >> #define LEVEL_GTF2 2 >> #define LEVEL_CVT 3 >> >> -static struct edid_quirk { >> +static const struct edid_quirk { >> char vendor[4]; >> int product_id; >> u32 quirks; >> @@ -1478,7 +1478,7 @@ EXPORT_SYMBOL(drm_edid_duplicate); >> * >> * Returns true if @vendor is in @edid, false otherwise >> */ >> -static bool edid_vendor(struct edid *edid, char *vendor) >> +static bool edid_vendor(struct edid *edid, const char *vendor) >> { >> char edid_vendor[3]; >> >> @@ -1498,7 +1498,7 @@ static bool edid_vendor(struct edid *edid, char *vendor) >> */ >> static u32 edid_get_quirks(struct edid *edid) >> { >> - struct edid_quirk *quirk; >> + const struct edid_quirk *quirk; >> int i; >> >> for (i = 0; i < ARRAY_SIZE(edid_quirk_list); i++) { >> -- >> 2.1.4 >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 67d6a73731d8..4ff04aa84dd0 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -91,7 +91,7 @@ struct detailed_mode_closure { #define LEVEL_GTF2 2 #define LEVEL_CVT 3 -static struct edid_quirk { +static const struct edid_quirk { char vendor[4]; int product_id; u32 quirks; @@ -1478,7 +1478,7 @@ EXPORT_SYMBOL(drm_edid_duplicate); * * Returns true if @vendor is in @edid, false otherwise */ -static bool edid_vendor(struct edid *edid, char *vendor) +static bool edid_vendor(struct edid *edid, const char *vendor) { char edid_vendor[3]; @@ -1498,7 +1498,7 @@ static bool edid_vendor(struct edid *edid, char *vendor) */ static u32 edid_get_quirks(struct edid *edid) { - struct edid_quirk *quirk; + const struct edid_quirk *quirk; int i; for (i = 0; i < ARRAY_SIZE(edid_quirk_list); i++) {
No reason not to be const. Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/drm_edid.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)