| Message ID | 1484116439-7275-4-git-send-email-hoegeun.kwon@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 11.01.2017 07:33, Hoegeun Kwon wrote: > From: Hyungwon Hwang <human.hwang@samsung.com> > > This patch add the panel device tree node for S6E3HA2 display > controller to TM2 dts. > > Signed-off-by: Hyungwon Hwang <human.hwang@samsung.com> > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> > Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com> > Tested-by: Chanwoo Choi <cw00.choi@samsung.com> > --- > arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > index ddba2f8..6d362f9 100644 > --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > @@ -18,6 +18,18 @@ > compatible = "samsung,tm2", "samsung,exynos5433"; > }; > > +&dsi { > + panel@0 { > + compatible = "samsung,s6e3ha2"; > + reg = <0>; > + vdd3-supply = <&ldo27_reg>; > + vci-supply = <&ldo28_reg>; > + reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>; > + enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>; > + te-gpios = <&gpf1 3 GPIO_ACTIVE_HIGH>; The same here (as in 1st comment) , te-gpios should be dropper - decon uses hw-trigger. Regards Andrzej > + }; > +}; > + > &hsi2c_9 { > status = "okay"; >
2017년 01월 11일 16:46에 Andrzej Hajda 이(가) 쓴 글: > On 11.01.2017 07:33, Hoegeun Kwon wrote: >> From: Hyungwon Hwang <human.hwang@samsung.com> >> >> This patch add the panel device tree node for S6E3HA2 display >> controller to TM2 dts. >> >> Signed-off-by: Hyungwon Hwang <human.hwang@samsung.com> >> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> >> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> >> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com> >> Tested-by: Chanwoo Choi <cw00.choi@samsung.com> >> --- >> arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >> index ddba2f8..6d362f9 100644 >> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >> @@ -18,6 +18,18 @@ >> compatible = "samsung,tm2", "samsung,exynos5433"; >> }; >> >> +&dsi { >> + panel@0 { >> + compatible = "samsung,s6e3ha2"; >> + reg = <0>; >> + vdd3-supply = <&ldo27_reg>; >> + vci-supply = <&ldo28_reg>; >> + reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>; >> + enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>; >> + te-gpios = <&gpf1 3 GPIO_ACTIVE_HIGH>; > The same here (as in 1st comment) , te-gpios should be dropper - decon > uses hw-trigger. Reasonable to remove te-gpios property but this change would make MIPI-DSI driver probing to be failed so MIPI-DSI driver should be fixed together. Thanks. > > Regards > Andrzej >> + }; >> +}; >> + >> &hsi2c_9 { >> status = "okay"; >> > > > >
On 11.01.2017 09:40, Inki Dae wrote: > > 2017년 01월 11일 16:46에 Andrzej Hajda 이(가) 쓴 글: >> On 11.01.2017 07:33, Hoegeun Kwon wrote: >>> From: Hyungwon Hwang <human.hwang@samsung.com> >>> >>> This patch add the panel device tree node for S6E3HA2 display >>> controller to TM2 dts. >>> >>> Signed-off-by: Hyungwon Hwang <human.hwang@samsung.com> >>> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> >>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> >>> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com> >>> Tested-by: Chanwoo Choi <cw00.choi@samsung.com> >>> --- >>> arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 12 ++++++++++++ >>> 1 file changed, 12 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >>> index ddba2f8..6d362f9 100644 >>> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >>> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >>> @@ -18,6 +18,18 @@ >>> compatible = "samsung,tm2", "samsung,exynos5433"; >>> }; >>> >>> +&dsi { >>> + panel@0 { >>> + compatible = "samsung,s6e3ha2"; >>> + reg = <0>; >>> + vdd3-supply = <&ldo27_reg>; >>> + vci-supply = <&ldo28_reg>; >>> + reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>; >>> + enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>; >>> + te-gpios = <&gpf1 3 GPIO_ACTIVE_HIGH>; >> The same here (as in 1st comment) , te-gpios should be dropper - decon >> uses hw-trigger. > Reasonable to remove te-gpios property but this change would make MIPI-DSI driver probing to be failed so MIPI-DSI driver should be fixed together. > > Thanks. OK, I forgot it was not yet ported to mainline. Regards Andrzej > >> Regards >> Andrzej >>> + }; >>> +}; >>> + >>> &hsi2c_9 { >>> status = "okay"; >>> >> >> >> >
On 01/11/2017 04:46 PM, Andrzej Hajda wrote: > On 11.01.2017 07:33, Hoegeun Kwon wrote: >> From: Hyungwon Hwang <human.hwang@samsung.com> >> >> This patch add the panel device tree node for S6E3HA2 display >> controller to TM2 dts. >> >> Signed-off-by: Hyungwon Hwang <human.hwang@samsung.com> >> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> >> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> >> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com> >> Tested-by: Chanwoo Choi <cw00.choi@samsung.com> >> --- >> arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >> index ddba2f8..6d362f9 100644 >> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >> @@ -18,6 +18,18 @@ >> compatible = "samsung,tm2", "samsung,exynos5433"; >> }; >> >> +&dsi { >> + panel@0 { >> + compatible = "samsung,s6e3ha2"; >> + reg = <0>; >> + vdd3-supply = <&ldo27_reg>; >> + vci-supply = <&ldo28_reg>; >> + reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>; >> + enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>; >> + te-gpios = <&gpf1 3 GPIO_ACTIVE_HIGH>; > The same here (as in 1st comment) , te-gpios should be dropper - decon > uses hw-trigger. Hi Andrzej, Thanks for your quick review. Reasonable to remove te-gpios property, The Tizen public already has [1] your patch applied and te-gpios removed. So I will add [1] to the V9 patch. [1] https://review.tizen.org/gerrit/gitweb?p=platform/kernel/linux-exynos.git;a=commitdiff;h=468769bf6abbaaed2547b8c43e989ab5dc787900 Best Regards, Hoegeun > > Regards > Andrzej >> + }; >> +}; >> + >> &hsi2c_9 { >> status = "okay"; >> > > >
On 01/11/2017 06:39 PM, Andrzej Hajda wrote: > On 11.01.2017 09:40, Inki Dae wrote: >> 2017년 01월 11일 16:46에 Andrzej Hajda 이(가) 쓴 글: >>> On 11.01.2017 07:33, Hoegeun Kwon wrote: >>>> From: Hyungwon Hwang <human.hwang@samsung.com> >>>> >>>> This patch add the panel device tree node for S6E3HA2 display >>>> controller to TM2 dts. >>>> >>>> Signed-off-by: Hyungwon Hwang <human.hwang@samsung.com> >>>> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> >>>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> >>>> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com> >>>> Tested-by: Chanwoo Choi <cw00.choi@samsung.com> >>>> --- >>>> arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 12 ++++++++++++ >>>> 1 file changed, 12 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >>>> index ddba2f8..6d362f9 100644 >>>> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >>>> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >>>> @@ -18,6 +18,18 @@ >>>> compatible = "samsung,tm2", "samsung,exynos5433"; >>>> }; >>>> >>>> +&dsi { >>>> + panel@0 { >>>> + compatible = "samsung,s6e3ha2"; >>>> + reg = <0>; >>>> + vdd3-supply = <&ldo27_reg>; >>>> + vci-supply = <&ldo28_reg>; >>>> + reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>; >>>> + enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>; >>>> + te-gpios = <&gpf1 3 GPIO_ACTIVE_HIGH>; >>> The same here (as in 1st comment) , te-gpios should be dropper - decon >>> uses hw-trigger. >> Reasonable to remove te-gpios property but this change would make MIPI-DSI driver probing to be failed so MIPI-DSI driver should be fixed together. >> >> Thanks. > OK, I forgot it was not yet ported to mainline. > > Regards > Andrzej I received a reply while I was writing the mail. so, how about removing te-gpios later? Best Regards, Hoegeun > >>> Regards >>> Andrzej >>>> + }; >>>> +}; >>>> + >>>> &hsi2c_9 { >>>> status = "okay"; >>>> >>> >>> > >
On 01/11/2017 06:51 PM, hoegeun kwon wrote: > > > On 01/11/2017 04:46 PM, Andrzej Hajda wrote: >> On 11.01.2017 07:33, Hoegeun Kwon wrote: >>> From: Hyungwon Hwang <human.hwang@samsung.com> >>> >>> This patch add the panel device tree node for S6E3HA2 display >>> controller to TM2 dts. >>> >>> Signed-off-by: Hyungwon Hwang <human.hwang@samsung.com> >>> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> >>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> >>> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com> >>> Tested-by: Chanwoo Choi <cw00.choi@samsung.com> >>> --- >>> arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 12 ++++++++++++ >>> 1 file changed, 12 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >>> b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >>> index ddba2f8..6d362f9 100644 >>> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >>> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >>> @@ -18,6 +18,18 @@ >>> compatible = "samsung,tm2", "samsung,exynos5433"; >>> }; >>> +&dsi { >>> + panel@0 { >>> + compatible = "samsung,s6e3ha2"; >>> + reg = <0>; >>> + vdd3-supply = <&ldo27_reg>; >>> + vci-supply = <&ldo28_reg>; >>> + reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>; >>> + enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>; >>> + te-gpios = <&gpf1 3 GPIO_ACTIVE_HIGH>; >> The same here (as in 1st comment) , te-gpios should be dropper - decon >> uses hw-trigger. > > Hi Andrzej, > > Thanks for your quick review. > > Reasonable to remove te-gpios property, > The Tizen public already has [1] your patch applied and te-gpios removed. > So I will add [1] to the V9 patch. > > [1] > https://review.tizen.org/gerrit/gitweb?p=platform/kernel/linux-exynos.git;a=commitdiff;h=468769bf6abbaaed2547b8c43e989ab5dc787900 I'm sorry URL address is wrong. Correct address below: [1] https://git.tizen.org/cgit/platform/kernel/linux-exynos/commit/?h=tizen&id=468769bf6abbaaed2547b8c43e989ab5dc787900 Regards, Hoegeun > > Best Regards, > Hoegeun > >> >> Regards >> Andrzej >>> + }; >>> +}; >>> + >>> &hsi2c_9 { >>> status = "okay"; >> >> >> > > >
On 11.01.2017 11:23, hoegeun kwon wrote: > > On 01/11/2017 06:39 PM, Andrzej Hajda wrote: >> On 11.01.2017 09:40, Inki Dae wrote: >>> 2017년 01월 11일 16:46에 Andrzej Hajda 이(가) 쓴 글: >>>> On 11.01.2017 07:33, Hoegeun Kwon wrote: >>>>> From: Hyungwon Hwang <human.hwang@samsung.com> >>>>> >>>>> This patch add the panel device tree node for S6E3HA2 display >>>>> controller to TM2 dts. >>>>> >>>>> Signed-off-by: Hyungwon Hwang <human.hwang@samsung.com> >>>>> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> >>>>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> >>>>> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com> >>>>> Tested-by: Chanwoo Choi <cw00.choi@samsung.com> >>>>> --- >>>>> arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 12 ++++++++++++ >>>>> 1 file changed, 12 insertions(+) >>>>> >>>>> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >>>>> index ddba2f8..6d362f9 100644 >>>>> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >>>>> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >>>>> @@ -18,6 +18,18 @@ >>>>> compatible = "samsung,tm2", "samsung,exynos5433"; >>>>> }; >>>>> >>>>> +&dsi { >>>>> + panel@0 { >>>>> + compatible = "samsung,s6e3ha2"; >>>>> + reg = <0>; >>>>> + vdd3-supply = <&ldo27_reg>; >>>>> + vci-supply = <&ldo28_reg>; >>>>> + reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>; >>>>> + enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>; >>>>> + te-gpios = <&gpf1 3 GPIO_ACTIVE_HIGH>; >>>> The same here (as in 1st comment) , te-gpios should be dropper - decon >>>> uses hw-trigger. >>> Reasonable to remove te-gpios property but this change would make MIPI-DSI driver probing to be failed so MIPI-DSI driver should be fixed together. >>> >>> Thanks. >> OK, I forgot it was not yet ported to mainline. >> >> Regards >> Andrzej > I received a reply while I was writing the mail. > so, how about removing te-gpios later? I think this is a good solution, just do not forget to change it to optional in bindings, to make it removable. Regards Andrzej
diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts index ddba2f8..6d362f9 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts @@ -18,6 +18,18 @@ compatible = "samsung,tm2", "samsung,exynos5433"; }; +&dsi { + panel@0 { + compatible = "samsung,s6e3ha2"; + reg = <0>; + vdd3-supply = <&ldo27_reg>; + vci-supply = <&ldo28_reg>; + reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>; + enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>; + te-gpios = <&gpf1 3 GPIO_ACTIVE_HIGH>; + }; +}; + &hsi2c_9 { status = "okay";