From patchwork Fri Jan 13 08:10:26 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrzej Hajda X-Patchwork-Id: 9514801 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 622CB6077E for ; Fri, 13 Jan 2017 08:10:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5964B285FF for ; Fri, 13 Jan 2017 08:10:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4E05E2866E; Fri, 13 Jan 2017 08:10:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2D32B2863D for ; Fri, 13 Jan 2017 08:10:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5795B6ED52; Fri, 13 Jan 2017 08:10:42 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout4.w1.samsung.com (mailout4.w1.samsung.com [210.118.77.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7C7786ED52 for ; Fri, 13 Jan 2017 08:10:41 +0000 (UTC) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OJP00H1BLDQFS40@mailout4.w1.samsung.com> for dri-devel@lists.freedesktop.org; Fri, 13 Jan 2017 08:10:38 +0000 (GMT) Received: from eusmges2.samsung.com (unknown [203.254.199.241]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20170113081037eucas1p255878267aba2282ada51fd8d3a1fea59~ZRnkNjHZX2192121921eucas1p2q; Fri, 13 Jan 2017 08:10:37 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2.samsung.com (EUCPMTA) with SMTP id EF.65.30614.D7B88785; Fri, 13 Jan 2017 08:10:37 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20170113081037eucas1p2a87c058901f1bf9544a36b798b8349ff~ZRnjlUiEG0485104851eucas1p2P; Fri, 13 Jan 2017 08:10:37 +0000 (GMT) X-AuditID: cbfec7f1-f793f6d000007796-b1-58788b7d4134 Received: from eusync2.samsung.com ( [203.254.199.212]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id C0.B3.10233.67B88785; Fri, 13 Jan 2017 08:10:30 +0000 (GMT) Received: from AMDC2768.DIGITAL.local ([106.120.43.17]) by eusync2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OJP00B64LDONA40@eusync2.samsung.com>; Fri, 13 Jan 2017 08:10:36 +0000 (GMT) From: Andrzej Hajda To: Inki Dae , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org Subject: [PATCH] drm/exynos/decon5433: set STANDALONE_UPDATE_F also if planes are disabled Date: Fri, 13 Jan 2017 09:10:26 +0100 Message-id: <1484295026-16435-1-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 2.7.4 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrPIsWRmVeSWpSXmKPExsWy7djP87q13RURBvMOa1rcWneO1WLjjPWs Fle+vmezmHR/AovFjPP7mCzWHrnL7sDmcb/7OJNH35ZVjB6fN8kFMEdx2aSk5mSWpRbp2yVw ZUyZP5ml4CBfxdUpb9kbGFfzdDFyckgImEg8eLaDGcIWk7hwbz1bFyMXh5DAUkaJj48uMkM4 nxkl5hw9zAbT8ezOc1aIxDJGiflr5kK1/GeUWPnvITtIFZuApsTfzTfBOkQEMiUOPJnOCFLE LNDDKDH3egPQXA4OYYEYiVcfakBqWARUJR7f7Qer5xVwlnj8dRsrxDY5iZvnOsHOkBA4wCbR vH0iE0ivhICsxKYDUHe7SPxcvo0FwhaWeHV8CzuELSNxeXI3C0RvN6PEp/4T7BDOFEaJfx9m QHVbSxw+fhFsG7MAn8SkbdOZIRbwSnS0CUGUeEhsef8e6n1HiflTOphAbCGBWImji1awT2CU XsDIsIpRJLW0ODc9tdhIrzgxt7g0L10vOT93EyMwGk//O/5xB+P7E1aHGAU4GJV4eCfcLo8Q Yk0sK67MPcQowcGsJMK7tqkiQog3JbGyKrUoP76oNCe1+BCjNAeLkjjvngVXwoUE0hNLUrNT UwtSi2CyTBycUg2Mk+x78ncJeN+X0PLJdvgytzK57rXe9C0RtQdr63efTN3IpPMjI5XNvUGq +4WQ93WV6qnreRpn+R68tK/S57Xey4gp863fbz71/FiSk0DRG5k//3gda1Y68UeyJcqw8aVu b5I9oPWyJjthD89/Hvenkw45lh3M2mR78Zetrm7C5fuxZ7+k1wUosRRnJBpqMRcVJwIABE// VsICAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrMLMWRmVeSWpSXmKPExsVy+t/xK7pl3RURBn9viFrcWneO1WLjjPWs Fle+vmezmHR/AovFjPP7mCzWHrnL7sDmcb/7OJNH35ZVjB6fN8kFMEe52WSkJqakFimk5iXn p2TmpdsqhYa46VooKeQl5qbaKkXo+oYEKSmUJeaUAnlGBmjAwTnAPVhJ3y7BLWPK/MksBQf5 Kq5OecvewLiap4uRk0NCwETi2Z3nrBC2mMSFe+vZuhi5OIQEljBKnD/0kRnCaWSS2LdmJxtI FZuApsTfzTfBbBGBTImXzevBipgF+hglGv+uAksIC8RIfFpxjQnEZhFQlXh8tx8szivgLPH4 6zaodXISN891Mk9g5F7AyLCKUSS1tDg3PbfYSK84Mbe4NC9dLzk/dxMjMAC3Hfu5ZQdj17vg Q4wCHIxKPLwTbpdHCLEmlhVX5h5ilOBgVhLhXdtUESHEm5JYWZValB9fVJqTWnyI0RRo+URm KdHkfGB05JXEG5oYmlsaGhlbWJgbGSmJ8079cCVcSCA9sSQ1OzW1ILUIpo+Jg1OqgTHX5q2M 88bXXXmT3lVvMa49nsqjrB2pfUtvx/of8T/mlqz6/77paPvWe/dEZt5J1z1bMk/GcI6R8svt K+/e5hSXL+5V5o/zfcby48HenrAXN57cM1srktJ+4crWS9ZKE680t7l6KAld31vZanJwAzNv Si3nrFdeE3K4vp5I+bd358Mkw6/l7GuUWIozEg21mIuKEwGr3FGcVgIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170113081037eucas1p2a87c058901f1bf9544a36b798b8349ff X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRvsgrw=?= =?UTF-8?B?7ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRtTYW1z?= =?UTF-8?B?dW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170113081037eucas1p2a87c058901f1bf9544a36b798b8349ff X-RootMTR: 20170113081037eucas1p2a87c058901f1bf9544a36b798b8349ff References: Cc: Marek Szyprowski , Bartlomiej Zolnierkiewicz X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP STANDALONE_UPDATE_F should be set if something changed in plane configurations, including plane disable. The patch fixes page-faults bugs, caused by decon still using framebuffers of disabled planes. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c index ef7fcb5..3999e88 100644 --- a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c +++ b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c @@ -46,7 +46,8 @@ enum decon_flag_bits { BIT_CLKS_ENABLED, BIT_IRQS_ENABLED, BIT_WIN_UPDATED, - BIT_SUSPENDED + BIT_SUSPENDED, + BIT_REQUEST_UPDATE }; struct decon_context { @@ -313,6 +314,7 @@ static void decon_update_plane(struct exynos_drm_crtc *crtc, /* window enable */ decon_set_bits(ctx, DECON_WINCONx(win), WINCONx_ENWIN_F, ~0); + set_bit(BIT_REQUEST_UPDATE, &ctx->flags); } static void decon_disable_plane(struct exynos_drm_crtc *crtc, @@ -325,6 +327,7 @@ static void decon_disable_plane(struct exynos_drm_crtc *crtc, return; decon_set_bits(ctx, DECON_WINCONx(win), WINCONx_ENWIN_F, 0); + set_bit(BIT_REQUEST_UPDATE, &ctx->flags); } static void decon_atomic_flush(struct exynos_drm_crtc *crtc) @@ -339,8 +342,10 @@ static void decon_atomic_flush(struct exynos_drm_crtc *crtc) decon_shadow_protect_win(ctx, i, false); /* update iff there are active windows */ - if (crtc->base.state->plane_mask) + if (test_bit(BIT_REQUEST_UPDATE, &ctx->flags)) { decon_set_bits(ctx, DECON_UPDATE, STANDALONE_UPDATE_F, ~0); + set_bit(BIT_REQUEST_UPDATE, &ctx->flags); + } if (ctx->out_type & IFTYPE_I80) set_bit(BIT_WIN_UPDATED, &ctx->flags);