From patchwork Tue Jan 17 12:31:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Neil Armstrong X-Patchwork-Id: 9520667 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 700EC60244 for ; Tue, 17 Jan 2017 12:31:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4A9EA28500 for ; Tue, 17 Jan 2017 12:31:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3F45E2853B; Tue, 17 Jan 2017 12:31:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 0505A28500 for ; Tue, 17 Jan 2017 12:31:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AA09B6E676; Tue, 17 Jan 2017 12:31:53 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm0-x230.google.com (mail-wm0-x230.google.com [IPv6:2a00:1450:400c:c09::230]) by gabe.freedesktop.org (Postfix) with ESMTPS id 52BCA6E677 for ; Tue, 17 Jan 2017 12:31:51 +0000 (UTC) Received: by mail-wm0-x230.google.com with SMTP id f73so38648148wmf.1 for ; Tue, 17 Jan 2017 04:31:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=E7H3WCvMsN5xf7tDCAzk7fa/wFnHNEVlVxdpFt4VTT8=; b=L0yLmEjTIzok73qEfnWONQVbumPXAGpuNF4Kt96i9T3CejjMUyrQLI9t7mWLws44y0 q1XgekhpOAjGhj4Fjbc4Y/nphWbcOGMHrlpYzlIQu1gip+71SsQ6Q8p6ScogUf2lIdeN 4r382hgMYJwgx63cpTiaEhAV1TC7WI5Fz3sPx91PUVqpQhA9EaY8sYhv7WmnfKlUk+Nl eDf6c2V8Tk9xrRM5Fjl+aHXqh73zbnMPPDMqvQS5qxNRz6ndACg8tALVHKKWEm/mYISD hybCW0v3OmI/+140iZ8LcrKcfKaX0MSeyA4ZPY4n9TMZ19AUegZ+VoKwVr5IgOUnfKvO 51Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=E7H3WCvMsN5xf7tDCAzk7fa/wFnHNEVlVxdpFt4VTT8=; b=ln7am4pmWgHR4A6NlErHzTODPNRhvpS4iT/O9ryqKorr/U1iGOpnPnx5w34Uqiqk/i ON9cd2vR1A4A0r3QkATXQDQmVWQ2lnBOTCCBdPy1dmJX6HYsfYtkfcM8EErfzOz+3xS8 ZmSgEhBOMQImpX2XeMB9pnmatuY31AyaRzwE8x8hOUqUKuNLPpzWbXbtPH02VFwWbx9C IdWrCfy328nsgRuSyahkJTjamAkPCQHENkKX1GDASmvJ+kLlnKcp9tGz1/X7uKgdDu71 X03SdEZuq5pDRBYJgwjXtqxnqi/+gNfJxfAQlea9p6Ymsu94nFhSLZGBEbRTifWQCqD/ H2Iw== X-Gm-Message-State: AIkVDXL0n1LE1Q79Xog0ixyPsRupjc66FpEsu/Inkm7mWjy8btlHvy0JrHBSxo7943BMZj3U X-Received: by 10.223.169.115 with SMTP id u106mr26920605wrc.54.1484656309934; Tue, 17 Jan 2017 04:31:49 -0800 (PST) Received: from localhost.localdomain (home.amouriers.starnux.net. [82.228.250.61]) by smtp.gmail.com with ESMTPSA id l74sm36678858wmg.2.2017.01.17.04.31.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 17 Jan 2017 04:31:49 -0800 (PST) From: Neil Armstrong To: dri-devel@lists.freedesktop.org, laurent.pinchart+renesas@ideasonboard.com Subject: [RFC/RFT PATCH 3/4] drm/bridge: dw-hdmi: Enable CSC even for DVI Date: Tue, 17 Jan 2017 13:31:33 +0100 Message-Id: <1484656294-6140-4-git-send-email-narmstrong@baylibre.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1484656294-6140-1-git-send-email-narmstrong@baylibre.com> References: <1484656294-6140-1-git-send-email-narmstrong@baylibre.com> Cc: Jose.Abreu@synopsys.com, linux-amlogic@lists.infradead.org, kieran.bingham@ideasonboard.com, linux-kernel@vger.kernel.org, Neil Armstrong X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP If the input pixel format is not RGB, the CSC must be enabled in order to provide valid pixel to DVI sinks. This patch removes the hdmi only dependency on the CSC enabling. Signed-off-by: Neil Armstrong Reviewed-by: Laurent Pinchart Reviewed-by: Jose Abreu --- drivers/gpu/drm/bridge/dw-hdmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/dw-hdmi.c b/drivers/gpu/drm/bridge/dw-hdmi.c index 923e250..8a6a183 100644 --- a/drivers/gpu/drm/bridge/dw-hdmi.c +++ b/drivers/gpu/drm/bridge/dw-hdmi.c @@ -1331,8 +1331,8 @@ static void dw_hdmi_enable_video_path(struct dw_hdmi *hdmi) hdmi_writeb(hdmi, clkdis, HDMI_MC_CLKDIS); } - /* Enable color space conversion if needed (for HDMI sinks only). */ - if (hdmi->sink_is_hdmi && is_color_space_conversion(hdmi)) + /* Enable color space conversion if needed */ + if (is_color_space_conversion(hdmi)) hdmi_writeb(hdmi, HDMI_MC_FLOWCTRL_FEED_THROUGH_OFF_CSC_IN_PATH, HDMI_MC_FLOWCTRL); else