From patchwork Tue Jan 17 14:15:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrzej Hajda X-Patchwork-Id: 9521133 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3ABBF6020A for ; Tue, 17 Jan 2017 14:15:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2923F284E9 for ; Tue, 17 Jan 2017 14:15:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1D5B528569; Tue, 17 Jan 2017 14:15:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1F77E284E9 for ; Tue, 17 Jan 2017 14:15:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D80416E67E; Tue, 17 Jan 2017 14:15:38 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0D6626E40B for ; Tue, 17 Jan 2017 14:15:37 +0000 (UTC) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OJX004V0GXZZE90@mailout2.w1.samsung.com> for dri-devel@lists.freedesktop.org; Tue, 17 Jan 2017 14:15:35 +0000 (GMT) Received: from eusmges2.samsung.com (unknown [203.254.199.241]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20170117141534eucas1p206fc380f79ac9c8222dc207b8bc0f6e3~alLV6DldN1928919289eucas1p2X; Tue, 17 Jan 2017 14:15:34 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2.samsung.com (EUCPMTA) with SMTP id 43.1F.30614.6072E785; Tue, 17 Jan 2017 14:15:34 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20170117141533eucas1p2cb0936d0fd1c1f8d338184e78879ff29~alLVSNGZK2579925799eucas1p2C; Tue, 17 Jan 2017 14:15:33 +0000 (GMT) X-AuditID: cbfec7f1-f793f6d000007796-b9-587e2706dd51 Received: from eusync3.samsung.com ( [203.254.199.213]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id B6.63.06687.E372E785; Tue, 17 Jan 2017 14:16:30 +0000 (GMT) Received: from AMDC2768.DIGITAL.local ([106.120.43.17]) by eusync3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OJX00C6RGXWOSA0@eusync3.samsung.com>; Tue, 17 Jan 2017 14:15:33 +0000 (GMT) From: Andrzej Hajda To: Inki Dae , dri-devel@lists.freedesktop.org Subject: [PATCH 2/3] drm/exynos/decon5433: fix CMU programming Date: Tue, 17 Jan 2017 15:15:19 +0100 Message-id: <1484662520-17012-3-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 2.7.4 In-reply-to: <1484662520-17012-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrNIsWRmVeSWpSXmKPExsWy7djP87ps6nURBr0PWCxurTvHarFxxnpW iytf37NZTLo/gcXi8q45bBZrj9xld2DzuN99nMmjb8sqRo/Pm+QCmKO4bFJSczLLUov07RK4 MhZPrii4z1bRf6+JpYHxFmsXIweHhICJxM+emC5GTiBTTOLCvfVsXYxcHEICSxklvjUvYoJw PjNKNH48xwhRZSKx/u4WFojEMkaJVWdmMkI4/xklpk+YDlbFJqAp8XfzTTYQW0TAReL7jMXM IEXMAmsYJe4s38sKkhAWsJPY/+MTM4jNIqAqse3iI7A4r4CzxPTuS+wQ6+Qkbp7rBKvhBBq0 9scWsJskBK6zSTzc9Z0Z4glZiU0HmCHqXSR6t+5ig7CFJV4d3wI1R0ais+MgVG83o8Sn/hPs EM4URol/H2ZAdVtLHD5+EewKZgE+iUnbpkMt4JXoaBOCKPGQOPZuBROE7Shx+m87NJCmM0oc f3SSZQKjzAJGhlWMIqmlxbnpqcVGesWJucWleel6yfm5mxiBUXr63/GPOxjfn7A6xCjAwajE w7tCvC5CiDWxrLgy9xCjBAezkghviTJQiDclsbIqtSg/vqg0J7X4EKM0B4uSOO+eBVfChQTS E0tSs1NTC1KLYLJMHJxSDYwnb7z5JxN4+++8C0WnDrGu+rRsWql7kyDTud7PvfsKV2kt9po4 Q2VNYeTt8jq3zH8GBnLxun1zFzxaObUo8vU/ucJO5S05DzcF/077KPE6JUz2xkSF52lf+Jj4 vhZkTFxmte7rMsm99+eX54lElHtlT+FrrJ54/9zrTiW59XZ/Qg7XL7KczbtbiaU4I9FQi7mo OBEAS1BEgs4CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrJLMWRmVeSWpSXmKPExsVy+t/xq7p26nURBotmKljcWneO1WLjjPWs Fle+vmezmHR/AovF5V1z2CzWHrnL7sDmcb/7OJNH35ZVjB6fN8kFMEe52WSkJqakFimk5iXn p2TmpdsqhYa46VooKeQl5qbaKkXo+oYEKSmUJeaUAnlGBmjAwTnAPVhJ3y7BLWPx5IqC+2wV /feaWBoYb7F2MXJySAiYSKy/u4UFwhaTuHBvPRuILSSwhFFiZ0tFFyMXkN3IJNHe0MYEkmAT 0JT4u/kmWJGIgIvE9xmLmUGKmAXWMEp0TNoGNklYwE5i/49PzCA2i4CqxLaLj8C28Qo4S0zv vsQOsU1O4ua5TrAaTqBBa39sYYLY7Czxt3cRywRG3gWMDKsYRVJLi3PTc4sN9YoTc4tL89L1 kvNzNzECg3XbsZ+bdzBe2hh8iFGAg1GJhzdAtC5CiDWxrLgy9xCjBAezkghviTJQiDclsbIq tSg/vqg0J7X4EKMp0FETmaVEk/OBkZRXEm9oYmhuaWhkbGFhbmSkJM5b8uFKuJBAemJJanZq akFqEUwfEwenVANj2HVW22WJdc8eOJ1+MG33/0UJXXcqvT0113vXxb761rm47kblco8Ne5Pc HdwPtPDbtr3YqfSx5/OxauNFb9JXm7xK/jz3/03jGfycilclNBnUF+qyXWa5/FBZbt92Vy3m bz7M7jLzV3NWG32Yd+pYaFSt7u89AjH3fPsVn6itCpDj5yw8tdJGiaU4I9FQi7moOBEASB0w cmwCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170117141533eucas1p2cb0936d0fd1c1f8d338184e78879ff29 X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRvsgrw=?= =?UTF-8?B?7ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRtTYW1z?= =?UTF-8?B?dW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170117141533eucas1p2cb0936d0fd1c1f8d338184e78879ff29 X-RootMTR: 20170117141533eucas1p2cb0936d0fd1c1f8d338184e78879ff29 References: <1484662520-17012-1-git-send-email-a.hajda@samsung.com> Cc: Marek Szyprowski , linux-kernel@vger.kernel.org, Bartlomiej Zolnierkiewicz X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP DECON_CMU register has reserved bits which should not be zeroed, otherwise IP can behave strangely and cause IOMMU faults. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c index 6fd2b11..9f4d60d 100644 --- a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c +++ b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c @@ -158,10 +158,6 @@ static void decon_commit(struct exynos_drm_crtc *crtc) m->crtc_vsync_end = m->crtc_vsync_start + 1; } - /* enable clock gate */ - val = CMU_CLKGAGE_MODE_SFR_F | CMU_CLKGAGE_MODE_MEM_F; - writel(val, ctx->addr + DECON_CMU); - decon_setup_trigger(ctx); /* lcd on and use command if */