diff mbox

[v2,19.1/25] drm/bridge/mhl: add MHL3 infoframe related definitions

Message ID 1485438649-12396-1-git-send-email-a.hajda@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Andrzej Hajda Jan. 26, 2017, 1:50 p.m. UTC
MHL3 protocol uses vendor specific infoframes to transmit additional
information to the sink. This patch adds definitions of structures and
constants used to create such frames.

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
---
 include/drm/bridge/mhl.h | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

Comments

Archit Taneja Jan. 31, 2017, 11:03 a.m. UTC | #1
On 01/26/2017 07:20 PM, Andrzej Hajda wrote:
> MHL3 protocol uses vendor specific infoframes to transmit additional
> information to the sink. This patch adds definitions of structures and
> constants used to create such frames.
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> ---
>  include/drm/bridge/mhl.h | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
>
> diff --git a/include/drm/bridge/mhl.h b/include/drm/bridge/mhl.h
> index 71d922f..8dfa2cd 100644
> --- a/include/drm/bridge/mhl.h
> +++ b/include/drm/bridge/mhl.h
> @@ -339,4 +339,36 @@ struct mhl_burst_audio_descr {
>  	u8 short_desc[9];
>  } __packed;
>
> +/*
> + * MHL3 infoframe related definitions
> + */
> +
> +#define MHL3_IEEE_OUI		0x7ca61d
> +#define MHL3_INFOFRAME_SIZE	15
> +
> +enum mhl3_video_format {
> +	mhl3_video_format_none,
> +	mhl3_video_format_3d,
> +	mhl3_video_format_multi_view,
> +	mhl3_video_format_dual_3d
> +};
> +
> +enum mhl3_3d_format_type {
> +	mhl3_3d_format_type_fs, /* frame sequential */
> +	mhl3_3d_format_type_tb, /* top-bottom */
> +	mhl3_3d_format_type_lr, /* left-right */
> +	mhl3_3d_format_type_fs_tb, /* frame sequential, top-bottom */
> +	mhl3_3d_format_type_fs_lr, /* frame sequential, left-right */
> +	mhl3_3d_format_type_tb_lr /* top-bottom, left-right */
> +};
> +

Can we keep the enums in caps?

Thanks,
Archit

> +struct mhl3_infoframe {
> +	unsigned char version;
> +	enum mhl3_video_format video_format;
> +	enum mhl3_3d_format_type format_type;
> +	bool sep_audio;
> +	int hev_format;
> +	int av_delay;
> +};
> +
>  #endif /* __MHL_H__ */
>
Andrzej Hajda Jan. 31, 2017, 12:41 p.m. UTC | #2
On 31.01.2017 12:03, Archit Taneja wrote:
>
> On 01/26/2017 07:20 PM, Andrzej Hajda wrote:
>> MHL3 protocol uses vendor specific infoframes to transmit additional
>> information to the sink. This patch adds definitions of structures and
>> constants used to create such frames.
>>
>> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
>> ---
>>  include/drm/bridge/mhl.h | 32 ++++++++++++++++++++++++++++++++
>>  1 file changed, 32 insertions(+)
>>
>> diff --git a/include/drm/bridge/mhl.h b/include/drm/bridge/mhl.h
>> index 71d922f..8dfa2cd 100644
>> --- a/include/drm/bridge/mhl.h
>> +++ b/include/drm/bridge/mhl.h
>> @@ -339,4 +339,36 @@ struct mhl_burst_audio_descr {
>>  	u8 short_desc[9];
>>  } __packed;
>>
>> +/*
>> + * MHL3 infoframe related definitions
>> + */
>> +
>> +#define MHL3_IEEE_OUI		0x7ca61d
>> +#define MHL3_INFOFRAME_SIZE	15
>> +
>> +enum mhl3_video_format {
>> +	mhl3_video_format_none,
>> +	mhl3_video_format_3d,
>> +	mhl3_video_format_multi_view,
>> +	mhl3_video_format_dual_3d
>> +};
>> +
>> +enum mhl3_3d_format_type {
>> +	mhl3_3d_format_type_fs, /* frame sequential */
>> +	mhl3_3d_format_type_tb, /* top-bottom */
>> +	mhl3_3d_format_type_lr, /* left-right */
>> +	mhl3_3d_format_type_fs_tb, /* frame sequential, top-bottom */
>> +	mhl3_3d_format_type_fs_lr, /* frame sequential, left-right */
>> +	mhl3_3d_format_type_tb_lr /* top-bottom, left-right */
>> +};
>> +
> Can we keep the enums in caps?

Ups, will fix it now :)

Regards
Andrzej

>
> Thanks,
> Archit
>
>> +struct mhl3_infoframe {
>> +	unsigned char version;
>> +	enum mhl3_video_format video_format;
>> +	enum mhl3_3d_format_type format_type;
>> +	bool sep_audio;
>> +	int hev_format;
>> +	int av_delay;
>> +};
>> +
>>  #endif /* __MHL_H__ */
>>
diff mbox

Patch

diff --git a/include/drm/bridge/mhl.h b/include/drm/bridge/mhl.h
index 71d922f..8dfa2cd 100644
--- a/include/drm/bridge/mhl.h
+++ b/include/drm/bridge/mhl.h
@@ -339,4 +339,36 @@  struct mhl_burst_audio_descr {
 	u8 short_desc[9];
 } __packed;
 
+/*
+ * MHL3 infoframe related definitions
+ */
+
+#define MHL3_IEEE_OUI		0x7ca61d
+#define MHL3_INFOFRAME_SIZE	15
+
+enum mhl3_video_format {
+	mhl3_video_format_none,
+	mhl3_video_format_3d,
+	mhl3_video_format_multi_view,
+	mhl3_video_format_dual_3d
+};
+
+enum mhl3_3d_format_type {
+	mhl3_3d_format_type_fs, /* frame sequential */
+	mhl3_3d_format_type_tb, /* top-bottom */
+	mhl3_3d_format_type_lr, /* left-right */
+	mhl3_3d_format_type_fs_tb, /* frame sequential, top-bottom */
+	mhl3_3d_format_type_fs_lr, /* frame sequential, left-right */
+	mhl3_3d_format_type_tb_lr /* top-bottom, left-right */
+};
+
+struct mhl3_infoframe {
+	unsigned char version;
+	enum mhl3_video_format video_format;
+	enum mhl3_3d_format_type format_type;
+	bool sep_audio;
+	int hev_format;
+	int av_delay;
+};
+
 #endif /* __MHL_H__ */