From patchwork Wed Apr 5 07:28:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrzej Hajda X-Patchwork-Id: 9663147 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 14B0060353 for ; Wed, 5 Apr 2017 07:29:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 05932284D5 for ; Wed, 5 Apr 2017 07:29:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EE8E928535; Wed, 5 Apr 2017 07:29:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 90BD3284D5 for ; Wed, 5 Apr 2017 07:29:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0CC7A6E743; Wed, 5 Apr 2017 07:28:50 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id 03BA66E732 for ; Wed, 5 Apr 2017 07:28:47 +0000 (UTC) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0ONX00B9WE3W9J20@mailout1.w1.samsung.com> for dri-devel@lists.freedesktop.org; Wed, 05 Apr 2017 08:28:44 +0100 (BST) Received: from eusmges4.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20170405072844eucas1p2206f8c61425481d22a72de5189a3819b~yb8ZkPcUY2841928419eucas1p2b; Wed, 5 Apr 2017 07:28:44 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges4.samsung.com (EUCPMTA) with SMTP id CD.A9.04729.CAC94E85; Wed, 5 Apr 2017 08:28:44 +0100 (BST) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20170405072843eucas1p1303d7f8b3fbb9339ff258121b503e7ed~yb8Y5vpe43205632056eucas1p1B; Wed, 5 Apr 2017 07:28:43 +0000 (GMT) X-AuditID: cbfec7f4-f79806d000001279-08-58e49cac3c59 Received: from eusync3.samsung.com ( [203.254.199.213]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 1B.DF.20206.FBC94E85; Wed, 5 Apr 2017 08:29:03 +0100 (BST) Received: from AMDC2768.DIGITAL.local ([106.120.43.17]) by eusync3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0ONX000HIE3TW560@eusync3.samsung.com>; Wed, 05 Apr 2017 08:28:43 +0100 (BST) From: Andrzej Hajda To: Inki Dae Subject: [PATCH 5/9] drm/exynos/decon5433: kill BIT_IRQS_ENABLED flag Date: Wed, 05 Apr 2017 09:28:33 +0200 Message-id: <1491377317-8042-6-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 2.7.4 In-reply-to: <1491377317-8042-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrLIsWRmVeSWpSXmKPExsWy7djP87pr5jyJMNjzl9fi1rpzrBYbZ6xn tbjy9T2bxaT7E1gsZpzfx2Sx9shddgc2j/vdx5k8+rasYvT4vEkugDmKyyYlNSezLLVI3y6B K+P0qUbmgim8FfdW3mNvYPzP1cXIySEhYCLxa1cbI4QtJnHh3nq2LkYuDiGBpYwSr89+YIRw PjNKPF41gwmmY8fBhywQiWWMEkv7vjNBOP8ZJS7/eM0KUsUmoCnxd/NNNhBbREBZYtW+dnaQ ImaBS0BzT3aDLRQWcJW49WAPmM0ioCqxueUj2ApeASeJl4u+s0Csk5O4ea6TGcTmFHCWOLPj MtiBEgKP2SR2dN0BmsoB5MhKbDrADFHvInFt+1eoh4QlXh3fwg5hy0hcntzNAtHbzSjxqf8E O4QzhVHi34cZUN3WEoePXwR7gVmAT2LStunMEAt4JTrahCBKPCSurzsBtcBRYvOmZmggTWOU aL3ZxjaBUWYBI8MqRpHU0uLc9NRiE73ixNzi0rx0veT83E2MwEg9/e/4lx2Mi49ZHWIU4GBU 4uG9MONxhBBrYllxZe4hRgkOZiUR3h/Tn0QI8aYkVlalFuXHF5XmpBYfYpTmYFES5+U6dS1C SCA9sSQ1OzW1ILUIJsvEwSnVwChzYvHqWcvPvGm6EqSbO2tx8uy+OzOnysy8PMPow/JlO07f V+m6Ux2/VvV/d9JZV9dtpd8eTfz96bdNg+7qSiaN/ZdKUuMWlD+NXFDil/RGwaIl5BLHREOD O6Z2YhOTXJRObvohU3wnScBYX3vb4441i0K5a+c3P/NbsZ5/8q5I4WnWXZKL9TSUWIozEg21 mIuKEwFgDbVn0AIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrFLMWRmVeSWpSXmKPExsVy+t/xq7r75zyJMNh3W9Ti1rpzrBYbZ6xn tbjy9T2bxaT7E1gsZpzfx2Sx9shddgc2j/vdx5k8+rasYvT4vEkugDnKzSYjNTEltUghNS85 PyUzL91WKTTETddCSSEvMTfVVilC1zckSEmhLDGnFMgzMkADDs4B7sFK+nYJbhmnTzUyF0zh rbi38h57A+N/ri5GTg4JAROJHQcfskDYYhIX7q1n62Lk4hASWMIosf/KR2aQhJBAI5PE46te IDabgKbE38032UBsEQFliVX72tlBGpgFrjBKtH/rYgdJCAu4Stx6sIcRxGYRUJXY3PKRCcTm FXCSeLnoO9Q2OYmb5zrBFnAKOEuc2XGZDWKZk0Rr42uWCYy8CxgZVjGKpJYW56bnFhvpFSfm Fpfmpesl5+duYgSG67ZjP7fsYOx6F3yIUYCDUYmHt2La4wgh1sSy4srcQ4wSHMxKIrw/pj+J EOJNSaysSi3Kjy8qzUktPsRoCnTURGYp0eR8YCzllcQbmhiaWxoaGVtYmBsZKYnzTv1wJVxI ID2xJDU7NbUgtQimj4mDU6qB8WSseVi0j+6OjWuMzicaP3B4xLFKe4fWIotz34Sil91zlbn4 I/uKXWQp963Zawr/6q7YUS71YOEHtRu/Jiy4sVT98+xtnzTynqd5vznteu5gz/P7nRv8Pz6q uNXeWbM3+yPXpYVGW4wMXntIt657MykrSuD7VuWOd/L3NLL2XzAVj/nzz+ZiX5QSS3FGoqEW c1FxIgCUfIJZbQIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170405072843eucas1p1303d7f8b3fbb9339ff258121b503e7ed X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRvsgrw=?= =?UTF-8?B?7ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRtTYW1z?= =?UTF-8?B?dW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170405072843eucas1p1303d7f8b3fbb9339ff258121b503e7ed X-RootMTR: 20170405072843eucas1p1303d7f8b3fbb9339ff258121b503e7ed References: <1491377317-8042-1-git-send-email-a.hajda@samsung.com> Cc: linux-samsung-soc@vger.kernel.org, Marek Szyprowski , dri-devel@lists.freedesktop.org, Bartlomiej Zolnierkiewicz X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Since DECON uses enable_irq/disable_irq to full control IRQs, there is no point in having flags to trace it separately. As a bonus condition for software trigger becomes always true, so it can be removed. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c index 5bdf1a0..dc2e69a 100644 --- a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c +++ b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c @@ -49,7 +49,6 @@ static const char * const decon_clks_name[] = { enum decon_flag_bits { BIT_CLKS_ENABLED, - BIT_IRQS_ENABLED, BIT_WIN_UPDATED, BIT_SUSPENDED }; @@ -112,8 +111,6 @@ static int decon_enable_vblank(struct exynos_drm_crtc *crtc) if (!(ctx->out_type & I80_HW_TRG)) enable_irq(ctx->te_irq); - set_bit(BIT_IRQS_ENABLED, &ctx->flags); - return 0; } @@ -121,7 +118,6 @@ static void decon_disable_vblank(struct exynos_drm_crtc *crtc) { struct decon_context *ctx = crtc->ctx; - clear_bit(BIT_IRQS_ENABLED, &ctx->flags); if (test_bit(BIT_SUSPENDED, &ctx->flags)) return; @@ -536,9 +532,7 @@ static irqreturn_t decon_te_irq_handler(int irq, void *dev_id) (ctx->out_type & I80_HW_TRG)) return IRQ_HANDLED; - if (test_and_clear_bit(BIT_WIN_UPDATED, &ctx->flags) || - test_bit(BIT_IRQS_ENABLED, &ctx->flags)) - decon_set_bits(ctx, DECON_TRIGCON, TRIGCON_SWTRIGCMD, ~0); + decon_set_bits(ctx, DECON_TRIGCON, TRIGCON_SWTRIGCMD, ~0); return IRQ_HANDLED; }