| Message ID | 1491981729-6396-1-git-send-email-a.hajda@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 04/12/2017 04:22 PM, Andrzej Hajda wrote: > DSIM uses MIC bridge which is between DECON and DSIM, so the driver > should expect bridge node on input side. > > Fixes: 86418f9 ("drm: convert drivers to use of_graph_get_remote_node") > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> > --- > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c > index dcb50d4d..3ae459f 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c > @@ -1659,7 +1659,7 @@ static int exynos_dsi_parse_dt(struct exynos_dsi *dsi) > > of_node_put(ep); > > - dsi->bridge_node = of_graph_get_remote_node(node, DSI_PORT_OUT, 0); > + dsi->bridge_node = of_graph_get_remote_node(node, DSI_PORT_IN, 0); > if (!dsi->bridge_node) > return -EINVAL; Hi Andrzej, The of_graph_get_remote_node() does not exist in the kernel. Also this patch does not apply('git am') on drm-next tree. Is this what you mean? dsi->bridge_node = of_graph_get_endpoint_by_regs(node, DSI_PORT_IN, 0); if (!dsi->bridge_node) return -EINVAL; Best regards, Hoegeun >
Hi Hoegeun, On 2017-04-12 15:58, Hoegeun Kwon wrote: > On 04/12/2017 04:22 PM, Andrzej Hajda wrote: >> DSIM uses MIC bridge which is between DECON and DSIM, so the driver >> should expect bridge node on input side. >> >> Fixes: 86418f9 ("drm: convert drivers to use of_graph_get_remote_node") >> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> >> --- >> drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c >> b/drivers/gpu/drm/exynos/exynos_drm_dsi.c >> index dcb50d4d..3ae459f 100644 >> --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c >> +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c >> @@ -1659,7 +1659,7 @@ static int exynos_dsi_parse_dt(struct >> exynos_dsi *dsi) >> of_node_put(ep); >> - dsi->bridge_node = of_graph_get_remote_node(node, >> DSI_PORT_OUT, 0); >> + dsi->bridge_node = of_graph_get_remote_node(node, DSI_PORT_IN, 0); >> if (!dsi->bridge_node) >> return -EINVAL; > > Hi Andrzej, > > The of_graph_get_remote_node() does not exist in the kernel. > Also this patch does not apply('git am') on drm-next tree. > Is this what you mean? > dsi->bridge_node = of_graph_get_endpoint_by_regs(node, > DSI_PORT_IN, 0); > if (!dsi->bridge_node) > return -EINVAL; Please check latest drm-next branch at git://people.freedesktop.org/~airlied/linux.git Commit 86418f90a4c "drm: convert drivers to use of_graph_get_remote_node" got merged via drm-misc tree and Andrzej's patch is a fix for it. Best regards
On 04/12/2017 11:13 PM, Marek Szyprowski wrote: > Hi Hoegeun, > > On 2017-04-12 15:58, Hoegeun Kwon wrote: >> On 04/12/2017 04:22 PM, Andrzej Hajda wrote: >>> DSIM uses MIC bridge which is between DECON and DSIM, so the driver >>> should expect bridge node on input side. >>> >>> Fixes: 86418f9 ("drm: convert drivers to use of_graph_get_remote_node") >>> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> >>> --- >>> drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c >>> b/drivers/gpu/drm/exynos/exynos_drm_dsi.c >>> index dcb50d4d..3ae459f 100644 >>> --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c >>> +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c >>> @@ -1659,7 +1659,7 @@ static int exynos_dsi_parse_dt(struct >>> exynos_dsi *dsi) >>> of_node_put(ep); >>> - dsi->bridge_node = of_graph_get_remote_node(node, >>> DSI_PORT_OUT, 0); >>> + dsi->bridge_node = of_graph_get_remote_node(node, DSI_PORT_IN, 0); >>> if (!dsi->bridge_node) >>> return -EINVAL; >> >> Hi Andrzej, >> >> The of_graph_get_remote_node() does not exist in the kernel. >> Also this patch does not apply('git am') on drm-next tree. >> Is this what you mean? >> dsi->bridge_node = of_graph_get_endpoint_by_regs(node, >> DSI_PORT_IN, 0); >> if (!dsi->bridge_node) >> return -EINVAL; > > Please check latest drm-next branch at > git://people.freedesktop.org/~airlied/linux.git > > Commit 86418f90a4c "drm: convert drivers to use > of_graph_get_remote_node" got merged > via drm-misc tree and Andrzej's patch is a fix for it. Hi Marek, I have checked the exynos drm-next branch at http://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git Sorry, there was a mistake. Best regards, Hoegeun > > Best regards
2017년 04월 12일 16:22에 Andrzej Hajda 이(가) 쓴 글: > DSIM uses MIC bridge which is between DECON and DSIM, so the driver > should expect bridge node on input side. Confirmed and merged. Thanks, Inki Dae > > Fixes: 86418f9 ("drm: convert drivers to use of_graph_get_remote_node") > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> > --- > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c > index dcb50d4d..3ae459f 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c > @@ -1659,7 +1659,7 @@ static int exynos_dsi_parse_dt(struct exynos_dsi *dsi) > > of_node_put(ep); > > - dsi->bridge_node = of_graph_get_remote_node(node, DSI_PORT_OUT, 0); > + dsi->bridge_node = of_graph_get_remote_node(node, DSI_PORT_IN, 0); > if (!dsi->bridge_node) > return -EINVAL; > >
diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c index dcb50d4d..3ae459f 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c @@ -1659,7 +1659,7 @@ static int exynos_dsi_parse_dt(struct exynos_dsi *dsi) of_node_put(ep); - dsi->bridge_node = of_graph_get_remote_node(node, DSI_PORT_OUT, 0); + dsi->bridge_node = of_graph_get_remote_node(node, DSI_PORT_IN, 0); if (!dsi->bridge_node) return -EINVAL;
DSIM uses MIC bridge which is between DECON and DSIM, so the driver should expect bridge node on input side. Fixes: 86418f9 ("drm: convert drivers to use of_graph_get_remote_node") Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)