From patchwork Wed Jun 7 13:24:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Hellstrom X-Patchwork-Id: 9771535 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9551160350 for ; Wed, 7 Jun 2017 13:40:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 87CA2283BE for ; Wed, 7 Jun 2017 13:40:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7C6E2284A6; Wed, 7 Jun 2017 13:40:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 3B197283BE for ; Wed, 7 Jun 2017 13:40:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B37F36E248; Wed, 7 Jun 2017 13:40:52 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0042.outbound.protection.outlook.com [104.47.34.42]) by gabe.freedesktop.org (Postfix) with ESMTPS id C6FBC6E246 for ; Wed, 7 Jun 2017 13:40:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=onevmw.onmicrosoft.com; s=selector1-vmware-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ApN5TXh0q6XoFGi8ReSvdSgom9KaDJRc9w4CfH1tLmI=; b=gdFNjyztPBZL13Hz1Sp5tDTzDb2YsUT4jH+mrBM9/0c/oqHjQvViKJ8DyJM4RM3JKflyf9TbLgQphAYNAPXeUc3wovptDXbd9vgR5S/m/UTrMnidaUV2+v0JgKKIYJCUZSVXDLIF3VRQnDWFF02+ULbzU2IVAhazAFLocOtvXtg= Authentication-Results: lists.freedesktop.org; dkim=none (message not signed) header.d=none; lists.freedesktop.org; dmarc=none action=none header.from=vmware.com; Received: from ubuntu.localdomain (155.4.205.56) by BLUPR05MB753.namprd05.prod.outlook.com (10.141.208.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1157.3; Wed, 7 Jun 2017 13:24:57 +0000 From: Thomas Hellstrom To: dri-devel@lists.freedesktop.org Subject: [PATCH -fixes 2/9] drm/vmwgfx: Don't create proxy surface for cursor Date: Wed, 7 Jun 2017 15:24:18 +0200 Message-Id: <1496841865-2349-2-git-send-email-thellstrom@vmware.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1496841865-2349-1-git-send-email-thellstrom@vmware.com> References: <1496841865-2349-1-git-send-email-thellstrom@vmware.com> MIME-Version: 1.0 X-Originating-IP: [155.4.205.56] X-ClientProxiedBy: BN6PR16CA0019.namprd16.prod.outlook.com (10.172.212.157) To BLUPR05MB753.namprd05.prod.outlook.com (10.141.208.140) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BLUPR05MB753: X-MS-Office365-Filtering-Correlation-Id: 0edf5286-b6e0-4cad-eab4-08d4ada8978d X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075)(201703031133081); SRVR:BLUPR05MB753; X-Microsoft-Exchange-Diagnostics: 1; BLUPR05MB753; 3:Zs0DBHhDETe7Luak1FdWLsKrT1hUFyUMVIK4m96xTE/E3w8J3jim0/n75huwhNfTLJsx2NQYiKJPmKr2jdMbquYA5gMnrLwG210jNvG2Vw1TSvvZuvDBO1tkRYKcgymKu0/BIxSQQUlskyQOSfoKOt4ZkQGHUfzIwgEECpeka0SgXio0VZvyMW02agivJs9mvEhsxaUzJQu+8Pkd4/uAVd/VRbpDhqVGqml2yM3hc2rhRzx56Ik539l0OSPWNczlbKdfg62jK4KGm7VJeyZH3rLYFktNM/J23Spqfa225hd8YjzDZpiFENKRWYDViKxSZCT75vvCgkY7whbtN8M7iQ==; 25:FMdeWcBIbpOng+eTXdj7u3VnEXynqzm7QEQ6SE027GAtb8vgRzbdqJCyR3LumsikMEdIRFJ6lcrnwfY3UOtsyHtU3ODWogBuIj5VIQU8BpxIFI+qau7tYYpzlD2jwmSnjKvkAKqnBO1HZ8urpgfTSNxHqYvP9ONbwR33Y0YaX/i5O+H5lsY/DS8pqjXou0CPxj1bC2bciYyy3+2OMRymFK/+UUAxFjqpD82IujEcWEge7Hx5uDaiNPL2LiowcIko5VuOrlG0X9fAZVk66Ab5QtZ0YjuFlIRO080gdi2SdbU4wyij3Zc72/VaMnC/RpLRZkWYON1oKlARZN8KZjyKqj+P2GT9mZjdrNqD5UYU4zEM43OwRyCbpLQ5KDtVcp12j4XqObuKEr+qhyOVVqN/u/q/IfVxiDHBjDYTmhqPo2a3sXSoP6Y0a9oLwFJzz4+z42fXHr+s394NPkTf0lWIfwBH/7WNkN6KWEAEeKFD280= X-Microsoft-Exchange-Diagnostics: 1; BLUPR05MB753; 31:B8Lw9MALYje1vv8w17q4GhZwKhhGMCqlDemxBHyuM93AMfSWNyep1fOJbxLHwy+weMbAzO22CD+aZjHnPPDdodBclCo2KqNKZpLztAznacq+XMOyo1bqXlODdDK5WwIXQgM/r8X4nrryji/lffMZwCq2zrcJVD+BYJk/CrHk1nTuuYEMmVWxs/7soADLJvUBdwKXBtBwEIhLyKXF08xM78VreUjjfTwHQm1LE4Q9kYEz/4WT50YdBsRLdC1+8aDKm41NDBDuDWrXFL8tGZpw2w==; 20:xF24bXbsG9GsJ8cLI8cceghOOhQzGYAUu5AbDIX8emEjbziqWEOMGi43ma3ebEXxCeI03vS+QwXo84nby+WMSZKfcaqUCoGecLLbMUw2Xkyq6eNOJLRjMc5bD4kZ8jTKkkWs4FnHgZdh1SrNBtw9fvr7+kjybJTK+vWIUz/igGF4rMj3TJWlTjcYUctrzZuORVOAbPP4+Dsz+OklPjM/k8zWdbyCsgi4ta4YA3eQaXKuSVw6OKqU6xyNmUkjKPu4881lxc4FIoGjRDF7n23GY8fL+VIR2d+QIdXuROCSQDuFHsmqFz3ATsBvGsJu9DAjQ/jWPkLXOgpV8a5ewY4AySa3eiuyCMj3C+ECgs6cbG/inwBkrNd3nyH/GiQVBZYBE0oGCydObKnlB0ZrmRlnfhHxI4/T9ZYMELLr5MSL/6SMOekX3NrBX9hLXccZJf/sWO/NegKEXZQ8TNXuH+EC6Sj48mTjCxkvxGk3bLQ3UfHL9ghdhrLUzQxvjY7UgW0z X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(61668805478150); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(6041248)(20161123558100)(20161123562025)(20161123564025)(20161123555025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BLUPR05MB753; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BLUPR05MB753; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR05MB753; 4:dH8DauAUndcw1lLOoAbnxx7d4lPjh8/+4ablhcyJfwf?= =?us-ascii?Q?cxeSPnFlBmT0UfO3Ag2klSX4Mm93KkU53zYJrNJf/IS23oA6GaZ5MtsvSMzi?= =?us-ascii?Q?jPtbOIil8F0iuDzWnaembmwwydCNYwU9o5pQ9mxHECf+OPTpfy/Rwb1FvR48?= =?us-ascii?Q?h2L75l8w68Ia58QaxkenAaqHNkZlBN3Sl67GLaB7UoLMofvOPwv5x6fowahM?= =?us-ascii?Q?tfj3YyB5OccpG7kBw7FPe7qQPGVHxfqx0SME1z9aIqbGCxIxnQst2c7cAtx0?= =?us-ascii?Q?YoDFyAoanEHs0vkeFDDVyj4KVBf0V8PBIkF9qPq1WhqG2nohZBWt/qa29PKM?= =?us-ascii?Q?r6DM/Eyrh+nWWFzSZsQo9viSWSZyl4SCcgorXn6Yp4PB2ikvmIETZ/lH2f3x?= =?us-ascii?Q?8T6KQ2/rhORXn3qnAeqSX6Y7cdbbiruSynuR7eyC+mRyqq5bZWKfsRG+ssWf?= =?us-ascii?Q?Rp2OuZZ5xrwogrp3EuV1OffZsQx8WFh0KhYPx2BHCCfNEx2Okn3E9J8Gu3Iv?= =?us-ascii?Q?cAYFDHddKTz0R2dNZ0/v2CrUvGAUCvHk6ifxzLH7oN9Pog7a9A8PR6bJ/plj?= =?us-ascii?Q?jbJJJMYw72JOeYdwCQkh7IgoFHy3lbrNOOUTxjWMCk/7d0dbimUFmYa+Oebg?= =?us-ascii?Q?FL3iYQK82c24oCVICkMz6jcCI5X5fo9l62HRgfgFPbEC6e2BIq1mGsBAuhxf?= =?us-ascii?Q?1XobUXYt3X7DJCRS9xEAkj8HvLKKl1ZRVU2fB+cU2ekxTkcNKwMqSeW125xq?= =?us-ascii?Q?DQWVkZCtlV7FWNUuMTNFL4Jh2sZBjrCPmZ19IacQQl1bfUsPxf70hWfKYd+M?= =?us-ascii?Q?ipxCElSABnGQ4u+iQowu3Al3yvgoJzdzioVnRfxpVxVz97cK3eU65b+XIUni?= =?us-ascii?Q?WR2dCagZgun5+lkephxrOtZm4udpmpbA1uiiyZqtHhgj0Xg+QBlU0svQG0ul?= =?us-ascii?Q?tz5QqGxH82GI223h3+sFp+w3fQ9oj8JZTLOOPS0X7W0hU0hgaLY8A4BQ0cWz?= =?us-ascii?Q?/Ulbc8KE5UzP4alfGu1SWMJrWqUk8tTyIWb5199+Fi0OURMoElgwUu36ZURg?= =?us-ascii?Q?FlgIY+Ctmll7rA6o76WhoMNZlpn304vVBMzUlb7ilkEi+lmOqaZs5zy+tqGU?= =?us-ascii?Q?KrQ9EAYD8nY+pjRMyndu8BazRq2wRQesf0hrd8xuJ+Hobpz/Nn2UxmnMbh7c?= =?us-ascii?Q?GhDKWTdDSLuk=3D?= X-Forefront-PRVS: 03319F6FEF X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(39410400002)(39400400002)(39450400003)(39850400002)(76176999)(38730400002)(107886003)(110136004)(2906002)(305945005)(47776003)(86362001)(66066001)(5660300001)(3846002)(6666003)(50986999)(5003940100001)(81166006)(6916009)(6116002)(478600001)(7736002)(2950100002)(50226002)(6506006)(2361001)(33646002)(6486002)(6512007)(25786009)(42186005)(189998001)(2351001)(4326008)(50466002)(48376002)(53936002)(36756003); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR05MB753; H:ubuntu.localdomain; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR05MB753; 23:vavJX7OCdKJ3VcyZUn5XfoSTHIYNrUbwfH6opKabIQ?= =?us-ascii?Q?nF9+EKBiOWfbLxFSN4lnK9lbHtsyyNXDyf2WurPn/QgUvgSle1Molstkj2sZ?= =?us-ascii?Q?SjJi+rtPN5T8F1AvptNng4vcnZCJ2nRGRod47Ymsv1u7M189XcpBm/khaUPh?= =?us-ascii?Q?Cv1+8Ms6iidZQyhaUSE/NphXIBk6p8py8rYTzpiqOGcIVfN4og1kuXur6Toy?= =?us-ascii?Q?2sEKnA+XJylDlJkGon8rKgopT1fgEmqFqVfG3gAmST8kfxKgf/2kXTSNO8hG?= =?us-ascii?Q?f7omKR+T3/S5Ozwo/M0Jo93kXv2TUvGVBonDrD/DYGxGU5xP8tLSZglcIAD2?= =?us-ascii?Q?/f0uKtlnmXzdsw94t/fj6y6UfObCJ1GRkXfhzjHYn9IFePDfc00H3iiWhVQ0?= =?us-ascii?Q?1WmtvL756x7yEFE0mVITqu9Q9tOCExp4LpK7nj8n5eI10u0g4lUwMHO92mgC?= =?us-ascii?Q?EN73zfS2/cnY+EbsXiFO8+77R0yZp7QdWcKBbRupaEJq5mH3sKIndi5c/hKD?= =?us-ascii?Q?JARjyrc/1SrKCi9hqycx2JamOd+wNGpaqJN6KgRmkKHxnnrMC5iGUJe4siiL?= =?us-ascii?Q?3ldNRu2i+f+qyuc56FZPrZT65NNCb/kVaNLfKp2Ybv4wPXKtxKuIaHrR1n4C?= =?us-ascii?Q?QHDEDxobdp09xK9UV+jgV/VoKwL30MhVttHocRD/OJ+b3cMWC/fkgLil5fuU?= =?us-ascii?Q?9SBUnOalQMjmVQ6Gikyx9FCOCbAcen717EfLLducibVRq61UmEtRHEo76TYk?= =?us-ascii?Q?8jLQLsPODaxq9/Yst7sp9KpXCfyA+uhsPF40IixqJ+9BjORO2Xq/S2S8YfVe?= =?us-ascii?Q?rcyw/XnfU9LpQMrf8pU+rRMgBpw43/oy/YIsqZPz6f5JtbDUIaO43raWbQp8?= =?us-ascii?Q?lFM6uUh03wT05/kdiSCy685A+kdjdYcN6R8EO3d8ED0H3hNSWVRZBeMcPB4z?= =?us-ascii?Q?/04cNFt7zSZtfLpbpEQAEPPmgpNNREXUoFHE2AlS84QvW6LffWz2nc4wPOxH?= =?us-ascii?Q?m1qCst7MtpiDZBtKEQOqo+geZTYHe2/HGbUN8mfQLqLQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR05MB753; 6:YWp/aWM288EMryuNK4VyK4ATaFZ1s7kxHoLf69t9v2NTuA/pRVV/U01o0d635kHKAaqz5AKtozLYs4TZSHmOdimWlODWAtcmTOVnQATVDWjMkIWDt3QPWdQmLKsockyeKPD4iE3dS8YOCVPlwytvsS2FNVHZXbysahYOhpWeaCkTJsMn2elL+GUNl0G+VXmtCvbExqF3vgl3dBPNPb5lfFVBG0K3zDqdSxMFi1nx0Xbz8I84Ly5WmiFYU3Su97XMdd6Y7kv3VrECfgtjiMkupqQk8bsvz/pT9aE8Zl1IyVtz6IjhRtI2VnukBFpmx1BSk+BlJXiztgwsJwlJKTXzh7B6Nzv1p+8KL5H5fO4zVeJ4l68/m4Szp1MIGnqPxnLeyDmVo9NxhFVrLWO9Ib6VV5Nsx2Eh1qqQvuZ/t+xqha8J1tlMsmAOBxnax+HIh/HBpaLYgM6XUHz+feFrztDtzbI+VNIJPfKBXicIoGrS65WFlLupURyr4hdSJPurLc2MMBBiulxvTMgGJOK0wnCmoQ== X-Microsoft-Exchange-Diagnostics: 1; BLUPR05MB753; 5:yutigd+W/IacvUtWrfqNhCFl9I+0IDdDy+hpeDKN26wTYbaovtxH9aE9fdbznAiTSAOmpYr3Aq3Z55zTsn5dLytymFpWN4rsdP5fFbWIttmHsznS8DRRBwToR8TsZQDKsgogdYmBt6Ja7yhWXAaaldP7U8J4ixOI9mdSqNDd1jy00hFV8n2JQl7h7nCbKD2AQClObIXnXUh4RDGPXdpogP+KrVPH1XKRBTupswFEFzf+vBcqiuov706nQlb3FwIEVOSzq36+gikeA90gTnj1EvGglOLEoPO+dzyEWEWlolkGkQrBq/U3Gbprg9EoOd4zoVn/x40MR/Jbi27ASJZICdm+wyLJIE3o1K57/oAueSJzwlZLd1un/xI/OTeUYVlMYbcKg4UL9qZUim4Bdy0o/nfhMeTPl+EXCdtDmbYcIJ/u2ZU4pv3yJoP2wCHrpkPuR4GzOHOR2U2Dd6r+44OnF5Tatm/M7+cyzZzHljtXCvZcsPrBJskfwOPhS7gRUAQN; 24:E5FP3vDCSR647c9XGOTcRgBQYqF0H9hO1U9T2IbE5AQD2nylvur5+HPWIERhaeFeUQMxNyOIArPs7TE4BUckw+ffWa3AN2GLPr4xsollG/o= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR05MB753; 7:xWN9e2KlmzRi+ssvGdGyzFX24+UXUplwsYbDY7hB2SAzy16i5qf1p+Vc8BopDauLI4w+FFlZiGtM0PnK1KG7i6M+AUAI/EtznVgk9COQGBt0QIlEV3+7SVrDFlkWmBcGWViwuseWgC4huyCwYCGeq5LZBZpM1B7kyjyjRe6IYShSAFR3vAzbDkYaHC3WNnuVSqvsWFvyDFdpkVqgvNEG4k/il3xXnlVGZ6YhBfi9Z36F4OPn+vHiPJUswiJpOYjXHvR1LnBNfgfBHUHXKlotzETbNtW+R7XUh4WAlZeU3W+sHuPJr1/q3jjBncupakcnB+vtYjl+EKeiMVBgvo3Thw==; 20:WRE7CUxg7kdkr2ljbjUYv0GxKtcognwDHlaRPq005L+7Tn8u56O5x4HJ0yMgp5rXm2SPDnt9j3UTZFFYi/Vr4zlqMyHOX56/xdueEu6k4TIDlQ7VWATp7Odxmu4krRsSKxFlFgTGU4d4GutUB7Db/ymX2x/iFE++UgtThiYnF18= X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2017 13:24:57.0166 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR05MB753 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Sinclair Yeh With atomic, the cursor surface is treated like a FB. Creating a proxy surface for cursor doesn't gain us much benefit. This fixes the issue on atomic enabled 2D VMs where the cursor disappears. Signed-off-by: Sinclair Yeh Reviewed-by: Thomas Hellstrom --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c index ef9f3a2..bcb6ddb 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c @@ -1498,6 +1498,7 @@ vmw_kms_new_framebuffer(struct vmw_private *dev_priv, */ if (vmw_kms_srf_ok(dev_priv, mode_cmd->width, mode_cmd->height) && dmabuf && only_2d && + mode_cmd->width > 64 && /* Don't create a proxy for cursor */ dev_priv->active_display_unit == vmw_du_screen_target) { ret = vmw_create_dmabuf_proxy(dev_priv->dev, mode_cmd, dmabuf, &surface);