| Message ID | 15-v2-d36939638fc6+d54-vfio2_jgg@nvidia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Make vfio_mdev type safe | expand |
On 2021.04.06 16:40:38 -0300, Jason Gunthorpe wrote: > At some point there may have been some reason for this weird split in this > driver, but today only the VFIO side is actually implemented. > > However, it got messed up at some point and mdev code was put in gvt.c and > is pretending to be "generic" by masquerading as some generic attribute list: > > static MDEV_TYPE_ATTR_RO(description); > > But MDEV_TYPE attributes are only usable with mdev_device, nothing else. > > Ideally all of this would be moved to kvmgt.c, but it is entangled with > the rest of the "generic" code in an odd way. Thus put in a kconfig > dependency so we don't get randconfig failures when the next patch creates > a link time dependency related to the use of MDEV_TYPE. > > Reviewed-by: Kevin Tian <kevin.tian@intel.com> > Reviewed-by: Christoph Hellwig <hch@lst.de> > Signed-off-by: Jason Gunthorpe <jgg@nvidia.com> > --- > drivers/gpu/drm/i915/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig > index 1e1cb245fca778..483e9ff8ca1d23 100644 > --- a/drivers/gpu/drm/i915/Kconfig > +++ b/drivers/gpu/drm/i915/Kconfig > @@ -101,6 +101,7 @@ config DRM_I915_GVT > bool "Enable Intel GVT-g graphics virtualization host support" > depends on DRM_I915 > depends on 64BIT > + depends on VFIO_MDEV > default n > help > Choose this option if you want to enable Intel GVT-g graphics > -- Acked-by: Zhenyu Wang <zhenyuw@linux.intel.com>
diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig index 1e1cb245fca778..483e9ff8ca1d23 100644 --- a/drivers/gpu/drm/i915/Kconfig +++ b/drivers/gpu/drm/i915/Kconfig @@ -101,6 +101,7 @@ config DRM_I915_GVT bool "Enable Intel GVT-g graphics virtualization host support" depends on DRM_I915 depends on 64BIT + depends on VFIO_MDEV default n help Choose this option if you want to enable Intel GVT-g graphics