From patchwork Fri Jul 14 13:41:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Mike Galbraith X-Patchwork-Id: 9842397 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 44A2660392 for ; Sat, 15 Jul 2017 13:21:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 34CF328733 for ; Sat, 15 Jul 2017 13:21:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 29BEA28747; Sat, 15 Jul 2017 13:21:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=2.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_MED,RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E955128733 for ; Sat, 15 Jul 2017 13:21:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3779D6E901; Sat, 15 Jul 2017 13:20:57 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9B4896E831; Fri, 14 Jul 2017 13:41:48 +0000 (UTC) Received: from homer.simpson.net ([188.174.243.207]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0LsxuQ-1dcyqy1iDS-012V6C; Fri, 14 Jul 2017 15:41:34 +0200 Message-ID: <1500039693.5763.15.camel@gmx.de> Subject: Re: [regression drm/noveau] suspend to ram -> BOOM: exception RIP: drm_calc_vbltimestamp_from_scanoutpos+335 From: Mike Galbraith To: Ilia Mirkin , Peter Zijlstra Date: Fri, 14 Jul 2017 15:41:33 +0200 In-Reply-To: <1500039368.5763.12.camel@gmx.de> References: <1499794333.5315.8.camel@gmx.de> <1499796510.5315.27.camel@gmx.de> <1499853345.23742.8.camel@gmx.de> <1499858703.23742.25.camel@gmx.de> <1500039368.5763.12.camel@gmx.de> X-Mailer: Evolution 3.20.5 Mime-Version: 1.0 X-Provags-ID: V03:K0:98vyqHFBTB0GvLxCxDMhXTXdOsTdh6fBREL7aZwus0mTYsxVd3Y OgA+FDKUwCh0twZ6VPdA/YW25cve4YtGh/3v0riSbI42rznYP5yFKkdEpFPpEiKJXvsigAB yz7K0a89OFAW3WN6tvqIkVz6umFCWP92Xkqc1crCK7bXK7H6XF+mL1TvwuKA0YzVaG4nH/q Nda2AKeF/mU1oUn7MQZaw== X-UI-Out-Filterresults: notjunk:1; V01:K0:xM1R4ir9HqA=:57w/bwVZJ6l54F3/6BEbHt FY/IRAPGbuhpssc72s945lS+ztCEh97d2Q9vVX8Wv5c36ZPu3GPovZvyeDyZFFjI3VKzxewrQ TfqwCaS7bXOJEgwXetteVJHMfwZj6Hs5xPd+BdBCXzo9855ZicTTaUcDy2tzLAomyaFFgH7kI nFMRdJS4rouNfjJwnD48T0SNaRBfi1l1tdwEMPOG5W7b3DOCd23XCF1ri2UVZRS2PGaLrvL2m NSGMMBDM9R2PO0342LevRjaKRnugI395n8l8kerv7sOFwB2pkArCfKBdWR7LjBuCNNkpyt/16 ZVUnBzCr7zYX38kpkBcQbUzB3yEm047E6FaC4xCREEqVRL6j19diJvMxxMKTUPtaHrSCDJO32 d2gaRVnbg5ZT8m6KWYTMvIf1gzT5sg8mHy0vwSYzJFEXEx2M/Z9jhcIPuLXlHLOcH+RDkJJN8 KoSvOiSOn7a1IVyk234uE5hqIBWM8pqHQae2GDCdGcfF3+GT7WndVb7rbM9M+3ByL7l77Dap6 Q1dyZg3LFrBkcAXLZfPEYlC0PGqBf+0qMZLrvLdE4WeikM1D8XkX3FiuSwzbnyXOPY6FD2nGH tUMy4Lu0RBckUfEttT+YUBQ+3liuX5K1BmYynG+QUzCN5kAJFWkJXn8UlKA3M/BfhAxg98T5a gBM9CcV6VAj+/LbF2++BluYcSNuIkdOQY6Yt+1zxgeq+pf07h9I2iI0zBQssJ9QQJICmGmaI+ g4cf+WS+0PeWICFYgTZ4YOYaN8tLpKyUnPAj3CIQKFttFLiGAYtt5ZwYnDAbltiTfz1nOR7mg WioOaKpDKd7XHhqJ6RCpdkX+nWcB4DbOs6pG/Y+F9gMJXs81no= X-Mailman-Approved-At: Sat, 15 Jul 2017 13:20:48 +0000 Cc: "nouveau@lists.freedesktop.org" , LKML , "dri-devel@lists.freedesktop.org" , Ben Skeggs X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP On Fri, 2017-07-14 at 15:36 +0200, Mike Galbraith wrote: >  All DRM did was to slip a > WARN_ON_ONCE() that nouveau triggers into a kernel module where such > things no longer warn, they blow the box out of the water. BTW, turn that irksome WARN_ON_ONCE() in drivers/gpu/drm/drm_vblank.c into a WARN_ONCE(), and all is peachy, you get the warning, box lives. Reviewed-By: Karol Herbst --- drivers/gpu/drm/drm_vblank.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/gpu/drm/drm_vblank.c +++ b/drivers/gpu/drm/drm_vblank.c @@ -605,7 +605,8 @@ bool drm_calc_vbltimestamp_from_scanoutp */ if (mode->crtc_clock == 0) { DRM_DEBUG("crtc %u: Noop due to uninitialized mode.\n", pipe); - WARN_ON_ONCE(drm_drv_uses_atomic_modeset(dev)); + WARN_ONCE(drm_drv_uses_atomic_modeset(dev), "%s: report me.\n", + dev->driver->name); return false; }