| Message ID | 1500837417-40580-10-git-send-email-noralf@tronnes.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sun, 2017-07-23 at 21:16 +0200, Noralf Trønnes wrote: > This driver can use the drm_driver.dumb_destroy and > drm_driver.dumb_map_offset defaults, so no need to set them. > > Cc: Philipp Zabel <p.zabel@pengutronix.de> > Signed-off-by: Noralf Trønnes <noralf@tronnes.org> > --- > drivers/gpu/drm/imx/imx-drm-core.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c > index f5c6212..f91cb72 100644 > --- a/drivers/gpu/drm/imx/imx-drm-core.c > +++ b/drivers/gpu/drm/imx/imx-drm-core.c > @@ -182,8 +182,6 @@ static struct drm_driver imx_drm_driver = { > .gem_free_object_unlocked = drm_gem_cma_free_object, > .gem_vm_ops = &drm_gem_cma_vm_ops, > .dumb_create = drm_gem_cma_dumb_create, > - .dumb_map_offset = drm_gem_cma_dumb_map_offset, Are there any users of drm_gem_cma_dumb_map_offset left after patch 21? > - .dumb_destroy = drm_gem_dumb_destroy, > > .prime_handle_to_fd = drm_gem_prime_handle_to_fd, > .prime_fd_to_handle = drm_gem_prime_fd_to_handle, Acked-by: Philipp Zabel <p.zabel@pengutronix.de> regards Philipp
Den 24.07.2017 09.46, skrev Philipp Zabel: > On Sun, 2017-07-23 at 21:16 +0200, Noralf Trønnes wrote: >> This driver can use the drm_driver.dumb_destroy and >> drm_driver.dumb_map_offset defaults, so no need to set them. >> >> Cc: Philipp Zabel <p.zabel@pengutronix.de> >> Signed-off-by: Noralf Trønnes <noralf@tronnes.org> >> --- >> drivers/gpu/drm/imx/imx-drm-core.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c >> index f5c6212..f91cb72 100644 >> --- a/drivers/gpu/drm/imx/imx-drm-core.c >> +++ b/drivers/gpu/drm/imx/imx-drm-core.c >> @@ -182,8 +182,6 @@ static struct drm_driver imx_drm_driver = { >> .gem_free_object_unlocked = drm_gem_cma_free_object, >> .gem_vm_ops = &drm_gem_cma_vm_ops, >> .dumb_create = drm_gem_cma_dumb_create, >> - .dumb_map_offset = drm_gem_cma_dumb_map_offset, > Are there any users of drm_gem_cma_dumb_map_offset left after patch 21? You're quite right, there isn't, I forgot to remove it :-) Thanks. Noralf. >> - .dumb_destroy = drm_gem_dumb_destroy, >> >> .prime_handle_to_fd = drm_gem_prime_handle_to_fd, >> .prime_fd_to_handle = drm_gem_prime_fd_to_handle, > Acked-by: Philipp Zabel <p.zabel@pengutronix.de> > > regards > Philipp >
diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c index f5c6212..f91cb72 100644 --- a/drivers/gpu/drm/imx/imx-drm-core.c +++ b/drivers/gpu/drm/imx/imx-drm-core.c @@ -182,8 +182,6 @@ static struct drm_driver imx_drm_driver = { .gem_free_object_unlocked = drm_gem_cma_free_object, .gem_vm_ops = &drm_gem_cma_vm_ops, .dumb_create = drm_gem_cma_dumb_create, - .dumb_map_offset = drm_gem_cma_dumb_map_offset, - .dumb_destroy = drm_gem_dumb_destroy, .prime_handle_to_fd = drm_gem_prime_handle_to_fd, .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
This driver can use the drm_driver.dumb_destroy and drm_driver.dumb_map_offset defaults, so no need to set them. Cc: Philipp Zabel <p.zabel@pengutronix.de> Signed-off-by: Noralf Trønnes <noralf@tronnes.org> --- drivers/gpu/drm/imx/imx-drm-core.c | 2 -- 1 file changed, 2 deletions(-)