From patchwork Sun Jul 30 21:11:38 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 9870693 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C67D36038F for ; Sun, 30 Jul 2017 22:12:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B093A2858E for ; Sun, 30 Jul 2017 22:12:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A4FE528562; Sun, 30 Jul 2017 22:12:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1C70728562 for ; Sun, 30 Jul 2017 22:12:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DB66F6E3CE; Sun, 30 Jul 2017 22:11:56 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org X-Greylist: delayed 3606 seconds by postgrey-1.35 at gabe; Sun, 30 Jul 2017 22:11:55 UTC Received: from vern.gendns.com (vern.gendns.com [206.190.152.46]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5A36D6E3CE for ; Sun, 30 Jul 2017 22:11:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lechnology.com; s=default; h=Message-Id:Date:Subject:Cc:To:From:Sender: Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=wKudAOUhZivk/wa3YlugxCWDVG/dn/uBnEMqdzMKMrw=; b=TdblyzIkk5vegEhu9mrJTrlh14 UIJkEF0l1Byzt4hnJKUb0rz8e8og/WMb2OQmPvTgLBDOqZDbLwhOJAEG5DCDvYYarTDcGkpY3uUTw Cd89pxloquk9hMjEoDV3ZvhZ8eZGL7nMpX1/pxcrj67f14VRMuBfA7XW4zsR7xBSQcqBsUttQJymB E2WxWWrcd6yBBKKCt2imwEplBbheA2P1LzG4oTHmyKC7C+pfEEECqPou8ldrmtfoDEG6Vah5X38D8 LPnkTK27DBiT/4N/z2dXJkQiemzvddWVtidDzGxPRs3VI8QMyyu3ksEvwetQUVUO4FCjPM4J8KGsY boawFrrA==; Received: from 108-198-5-147.lightspeed.okcbok.sbcglobal.net ([108.198.5.147]:54344 helo=freyr.lechnology.com) by vern.gendns.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-SHA256:128) (Exim 4.89) (envelope-from ) id 1dbvSS-003caE-Sc; Sun, 30 Jul 2017 17:09:05 -0400 From: David Lechner To: dri-devel@lists.freedesktop.org Subject: [RFC] drm/fb: Propagate physical display dimensions to fbdev Date: Sun, 30 Jul 2017 16:11:38 -0500 Message-Id: <1501449098-26148-1-git-send-email-david@lechnology.com> X-Mailer: git-send-email 2.7.4 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - lists.freedesktop.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Cc: David Lechner , linux-kernel@vger.kernel.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP fbdev has a place for the physical width and height of a display. I would like to have this information available to userspace. This patch works for me, but I have a strong suspicion that this is not the "right way". Any suggestions on how to get the proper struct drm_display_info here rather than assuming the first connector one is valid? I don't see an obvious way to do this. --- drivers/gpu/drm/drm_fb_helper.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index 574af01..ff422da 100644 --- a/drivers/gpu/drm/drm_fb_helper.c +++ b/drivers/gpu/drm/drm_fb_helper.c @@ -1768,8 +1768,14 @@ void drm_fb_helper_fill_var(struct fb_info *info, struct drm_fb_helper *fb_helpe info->var.xoffset = 0; info->var.yoffset = 0; info->var.activate = FB_ACTIVATE_NOW; - info->var.height = -1; - info->var.width = -1; + + if (fb_helper->connector_count) { + info->var.height = fb_helper->connector_info[0]->connector->display_info.width_mm; + info->var.width = fb_helper->connector_info[0]->connector->display_info.height_mm; + } else { + info->var.height = -1; + info->var.width = -1; + } switch (fb->format->depth) { case 8: