From patchwork Tue Oct 3 03:53:46 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Rowand X-Patchwork-Id: 9981873 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1EC8060291 for ; Tue, 3 Oct 2017 07:20:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 11AC628249 for ; Tue, 3 Oct 2017 07:20:28 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0687F286C1; Tue, 3 Oct 2017 07:20:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id CDD0B286BE for ; Tue, 3 Oct 2017 07:20:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 383CA6E3F9; Tue, 3 Oct 2017 07:19:40 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pg0-x243.google.com (mail-pg0-x243.google.com [IPv6:2607:f8b0:400e:c05::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0898F6E3A6 for ; Tue, 3 Oct 2017 03:54:17 +0000 (UTC) Received: by mail-pg0-x243.google.com with SMTP id o1so6859334pga.4 for ; Mon, 02 Oct 2017 20:54:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=gXZNSkeEgfxKwM43IBGZsTlFVFLhT6ZLihhf+f8wAyk=; b=qSGYkQTlYshD8gTNH1HE1xDhVrdBL522ujV02bMn9Bnp8v4wVinwgTvVUWfxLhNZM0 3BFowpRq+gTDKhDSxYMTSWj9WERpu0OMH4AlwrqdmzkUCkjIVyDAvOCetz1sABjQHsul KvvweHqfYMyJl3BvSIEgDJM23GEiKYAJGlAfI0gMoFvKjCODksvqlNNhsSGDSEAj9P4O p2UUUxVzT9wofr3gsRKsg6Pff/Wsvx72pJulFsYQNMTeegvkivOHvcIimmCwM/oIlb5H IcwqXjR030Y3M6I0Yi+UkYOAnMJXgdn01JrgMrdKG1VU+HtFso79WkZaKM0hAd81KgR/ mhyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=gXZNSkeEgfxKwM43IBGZsTlFVFLhT6ZLihhf+f8wAyk=; b=LcV3oIclkuyhanbugY0JNw8hxjRR34NltrKSwYP6MM+LejKzvaeDRztugQMch+iQrX nKxaRVdfDBERsGfEq+QXLhbz1ilkPePnufi+Sltezu8NJVPt44YOiWTZIZRjeagjLuav GBlbOHg9GehUcunKj9rtC2FnAbHRS/3bRWQi669/FyuZtwwkS+cmH+PgLdQftjnrSRuB anZ78/daTsEQo5cwrGMWBAPiueAS7VBkQUv4tDZn4GydaXgYZrLTk5B96getT4VxtJbX N107lBGr1d8QfdrdyR0BnV4Ef84UcnybzIK40b4+74yOgNvadh3ClTg2xiyspru9WTDD 7+jg== X-Gm-Message-State: AMCzsaX4266cjGiOEZzGg3nwuB1clL1nkuZN3z6u3TW3bRKE30YKb79H FhMPR+ZwkFVtwxU6zJ0M0DQ= X-Google-Smtp-Source: AOwi7QAYCp2uw6LwPj2XAcTB749OGgwUfgF5VAQ5ZYt9ws7OdGlU6QcIN/O16xLTuwMqkt/5ntIv4w== X-Received: by 10.99.97.67 with SMTP id v64mr6763103pgb.89.1507002857639; Mon, 02 Oct 2017 20:54:17 -0700 (PDT) Received: from localhost.localdomain (c-73-93-215-6.hsd1.ca.comcast.net. [73.93.215.6]) by smtp.gmail.com with ESMTPSA id c16sm18609930pfj.123.2017.10.02.20.54.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 02 Oct 2017 20:54:17 -0700 (PDT) From: frowand.list@gmail.com To: Rob Herring , Pantelis Antoniou , David Airlie , Jyri Sarha Subject: [PATCH 12/12] of: overlay: remove unneeded check for NULL kbasename() Date: Mon, 2 Oct 2017 20:53:46 -0700 Message-Id: <1507002826-16393-13-git-send-email-frowand.list@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1507002826-16393-1-git-send-email-frowand.list@gmail.com> References: <1507002826-16393-1-git-send-email-frowand.list@gmail.com> X-Mailman-Approved-At: Tue, 03 Oct 2017 07:19:35 +0000 Cc: Mark Rutland , devicetree@vger.kernel.org, Tomi Valkeinen , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Frank Rowand kbasename() will not return NULL if passed a valid string. If the parameter passed to kbasename() in this case is already NULL then the devicetree has been corrupted. Signed-off-by: Frank Rowand --- drivers/of/overlay.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c index 81881e45f273..88df2986b03f 100644 --- a/drivers/of/overlay.c +++ b/drivers/of/overlay.c @@ -322,8 +322,6 @@ static int add_changeset_node(struct overlay_changeset *ovcs, int ret = 0; node_kbasename = kbasename(node->full_name); - if (!node_kbasename) - return -ENOMEM; for_each_child_of_node(target_node, tchild) if (!of_node_cmp(node_kbasename, kbasename(tchild->full_name)))