From patchwork Tue Oct 17 23:36:32 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Rowand X-Patchwork-Id: 10014031 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E9E2260215 for ; Wed, 18 Oct 2017 08:17:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D955528AE2 for ; Wed, 18 Oct 2017 08:17:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CCF3628AF1; Wed, 18 Oct 2017 08:17:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7578028AE2 for ; Wed, 18 Oct 2017 08:17:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6FF926E80C; Wed, 18 Oct 2017 08:17:12 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pg0-x241.google.com (mail-pg0-x241.google.com [IPv6:2607:f8b0:400e:c05::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id CCAFA6E7C1 for ; Tue, 17 Oct 2017 23:36:57 +0000 (UTC) Received: by mail-pg0-x241.google.com with SMTP id b192so2702297pga.2 for ; Tue, 17 Oct 2017 16:36:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=tQZ5tgpgN09YJ1bHkHCIMGIGPen2KSCy/yMH0F0aZJY=; b=WnKyvdhYFU83x+VlfSE5IbbjDR4T7O2AoeCvcX3dUJ+gtur5OuDpBb5AY9B21PHhow eBt8jC5W3I3HO36EUR4cMm9BHjzMlhlm0uUMS/OoYzmBL7bvIhcTYM3B94uA5/jDLA8U uzVE33+dHQ7uqIpakx1h7xJNiXniJcpVoKa+5NS5Y4jQTu6PoSQ9GmeasjULkgxVhlzU y5xA8F6zi3JNLHIg2+MjXrs8bawHkXfiBxhWtU3tlOUuYzRWSp1zT6KYc54Dikj51Ajn HVIYIc2g9zkgz8msb4OuhaNEplEf6weACqeVM8yB0HO71D9HQAgaHV6oAFnFnQjtgk2h l4Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=tQZ5tgpgN09YJ1bHkHCIMGIGPen2KSCy/yMH0F0aZJY=; b=uP70gzKpuDg2l1bvw2x5cktRya6Jo6y+lTbhOMqh0GmQETLtqXfPzUR/HCmj+dmTUZ 6xrF96sE/aveDBwZ7ewYMXpTIb4GoqhXOAy6fTdJBVOBfeo1GbNlqvPjSa1Y8paM5Med mhOffBr/v1hH/NEYm4gTPTve+8MiGtdo46ktFakNsJcCdQHA5SDbsbSubVsCEfKo7exn rMiyoV8KM2bKjBc3nTVxddqVl97IMIJQtFCyllfAL8fJ0tMTjrzFsiG0sqUI+aXFGK9E mojCW06IjbAiQyQZVb/xCiSKFU5nwykkjVfB+xdeErpLBHbBKQjBdXX6DVtoE725ZxQO iuzA== X-Gm-Message-State: AMCzsaXrCXpSzIpBtXBQWAThFZanOoar/VGDfjo9xzdNM5RPZAYr7IHH +u22Oush2fwaRuF3MFWV3lo= X-Google-Smtp-Source: AOwi7QDOXWB3TN+oLnFVGQ/8YY9TRc7roecTat+W3Z+kcAA0S2EjoDq2TeJVbqLTAQcuyRWIQqOm0A== X-Received: by 10.101.86.196 with SMTP id w4mr12480545pgs.335.1508283417327; Tue, 17 Oct 2017 16:36:57 -0700 (PDT) Received: from localhost.localdomain (c-73-93-215-6.hsd1.ca.comcast.net. [73.93.215.6]) by smtp.gmail.com with ESMTPSA id 76sm21185562pfq.4.2017.10.17.16.36.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 17 Oct 2017 16:36:56 -0700 (PDT) From: frowand.list@gmail.com To: Rob Herring , Pantelis Antoniou , David Airlie , Jyri Sarha Subject: [PATCH v3 12/12] of: overlay: remove unneeded check for NULL kbasename() Date: Tue, 17 Oct 2017 16:36:32 -0700 Message-Id: <1508283392-18252-13-git-send-email-frowand.list@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1508283392-18252-1-git-send-email-frowand.list@gmail.com> References: <1508283392-18252-1-git-send-email-frowand.list@gmail.com> X-Mailman-Approved-At: Wed, 18 Oct 2017 08:17:09 +0000 Cc: Mark Rutland , devicetree@vger.kernel.org, Tomi Valkeinen , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Frank Rowand kbasename() will not return NULL if passed a valid string. If the parameter passed to kbasename() in this case is already NULL then the devicetree has been corrupted. Signed-off-by: Frank Rowand --- drivers/of/overlay.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c index 0e9aefc1ff15..c99842bb4b09 100644 --- a/drivers/of/overlay.c +++ b/drivers/of/overlay.c @@ -331,8 +331,6 @@ static int add_changeset_node(struct overlay_changeset *ovcs, int ret = 0; node_kbasename = kbasename(node->full_name); - if (!node_kbasename) - return -ENOMEM; for_each_child_of_node(target_node, tchild) if (!of_node_cmp(node_kbasename, kbasename(tchild->full_name)))