From patchwork Wed Nov 29 15:12:47 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maciej Purski X-Patchwork-Id: 10082491 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1C77260311 for ; Wed, 29 Nov 2017 15:13:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 06D2F299CD for ; Wed, 29 Nov 2017 15:13:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EFCD4299DB; Wed, 29 Nov 2017 15:13:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 0DF1C28E03 for ; Wed, 29 Nov 2017 15:13:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A09B76E03B; Wed, 29 Nov 2017 15:13:02 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id AC7F36E03B for ; Wed, 29 Nov 2017 15:13:01 +0000 (UTC) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20171129151259euoutp01c9bf4700e18f3be609eb615c2c8b15fa~7lzrfBiX-0666606666euoutp01g; Wed, 29 Nov 2017 15:12:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20171129151259euoutp01c9bf4700e18f3be609eb615c2c8b15fa~7lzrfBiX-0666606666euoutp01g DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1511968379; bh=SsI6GYHZ8n0uZI+fjUX4ZINW0DIRP+4yFWm2fcJdfwE=; h=From:To:Cc:Subject:Date:References:From; b=sJsOIOlSM9Y+sfm9/1znwGLNRSHzpK2d+ZQbRkkzql1Hb9hhiAtIDUqiT+UsfXwqO ND0nvLo4QAIeT554S93itArBcBSvlQGzcPnt+7rXkLUzVWE5TpV9wenEyJz8ioaKhP CZfvARRPhcRytePTyKgL2jfd7/+jEktsxsMnkYQQ= Received: from eusmges1.samsung.com (unknown [203.254.199.239]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20171129151258eucas1p2d448af3a8c763f726dac44914a13d40e~7lzqyK9Qg2617926179eucas1p2I; Wed, 29 Nov 2017 15:12:58 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1.samsung.com (EUCPMTA) with SMTP id DD.5C.12576.97ECE1A5; Wed, 29 Nov 2017 15:12:57 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20171129151257eucas1p20514361b9f472b44715881724b819fac~7lzqFn5480879708797eucas1p2b; Wed, 29 Nov 2017 15:12:57 +0000 (GMT) X-AuditID: cbfec7ef-f79ee6d000003120-d2-5a1ece792be6 Received: from eusync3.samsung.com ( [203.254.199.213]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 1A.A4.18832.97ECE1A5; Wed, 29 Nov 2017 15:12:57 +0000 (GMT) Received: from AMDC2075.DIGITAL.local ([106.120.51.25]) by eusync3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0P060009VQ9EI060@eusync3.samsung.com>; Wed, 29 Nov 2017 15:12:57 +0000 (GMT) From: Maciej Purski To: dri-devel@lists.freedesktop.org Subject: [PATCH 1/2] drm/bridge/sii8620: remove HSIC initialization Date: Wed, 29 Nov 2017 16:12:47 +0100 Message-id: <1511968368-30884-1-git-send-email-m.purski@samsung.com> X-Mailer: git-send-email 2.7.4 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrLIsWRmVeSWpSXmKPExsWy7djP87qV5+SiDNZ8sLG4te4cq0XvuZNM Fk0db1ktNs5Yz2px5et7NovOiUvYLS7vmsNmseDlLRaLtUfusjtwelzu62XymN0xk9Vj+7cH rB73u48zefRtWcXo8XmTXABbFJdNSmpOZllqkb5dAldGZ28Pe8FegYpzv1vZGxjf8XYxcnJI CJhItBzdwgphi0lcuLeerYuRi0NIYBmjxI9LR1ggnM+MEn9mXWWF6XjzdyEzXNXDU3OZIJz/ jBKPLp8AauHgYBPQkljTHg/SICKgLPF34ipGkBpmgatMEicvb2cCSQgLOEvs/faJDcRmEVCV mPG1ByzOK+AisfjbVzaIbXISN891MkPYU9gk9k3QBJkvAVTzaHMGRFhY4tXxLewQtoxEZ8dB Jgi7WuLi111QY2okGm9vgKqxlvg8aQvYSGYBPolJ26YzQ4zklehoE4Io8ZA49/A3E0TYUWJy SxlIWEggVuLPrWbWCYxSCxgZVjGKpJYW56anFhvqFSfmFpfmpesl5+duYgRG6ul/x9/vYHza HHKIUYCDUYmHV2O1bJQQa2JZcWXuIUYJDmYlEV6F3XJRQrwpiZVVqUX58UWlOanFhxilOViU xHlto9oihQTSE0tSs1NTC1KLYLJMHJxSDYw8d/PVaq10Nuz0LfFh4a8xybsX51q+qVSh69a6 P8ejllWKdd7dnrhRNNO0Q/neaeGWsocFRmfuWm5eafjyzlO+nyebkxb9mde5m+dCjulezV7R 68K3Xvffffxz8be6oCn1e2YpX+W8ciTg/gnODdNjnY0bly1Wzl3T7fXRfB9jHks+k3SWFJcS S3FGoqEWc1FxIgA3UhpW0AIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupiluLIzCtJLcpLzFFi42I5/e/4Vd3Kc3JRBjunyVncWneO1aL33Ekm i6aOt6wWG2esZ7W48vU9m0XnxCXsFpd3zWGzWPDyFovF2iN32R04PS739TJ5zO6Yyeqx/dsD Vo/73ceZPPq2rGL0+LxJLoAtissmJTUnsyy1SN8ugSujs7eHvWCvQMW5363sDYzveLsYOTkk BEwk3vxdyAxhi0lcuLeerYuRi0NIYAmjxLoFd5khnEYmiTlNb5m6GDk42AS0JNa0x4M0iAgo S/yduIoRpIZZ4CaTxN+ze1lBEsICzhJ7v31iA7FZBFQlZnztYQKxeQVcJBZ/+8oGsU1O4ua5 TuYJjNwLGBlWMYqklhbnpucWG+oVJ+YWl+al6yXn525iBIbQtmM/N+9gvLQx+BCjAAejEg+v xmrZKCHWxLLiytxDjBIczEoivAq75aKEeFMSK6tSi/Lji0pzUosPMUpzsCiJ8/buWR0pJJCe WJKanZpakFoEk2Xi4JRqYLTctfkXE1PstDXdzIl6vYse/Vr7XmtJT0xO440XC9K25dkt+O2w YoFr/86vNjNfGx9MVpp/tf1HXscHMUHPpQ4adtIXJPvdJsyZpdcnt3Qy0/IpLZ+Wydje2Naq +3+F7IXsJ/uUuXYc3Vh8OHPO5AOvOxbFPO8LWZvp1LRTvYtxkg1jrvTuHjElluKMREMt5qLi RABJKxBbHQIAAA== X-CMS-MailID: 20171129151257eucas1p20514361b9f472b44715881724b819fac X-Msg-Generator: CA CMS-TYPE: 201P X-CMS-RootMailID: 20171129151257eucas1p20514361b9f472b44715881724b819fac X-RootMTR: 20171129151257eucas1p20514361b9f472b44715881724b819fac References: Cc: Bartlomiej Zolnierkiewicz , David Airlie , linux-kernel@vger.kernel.org, Maciej Purski , Laurent Pinchart , Marek Szyprowski X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP HSIC initialization was taken from the vendor code. HSIC in MHL circuit is not connected, so it is not possible to test it. Tests prove that without HSIC the device works well. Therefore it can be removed. Signed-off-by: Maciej Purski --- drivers/gpu/drm/bridge/sil-sii8620.c | 38 ------------------------------------ 1 file changed, 38 deletions(-) diff --git a/drivers/gpu/drm/bridge/sil-sii8620.c b/drivers/gpu/drm/bridge/sil-sii8620.c index e81c96a..35ccc90 100644 --- a/drivers/gpu/drm/bridge/sil-sii8620.c +++ b/drivers/gpu/drm/bridge/sil-sii8620.c @@ -502,50 +502,12 @@ static void sii8620_sink_detected(struct sii8620 *ctx, int ret) sink_str[ctx->sink_type], sink_name); } -static void sii8620_hsic_init(struct sii8620 *ctx) -{ - if (!sii8620_is_mhl3(ctx)) - return; - - sii8620_write(ctx, REG_FCGC, - BIT_FCGC_HSIC_HOSTMODE | BIT_FCGC_HSIC_ENABLE); - sii8620_setbits(ctx, REG_HRXCTRL3, - BIT_HRXCTRL3_HRX_STAY_RESET | BIT_HRXCTRL3_STATUS_EN, ~0); - sii8620_setbits(ctx, REG_TTXNUMB, MSK_TTXNUMB_TTX_NUMBPS, 4); - sii8620_setbits(ctx, REG_TRXCTRL, BIT_TRXCTRL_TRX_FROM_SE_COC, ~0); - sii8620_setbits(ctx, REG_HTXCTRL, BIT_HTXCTRL_HTX_DRVCONN1, 0); - sii8620_setbits(ctx, REG_KEEPER, MSK_KEEPER_MODE, VAL_KEEPER_MODE_HOST); - sii8620_write_seq_static(ctx, - REG_TDMLLCTL, 0, - REG_UTSRST, BIT_UTSRST_HRX_SRST | BIT_UTSRST_HTX_SRST | - BIT_UTSRST_KEEPER_SRST | BIT_UTSRST_FC_SRST, - REG_UTSRST, BIT_UTSRST_HRX_SRST | BIT_UTSRST_HTX_SRST, - REG_HRXINTL, 0xff, - REG_HRXINTH, 0xff, - REG_TTXINTL, 0xff, - REG_TTXINTH, 0xff, - REG_TRXINTL, 0xff, - REG_TRXINTH, 0xff, - REG_HTXINTL, 0xff, - REG_HTXINTH, 0xff, - REG_FCINTR0, 0xff, - REG_FCINTR1, 0xff, - REG_FCINTR2, 0xff, - REG_FCINTR3, 0xff, - REG_FCINTR4, 0xff, - REG_FCINTR5, 0xff, - REG_FCINTR6, 0xff, - REG_FCINTR7, 0xff - ); -} - static void sii8620_edid_read(struct sii8620 *ctx, int ret) { if (ret < 0) return; sii8620_set_upstream_edid(ctx); - sii8620_hsic_init(ctx); sii8620_enable_hpd(ctx); }