From patchwork Wed Dec 13 14:22:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jia-Ju Bai X-Patchwork-Id: 10111603 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7151160352 for ; Thu, 14 Dec 2017 08:23:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5702129BF1 for ; Thu, 14 Dec 2017 08:23:28 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4B57C29C09; Thu, 14 Dec 2017 08:23:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 047AC29BF1 for ; Thu, 14 Dec 2017 08:23:28 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1E6AD6E645; Thu, 14 Dec 2017 08:23:09 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pf0-x244.google.com (mail-pf0-x244.google.com [IPv6:2607:f8b0:400e:c00::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2BB886E20F for ; Wed, 13 Dec 2017 14:20:08 +0000 (UTC) Received: by mail-pf0-x244.google.com with SMTP id u19so1369746pfa.12 for ; Wed, 13 Dec 2017 06:20:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=uVsR3iRajqy5PW9pPiQ8seUgKeBNPiEHN2wPqnaxgWc=; b=UUYn1EP5zKoJcAwlOKI/fJ1gFXrOp317cbWos3FgA7tNn7FLLTY1stCBQMW+4bTyHM XtpiSihukE/oK+F0+8ZYOyl7azmUP+f2L/HIC+nurzRKegxsbbTCDPBtYJlkv1fOTufA qlO0f8tQYQp+s7bZbVEyj7wgRZHTG7qjdTeCqvNFMkOHFEtD73sF7q92wjYEz9ML6XVZ VC3r+9x13yN2N9YD+vJl29FIfkrA8I01UjRz8qLaOlxUivZZG2VP6hoDl+0mrK0S2DTo gV46Zn9b7YQqbSZsn9PTb6oswh0lhsNtFI6mp8u9HCdilj5PDAj9/s3sqTKh07A/TNPV 1vQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=uVsR3iRajqy5PW9pPiQ8seUgKeBNPiEHN2wPqnaxgWc=; b=VNQRGaB0ChADrkP5fOfsnCOdJgx8REFX8Xa7Fauk2Zyh+IRUM6GYRiZK7kxZJpyD9z uV5zMJcKHcAfKbTC+irhIDC6rY7e6I9qSZL4u/wzVb7+8WPFoToxyT4aWw8ped5n63tq tUvhE8ickPNgNZkhfC20P9G3z0XgeXT2Sf4LbOWLnSfgWP7yfbfk3LYJM9WK964kMW3F LLTbGMpXP1zt2oi9UqlvaR91NVVU/y6TbVi6x0B85zCpXhxdw6Cg0vDUrxdDpLQKQ1j0 VQfwLE/jenHgF9eqBZo0/T/XFZCF5I4hugMQG7BNvuMPA7WDk6hKuTrV6/+MR5gIXN3p yhaw== X-Gm-Message-State: AKGB3mKe0sMapQfaQmTooTkpuKiVY5wL2wTDdv58qcWbk5qvfNI9NoZw J6RfQDH8K62gwXmeh1d5o2qYjJ2+ X-Google-Smtp-Source: ACJfBosIG+jvGug9unSCYVlju7g7xKUxq5vBj1EKJ8pPzF4NJvAylcqLKyh87Q2kOnRCVL3xmHE2uQ== X-Received: by 10.99.110.201 with SMTP id j192mr5535704pgc.70.1513174807739; Wed, 13 Dec 2017 06:20:07 -0800 (PST) Received: from bai-oslab.tsinghua.edu.cn ([2402:f000:1:4413:359f:3e1b:e2be:59f6]) by smtp.gmail.com with ESMTPSA id z22sm4966661pfl.135.2017.12.13.06.20.02 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 13 Dec 2017 06:20:06 -0800 (PST) From: Jia-Ju Bai To: daniel.vetter@intel.com, jani.nikula@linux.intel.com, seanpaul@chromium.org, airlied@linux.ie, dh.herrmann@gmail.com Subject: [PATCH] drm: Fix a possible sleep-in-atomic bug in show_leaks Date: Wed, 13 Dec 2017 22:22:23 +0800 Message-Id: <1513174943-18891-1-git-send-email-baijiaju1990@gmail.com> X-Mailer: git-send-email 1.7.9.5 X-Mailman-Approved-At: Thu, 14 Dec 2017 08:23:02 +0000 Cc: Jia-Ju Bai , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP The driver may sleep under a spinlock. The function call path is: drm_vma_offset_manager_destroy (acquire the spinlock) drm_mm_takedown show_leaks kmalloc(GFP_KERNEL) --> may sleep To fix it, GFP_KERNEL is replaced with GFP_ATOMIC. This bug is found by my static analysis tool(DSAC) and checked by my code review. Signed-off-by: Jia-Ju Bai --- drivers/gpu/drm/drm_mm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c index 61a1c8e..5b9965d 100644 --- a/drivers/gpu/drm/drm_mm.c +++ b/drivers/gpu/drm/drm_mm.c @@ -127,7 +127,7 @@ static void show_leaks(struct drm_mm *mm) unsigned long entries[STACKDEPTH]; char *buf; - buf = kmalloc(BUFSZ, GFP_KERNEL); + buf = kmalloc(BUFSZ, GFP_ATOMIC); if (!buf) return;