Message ID | 1516932247-10750-6-git-send-email-hyun.kwon@xilinx.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <dri-devel-bounces@lists.freedesktop.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E672A60211 for <patchwork-dri-devel@patchwork.kernel.org>; Fri, 26 Jan 2018 02:04:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D500028C4D for <patchwork-dri-devel@patchwork.kernel.org>; Fri, 26 Jan 2018 02:04:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CA02D28C52; Fri, 26 Jan 2018 02:04:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 863B828C4D for <patchwork-dri-devel@patchwork.kernel.org>; Fri, 26 Jan 2018 02:04:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C60FE6E0D7; Fri, 26 Jan 2018 02:04:23 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0078.outbound.protection.outlook.com [104.47.33.78]) by gabe.freedesktop.org (Postfix) with ESMTPS id EC2C36E097 for <dri-devel@lists.freedesktop.org>; Fri, 26 Jan 2018 02:04:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=iiuJc4CDEbDNMfFTb3ogYbo/oif33O7se0+4EoEdXSc=; b=AVWFPjBq6qeaHB5I8+IsLNSfVU3b4DpdwgIS0v+HvsXCOCa8i99+vg7cWvQR9R8mevu6MmTwPuPBQ71gogPefhh8AXeIeDdeQnR6fYPL03V1t7URe12hbi4xHttaZxFRivUxeT+SNqzEhG9moFGKeKgPOmh3rSzDAuffM32Fnoc= Received: from SN4PR0201CA0050.namprd02.prod.outlook.com (10.171.31.140) by CY1PR02MB1334.namprd02.prod.outlook.com (10.161.170.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Fri, 26 Jan 2018 02:04:17 +0000 Received: from BL2NAM02FT059.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e46::209) by SN4PR0201CA0050.outlook.office365.com (2603:10b6:803:20::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.444.14 via Frontend Transport; Fri, 26 Jan 2018 02:04:16 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; lists.freedesktop.org; dkim=none (message not signed) header.d=none; lists.freedesktop.org; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01; Received: from xsj-pvapsmtpgw01 (149.199.60.83) by BL2NAM02FT059.mail.protection.outlook.com (10.152.76.247) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.428.12 via Frontend Transport; Fri, 26 Jan 2018 02:04:16 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw01 with esmtp (Exim 4.63) (envelope-from <hyun.kwon@xilinx.com>) id 1eetNH-0005Jp-Oh; Thu, 25 Jan 2018 18:04:15 -0800 Received: from [127.0.0.1] (helo=xsj-smtp-dlp1.xlnx.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from <hyun.kwon@xilinx.com>) id 1eetNH-0002nC-K1; Thu, 25 Jan 2018 18:04:15 -0800 Received: from xsj-pvapsmtp01 (xsj-smtp.xilinx.com [149.199.38.66]) by xsj-smtp-dlp1.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id w0Q24EXI016039; Thu, 25 Jan 2018 18:04:14 -0800 Received: from [172.19.2.244] (helo=xsjhyunkubuntu) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from <hyunk@smtp.xilinx.com>) id 1eetNG-0002mE-8L; Thu, 25 Jan 2018 18:04:14 -0800 Received: by xsjhyunkubuntu (Postfix, from userid 13638) id 3E42E2C697D; Thu, 25 Jan 2018 18:04:14 -0800 (PST) From: Hyun Kwon <hyun.kwon@xilinx.com> To: <dri-devel@lists.freedesktop.org> Subject: [RFC v2 05/10] drm: fb_cma_helper: Use drm_format_plane_width_bytes() Date: Thu, 25 Jan 2018 18:04:02 -0800 Message-ID: <1516932247-10750-6-git-send-email-hyun.kwon@xilinx.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1516932247-10750-1-git-send-email-hyun.kwon@xilinx.com> References: <1516932247-10750-1-git-send-email-hyun.kwon@xilinx.com> X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.2.0.1013-23618.006 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(39860400002)(396003)(39380400002)(376002)(346002)(2980300002)(438002)(189003)(199004)(90966002)(76176011)(356003)(51416003)(4326008)(305945005)(63266004)(6266002)(59450400001)(107886003)(103686004)(81156014)(8936002)(36756003)(8676002)(81166006)(39060400002)(50226002)(6916009)(5660300001)(2906002)(47776003)(52956003)(2351001)(50466002)(42186006)(16586007)(54906003)(478600001)(106466001)(186003)(6666003)(316002)(48376002)(106002)(2950100002)(26005)(336011)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR02MB1334; H:xsj-pvapsmtpgw01; FPR:; SPF:Pass; PTR:unknown-60-83.xilinx.com; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2NAM02FT059; 1:ro9tXMrxO+KpbHhEkMBhR+7GCR5TkUx0YVDZO8opqnMdnlzklHOUKj2oyUOrQRbHGT6GJfjQt7KJFq1WWNrQpxQXq6wcGcFqsO4aJtj/EIL+BRBlDUezBLspwBM1hTqy MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bba9085f-f457-4380-d5a5-08d564611abc X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(4608076)(2017052603307)(7153060); SRVR:CY1PR02MB1334; X-Microsoft-Exchange-Diagnostics: 1; CY1PR02MB1334; 3:UmYC0TGYlncpinph/SW/00MB419yF1g+2OBwiGQ6vdZWfMTHazfOM5AcBASIlVgpcoTA6bMtGEEn3RpLrRc5Q6tri9SefNfn+yyGl821kDUphmJiVd1rkS7Lo0xHCidhtiNHVgAYC/vvrLudY3sZ1oAa3ySfpNEWdpBIwx+f7qgHNjHsz1kMC5gsU2v+eqeDgXhhfyqXirp1dyWnZ79Vl3IuGmHfsXxHEDpMA3HYToviLfbi3XWITA2CEvApWKOfCLKkzmcHtevdvCli68SUd6KFzQUhJjmIQJ9t5EeI2KvV/5e2zP4V86ZlcwOHfaOlmgiKGE0gBls/6hgPn4F3+pbWixdNRrWY/5cSWQjONUU=; 25:8N0b8B8Yd4JkbA/dpNatpX1RCg/zCz878CAccS4j1drIg/L8Ra53qR5dPj2dL6jgcTWa60Rho+vWU1jQYGhSQNwSvVe0IYv0qTMlO3THoHor42Ok68QZuthUBbuFjB3uO+eFxUgMhlPFubJIVLaK3wJJ9czWFGT4z9fKxNxUbRKTGWW3R82MMQpUDMCh7FZIq8a3rSd0fMQc82cwx+x6kZpel/+GcjO11tJo5GWtazs3SPmqzdHxgZnQrQD0qTKcyyPZwCKCx1uv7TNIIjwGmREh6041dRZOhFpowXxCwUNY97UmD6PoJYB1OLOHvjTa5arELg+b9XXZ43gKU+PT0Q== X-MS-TrafficTypeDiagnostic: CY1PR02MB1334: X-Microsoft-Exchange-Diagnostics: 1; CY1PR02MB1334; 31:d/F4ueSseKKKEGHOAvd6Zk3pjqlHngcupGF0ha9l7bIzovKh5K/yHeEkyG2dV1bzMz7FkTJQTQn2cHz3am9FRkivngxGyhyKftAew/qcnwWcMSfRyEpfyT68qPiekLAEsIxry4kXHA/VIJZ1X/awLPCDpHoIhs3cJu+Kty+ZztKtyc7FAnW5OJgoN1IitBzovzmz1lOJ6F3T+DrZcYA9ZGQQL61KH0tLReoOG8Q9e/c=; 20:+uweaXMWDPcrrjU9O522rr2qxrU5NrhscRR0fcXWFeFjFC5LKyz1QAZNF+S3ocxvJt0g7W/5gtZvG7fynDK0U8b/e2eN0c9uHvlcalTgcn+mMvAoYhSPMN+aDXyrts04AKLTkrjwMcCbzENz2fwOWjUEQx+O1gxLSdhQ8Xzt4klvultZoxmbfzUBdFFOzCxlzesgZgUiUDRiSQivi0M3MVa8h3+EjFHetyNj0jnlJcwCJ8fTfjF9xopUmvmNIShv3p545zKoH5RpGoZbydpQZBZ7De9Rx28K4BGlPD7pWxcRcQkwScS+pswSt0ctF1bndfLTDILNtc2ikheV7qD/9cj5LMxez6A1+97zDwWWSfVVTJ2AkCUd6NyxEKc9Vahou827Py5jgp6Ps3wOKMudzPK/9GmnaaZZV6BIIMAloFEAyc3Je0eQIFPp5MArvexeQSbLl05WLTUYbWZviSWSJihjvw3JXxIyaPARZBdzG//19j2w4ViJXSraE5sp0eiH X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Microsoft-Antispam-PRVS: <CY1PR02MB1334819F0F4C624696DADF80D6E00@CY1PR02MB1334.namprd02.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(3002001)(93006095)(93004095)(10201501046)(3231023)(2400081)(944501161)(6055026)(6041288)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(6072148)(201708071742011); SRVR:CY1PR02MB1334; BCL:0; PCL:0; RULEID:; SRVR:CY1PR02MB1334; X-Microsoft-Exchange-Diagnostics: 1; CY1PR02MB1334; 4:9tQCREV+3X+sVIfBXT9U4n8IZEOAItYB6IVPl7itQit8PKJpbCLZ3I+v0T3IG0Zd3goLyJO18qyGoGXfky2dOy+nu6Qxuwp/8ZlWEX4KMJ2fCNtVJZGPWA9Vw0qucKlEWMMlXVKSJjgFRrZsnsKc71en4Z54HbzdrIIrmiA2X3sijS6NuFxDLmMkNU8UHy3MaeKo9CeiwHG+pAaxK9EkRK9L1ZasyhrtbGiP5QBPz1JMevOiIyPJqc3LF9Wclnebebw1ph4bWVa4l04LVZfayG9BrXwBNtfhtsK1Xi+yKur+qKSz3Uz5/T9LGNAbZUnr X-Forefront-PRVS: 05641FD966 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR02MB1334; 23:TNkn+05wlsxCZtg+ergUsrWgWfZlZjOuZmF+eq4nq?= =?us-ascii?Q?rcgxlIjApgj800EHMjdvNnaUdzs16vXgTQw81ZT0Hv5kJzvqSXnAvZGhZhgq?= =?us-ascii?Q?hb1UHMwp++KKa6Oyc4XdKE8eiHiSZVBwZmctfYsURCrxjSo90cCwSNlua6qA?= =?us-ascii?Q?uTSJtOYQaUdRqidDK3yBJm3JPkfDq0rLsST8ApSLs62tY6P7ab4DOqJHBdhh?= =?us-ascii?Q?3PPaYEkqC+KnPdadn7rzaTBurDiYj7oLBF2CSQ1hTjqvR4wB6FkKUCcYg0jT?= =?us-ascii?Q?33kCKAuQRcsf0JPTPWcZl1xLs9N5mC/Tp09meXqXFz9tDN32wM+OKeC14827?= =?us-ascii?Q?oB9QtlQ/vqiQc+a+DjhNDEVlGACrRvLSn3yRF6G4fSscOpv7vHzSOLpkpp6y?= =?us-ascii?Q?74OQQl79A5RrS5flaEZOoQPWu6DILWk8Ruxz3j/6ID/ahALBnhRS7J3dO9/i?= =?us-ascii?Q?EaUC6R8IoseInYA69aTW2dxvRz4mRAuEMk1pDWsTILZr4VY9eylLbZsxGnKS?= =?us-ascii?Q?oXp7yAajGP9ZSM2bxSsgjPioI575RcpAWSYSSxRTyA1WztxLdj0yj7YU+W6j?= =?us-ascii?Q?IbbuPRtDNQrzlUR7FHQw6UbCIKzyIo8JJ8a/l2tqrEA9bJsmh7xSUhJqw902?= =?us-ascii?Q?Ox1m6sBzLCv0bquzTeOKv5MbkMdOowW41BRopHDRz9zcWFUuptKAOVFhC9o2?= =?us-ascii?Q?y42C0RZwmIxQNtEDQFD+E7GdQByQGq+4tDKhekaKjNu/TAC+AFPAR+InH3wH?= =?us-ascii?Q?4LueM+iFRAlVokmq3baWgB8ZBiFWVlXJGFWnZGgFLKzr6N8hofFv2TnwGhIc?= =?us-ascii?Q?DYMhP/84sl/RG9lUQmdToVMn8UPgK4uDzWtdyxcXBhwHAO0toUYtqvbhzw9t?= =?us-ascii?Q?VHdZ/8fIYo8ud0y4GJGlqwhFj3uTNjn2bE6NKGQ0Vh+sILf1/bLhRXo4ucUS?= =?us-ascii?Q?P9fFfBEb69axLWGej6o4NfLEIraLEkqH6ZnfIQ29wgIGbZ0apOienqa4NpWt?= =?us-ascii?Q?/VOg2vV6qxd6kN66VrYJNn/yIWlzCVAVaeS5+iRJUuOClS8f4h2Fd/kt4bQS?= =?us-ascii?Q?ulBceDVvjkR+W1v/cSCmPUYX8oM3K2F3IewtmGzJlBG230cpl8cxv+nUMFcB?= =?us-ascii?Q?EGT3oSgRB0=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR02MB1334; 6:eCBPPNwF2SAHsBP7bX3EVTvFYuGUNNOohnmcVWo1W5Es6yxzkDb0Urwx+8zxBIXIHxy9M5LgBUXrBmjv7mVai8sW2mIA2PHOvLIE4paLUvoXRoQAEPikxUTYl0W7oLTFDLkRv058Xg40fKzh4lXpVYOuthPtHjqkc2IiTOetsnbuzEQk8pUvruVXXVAjXVkRsvcPEl4vuQUKT7qw2YIeqMekBHFvmFjg8j4Db1U6T582lPolDrxLFKR7NAPB8U/ktczMY0JRIbl4Hx/TaDkwZd6+/lq61B9JuyxVi2hphPpJutPBFDJKkgDVG2obnVe53hoY+IYh2DNS87QUX839HRDL+HuN/oNFc5c8ZsOE3qY=; 5:AhzszDoxojdKCLSPKojVELEAnJVnc8S4r24nTHKmJ+j0RFsClx+gi5m8LvhkADoLgowHytxMNIncQ1GYhI8NFqhY0HeVtT1d6a2r2iI7t6MQhsTw80PgSqGaH6IkWH4lyQd1cE/XUsnvjkOL6AU8DP9MpZ0UAGZItgYfIbgCBWw=; 24:7Mp91X4JSo+IFiefmoTnBEm3VpmRCi9HIvXPcJHD79No29f6wIiyZ+Eb+zpyRZ3ZnfTVLXIRtEVeoUytA9aKZOPw4KnvZXpDyGX6d2YjqW0=; 7:Vl68YypR2BODF1el5tHzCvNR8guuUFnpXbhO7ITpZrXsLrRilc8smwceeLb4snIVxRJGZRpul7h2B0AurS1GVnSFQ7oLTzT9yWAIvqevfUxATj83vQ/heWdgqQfplJDx6MoGjX5NeGSR+dZFgk2eMPuQPedmJu+jZn5W2Qb5zBJm4szOAB96cWup2cFX0mpt5NuAZYH0Tw4S+aei+J06xnbGv7OqZYC4dgPOxNIYM5jtk9GCSPYfaDvPLbAxdepC SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2018 02:04:16.4106 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bba9085f-f457-4380-d5a5-08d564611abc X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.83]; Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR02MB1334 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development <dri-devel.lists.freedesktop.org> List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>, <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe> List-Archive: <https://lists.freedesktop.org/archives/dri-devel> List-Post: <mailto:dri-devel@lists.freedesktop.org> List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help> List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>, <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe> Cc: Hyun Kwon <hyun.kwon@xilinx.com>, Daniel Vetter <daniel.vetter@ffwll.ch>, Emil Velikov <emil.l.velikov@gmail.com>, Michal Simek <michal.simek@xilinx.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org> X-Virus-Scanned: ClamAV using ClamSMTP |
diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c index 186d00a..271175e 100644 --- a/drivers/gpu/drm/drm_fb_cma_helper.c +++ b/drivers/gpu/drm/drm_fb_cma_helper.c @@ -124,7 +124,8 @@ dma_addr_t drm_fb_cma_get_gem_addr(struct drm_framebuffer *fb, return 0; paddr = obj->paddr + fb->offsets[plane]; - paddr += fb->format->cpp[plane] * (state->src_x >> 16); + paddr += drm_format_plane_width_bytes(fb->format, plane, + state->src_x >> 16); paddr += fb->pitches[plane] * (state->src_y >> 16); return paddr;
In order to handle non byte aligned formats, use drm_format_plane_width_bytes(). Use of 'cpp' can result in incorrect number of bytes from bit level rounding. Signed-off-by: Hyun Kwon <hyun.kwon@xilinx.com> --- v2 - This patch is added. --- --- drivers/gpu/drm/drm_fb_cma_helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)