Message ID | 1519689860-7421-2-git-send-email-keescook@chromium.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <dri-devel-bounces@lists.freedesktop.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 51DBD60211 for <patchwork-dri-devel@patchwork.kernel.org>; Tue, 27 Feb 2018 08:56:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 457822A545 for <patchwork-dri-devel@patchwork.kernel.org>; Tue, 27 Feb 2018 08:56:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3A30C2A5CC; Tue, 27 Feb 2018 08:56:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id BBA482A545 for <patchwork-dri-devel@patchwork.kernel.org>; Tue, 27 Feb 2018 08:56:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5229B6E60C; Tue, 27 Feb 2018 08:56:05 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pg0-x242.google.com (mail-pg0-x242.google.com [IPv6:2607:f8b0:400e:c05::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id E8E426E571 for <dri-devel@lists.freedesktop.org>; Tue, 27 Feb 2018 00:04:29 +0000 (UTC) Received: by mail-pg0-x242.google.com with SMTP id e9so2501391pgs.10 for <dri-devel@lists.freedesktop.org>; Mon, 26 Feb 2018 16:04:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=YkbTZUnKK79uTL4ubxkilDrq9E2x+xrlbCGIag8e3uc=; b=dilLDk/1igqzx8GwW0gnQv2k7GJjMTZyHDb1JWMDW6p784FQJwt1YPMVAIssFlDsfi zklQ9mOnQGx4dspU2+s+i0dgm75+Frz3tYvowyeH8ouqbFNijDYu55pAGqrEgf7N9WJp NE3vfreSBMmzVy45sAbReGO33i+MuThcUMqqE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=YkbTZUnKK79uTL4ubxkilDrq9E2x+xrlbCGIag8e3uc=; b=fJ32IidRLEjKh4inUTtx2C9q0mlSbsaAdQrBSfNg5ZSbI8PjlUIR7nN7jQPwzT8rqd txjberGnNZ0UCb+p42dp4oaJrLDQnHVT/EOwPKrQqaDipKhTDCMgOQngYLFoc7Rf2DtI jgIuUyeJtzdqsPCo0OBR9yernnuK+jEeXKIVSnZ7yJAAgKh7eRaD4PnKlepHBiIIU2Ds g6VOdMt+o719xoG22ba+pUvk/sZceDHruB93V/VX5kWdvkYJISFop9Sb5Np7/OJXsYgu eXjHTyNC29gwJ/+APcloX6oYvzpbb+3wWFOG1u2DKLDsek9T6xnFFL/am//hJWsBqvld d/Sw== X-Gm-Message-State: APf1xPBpgD+vtPYYpR1XfYpzWpcONVjs++V4f0Ehu/Uh9WWz56PpOGuk oUw5fCtQaVd7LDdv2P9p+WmCuA== X-Google-Smtp-Source: AH8x225DZnPH69ivn88Z8Ty50ojAgav9QLgiG8dhNxhQ5R3D8Q90QMy7+8hpm/0xFfrq1YNXDAs8sg== X-Received: by 10.101.96.73 with SMTP id b9mr9256413pgv.339.1519689869383; Mon, 26 Feb 2018 16:04:29 -0800 (PST) Received: from www.outflux.net (173-164-112-133-Oregon.hfc.comcastbusiness.net. [173.164.112.133]) by smtp.gmail.com with ESMTPSA id c18sm22276234pfd.100.2018.02.26.16.04.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Feb 2018 16:04:27 -0800 (PST) From: Kees Cook <keescook@chromium.org> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Subject: [PATCH 1/3] console: SisUSB2VGA: Drop dummy con_font_get() Date: Mon, 26 Feb 2018 16:04:18 -0800 Message-Id: <1519689860-7421-2-git-send-email-keescook@chromium.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1519689860-7421-1-git-send-email-keescook@chromium.org> References: <1519689860-7421-1-git-send-email-keescook@chromium.org> X-Mailman-Approved-At: Tue, 27 Feb 2018 08:56:02 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development <dri-devel.lists.freedesktop.org> List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>, <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe> List-Archive: <https://lists.freedesktop.org/archives/dri-devel> List-Post: <mailto:dri-devel@lists.freedesktop.org> List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help> List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>, <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe> Cc: Nicolas Pitre <nicolas.pitre@linaro.org>, linux-fbdev@vger.kernel.org, Thomas Winischhofer <thomas@winischhofer.net>, Kees Cook <keescook@chromium.org>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Sami Tolvanen <samitolvanen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org> X-Virus-Scanned: ClamAV using ClamSMTP |
diff --git a/drivers/usb/misc/sisusbvga/sisusb_con.c b/drivers/usb/misc/sisusbvga/sisusb_con.c index 73f7bde78e11..998df891bdde 100644 --- a/drivers/usb/misc/sisusbvga/sisusb_con.c +++ b/drivers/usb/misc/sisusbvga/sisusb_con.c @@ -1358,7 +1358,6 @@ static const struct consw sisusb_dummy_con = { .con_switch = SISUSBCONDUMMY, .con_blank = SISUSBCONDUMMY, .con_font_set = SISUSBCONDUMMY, - .con_font_get = SISUSBCONDUMMY, .con_font_default = SISUSBCONDUMMY, .con_font_copy = SISUSBCONDUMMY, };
As done in commit: 724ba8b30b04 ("console/dummy: leave .con_font_get set to NULL") This drops the dummy .con_font_get(), as it could leave arguments uninitialized. Cc: Thomas Winischhofer <thomas@winischhofer.net> Signed-off-by: Kees Cook <keescook@chromium.org> --- drivers/usb/misc/sisusbvga/sisusb_con.c | 1 - 1 file changed, 1 deletion(-)