| Message ID | 1523596981-18913-3-git-send-email-spanda@codeaurora.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Apr 13, 2018 at 1:23 AM Sandeep Panda <spanda@codeaurora.org> wrote: > Document the bindings used for the sn65dsi86 DSI to eDP bridge. > Signed-off-by: Sandeep Panda <spanda@codeaurora.org> > --- > .../bindings/display/bridge/ti,sn65dsi86.txt | 75 ++++++++++++++++++++++ > 1 file changed, 75 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt > diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt > new file mode 100644 > index 0000000..cbd2f0e > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt > @@ -0,0 +1,75 @@ > +SN65DSI86 DSI to eDP bridge chip > +-------------------------------- > + > +This is the binding for Texas Instruments SN65DSI86 bridge. > + > +Required properties: > +- compatible: Must be "ti,sn65dsi86" > +- reg: i2c address of the chip, 0x2d as per datasheet > +- enable-gpios: OF device-tree gpio specification for EDP_BRIJ_EN pin > +- aux-sda-gpios: OF device-tree gpio specification for EDP_BRIJ_I2C_SDA pin of AUX channel > +- aux-scl-gpios: OF device-tree gpio specification for EDP_BRIJ_I2C_SCL pin of AUX channel > +- bias-en-gpios: OF device-tree gpio specification for EN_PP3300_DX_EDP pin to PP3300? > + enable 3.3V supply to eDP connector > +- bklt-en-gpios: OF device-tree gpio specification for AP_EDP_BKLTEN pin I don't see any of these pins listed in the SN65DSI86 datasheet. Can you please use the actual pin names? > + > +- vccio-supply: A 1.8V supply that powers up the PHY. > +- vcca-supply: A 1.2V supply that powers up the Controller. > +- vccs-supply: A 3.3V supply that power the eDP connector > + > +Optional properties: > + > +- irq-gpios: OF device-tree gpio specification for interrupt pin > +- bklt-ctrl-gpios: OF device-tree gpio specification for EDP_BKLTCTL pin Same comment here, this isn't listed in the datasheet > + > +- sn,is-pluggable: boolean property to specify if HPD supported or not Could you infer this from whether there's a panel present in the dts? > +- sn,custom-modes: OF device-tree specifiction to add support for custom modes Please drop custom-modes, it doesn't belong on the bridge. > + > +Required nodes: > + > +This device has two video ports. Their connections are modelled using the OF > +graph bindings specified in Documentation/devicetree/bindings/graph.txt. > + > +- Video port 0 for DSI input > +- Video port 1 for eDP output > + > +Example > +------- > + > +edp-bridge@2d { > + compatible = "ti,sn65dsi86"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x2d>; > + > + enable-gpios = <&msmgpio 33 GPIO_ACTIVE_HIGH>; > + aux-sda-gpios = <&msmgpio 34 GPIO_ACTIVE_HIGH>; > + aux-scl-gpios = <&msmgpio 35 GPIO_ACTIVE_HIGH>; > + bias-en-gpios = <&msmgpio 36 GPIO_ACTIVE_HIGH>; > + bklt-en-gpios = <&msmgpio 37 GPIO_ACTIVE_HIGH>; > + > + vccio-supply = <&pm8916_l17>; > + vcca-supply = <&pm8916_l6>; > + vccs-supply = <&pm8916_l7>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + edp_bridge_in: endpoint { > + remote-endpoint = <&dsi_out>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + > + edp_bridge_out: endpoint { > + remote-endpoint = <&edp_panel_in>; > + }; > + }; > + }; > +} > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project
On Fri, Apr 13, 2018 at 10:53:01AM +0530, Sandeep Panda wrote: > Document the bindings used for the sn65dsi86 DSI to eDP bridge. > > Signed-off-by: Sandeep Panda <spanda@codeaurora.org> > --- > .../bindings/display/bridge/ti,sn65dsi86.txt | 75 ++++++++++++++++++++++ > 1 file changed, 75 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt > > diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt > new file mode 100644 > index 0000000..cbd2f0e > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt > @@ -0,0 +1,75 @@ > +SN65DSI86 DSI to eDP bridge chip > +-------------------------------- > + > +This is the binding for Texas Instruments SN65DSI86 bridge. > + > +Required properties: > +- compatible: Must be "ti,sn65dsi86" > +- reg: i2c address of the chip, 0x2d as per datasheet > +- enable-gpios: OF device-tree gpio specification for EDP_BRIJ_EN pin > +- aux-sda-gpios: OF device-tree gpio specification for EDP_BRIJ_I2C_SDA pin of AUX channel > +- aux-scl-gpios: OF device-tree gpio specification for EDP_BRIJ_I2C_SCL pin of AUX channel What if I use I2C host on my device? If your board design uses bitbanged I2C, that is outside the scope of this binding and it should use i2c-gpio binding. > +- bias-en-gpios: OF device-tree gpio specification for EN_PP3300_DX_EDP pin to > + enable 3.3V supply to eDP connector > +- bklt-en-gpios: OF device-tree gpio specification for AP_EDP_BKLTEN pin > + > +- vccio-supply: A 1.8V supply that powers up the PHY. > +- vcca-supply: A 1.2V supply that powers up the Controller. > +- vccs-supply: A 3.3V supply that power the eDP connector > + > +Optional properties: > + > +- irq-gpios: OF device-tree gpio specification for interrupt pin Use "interrupts" property instead. > +- bklt-ctrl-gpios: OF device-tree gpio specification for EDP_BKLTCTL pin > + > +- sn,is-pluggable: boolean property to specify if HPD supported or not > +- sn,custom-modes: OF device-tree specifiction to add support for custom modes "sn" is not a vendor. > + > +Required nodes: > + > +This device has two video ports. Their connections are modelled using the OF > +graph bindings specified in Documentation/devicetree/bindings/graph.txt. > + > +- Video port 0 for DSI input > +- Video port 1 for eDP output > + > +Example > +------- > + > +edp-bridge@2d { > + compatible = "ti,sn65dsi86"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x2d>; > + > + enable-gpios = <&msmgpio 33 GPIO_ACTIVE_HIGH>; > + aux-sda-gpios = <&msmgpio 34 GPIO_ACTIVE_HIGH>; > + aux-scl-gpios = <&msmgpio 35 GPIO_ACTIVE_HIGH>; > + bias-en-gpios = <&msmgpio 36 GPIO_ACTIVE_HIGH>; > + bklt-en-gpios = <&msmgpio 37 GPIO_ACTIVE_HIGH>; > + > + vccio-supply = <&pm8916_l17>; > + vcca-supply = <&pm8916_l6>; > + vccs-supply = <&pm8916_l7>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + edp_bridge_in: endpoint { > + remote-endpoint = <&dsi_out>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + > + edp_bridge_out: endpoint { > + remote-endpoint = <&edp_panel_in>; > + }; > + }; > + }; > +} > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt new file mode 100644 index 0000000..cbd2f0e --- /dev/null +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt @@ -0,0 +1,75 @@ +SN65DSI86 DSI to eDP bridge chip +-------------------------------- + +This is the binding for Texas Instruments SN65DSI86 bridge. + +Required properties: +- compatible: Must be "ti,sn65dsi86" +- reg: i2c address of the chip, 0x2d as per datasheet +- enable-gpios: OF device-tree gpio specification for EDP_BRIJ_EN pin +- aux-sda-gpios: OF device-tree gpio specification for EDP_BRIJ_I2C_SDA pin of AUX channel +- aux-scl-gpios: OF device-tree gpio specification for EDP_BRIJ_I2C_SCL pin of AUX channel +- bias-en-gpios: OF device-tree gpio specification for EN_PP3300_DX_EDP pin to + enable 3.3V supply to eDP connector +- bklt-en-gpios: OF device-tree gpio specification for AP_EDP_BKLTEN pin + +- vccio-supply: A 1.8V supply that powers up the PHY. +- vcca-supply: A 1.2V supply that powers up the Controller. +- vccs-supply: A 3.3V supply that power the eDP connector + +Optional properties: + +- irq-gpios: OF device-tree gpio specification for interrupt pin +- bklt-ctrl-gpios: OF device-tree gpio specification for EDP_BKLTCTL pin + +- sn,is-pluggable: boolean property to specify if HPD supported or not +- sn,custom-modes: OF device-tree specifiction to add support for custom modes + +Required nodes: + +This device has two video ports. Their connections are modelled using the OF +graph bindings specified in Documentation/devicetree/bindings/graph.txt. + +- Video port 0 for DSI input +- Video port 1 for eDP output + +Example +------- + +edp-bridge@2d { + compatible = "ti,sn65dsi86"; + #address-cells = <1>; + #size-cells = <0>; + reg = <0x2d>; + + enable-gpios = <&msmgpio 33 GPIO_ACTIVE_HIGH>; + aux-sda-gpios = <&msmgpio 34 GPIO_ACTIVE_HIGH>; + aux-scl-gpios = <&msmgpio 35 GPIO_ACTIVE_HIGH>; + bias-en-gpios = <&msmgpio 36 GPIO_ACTIVE_HIGH>; + bklt-en-gpios = <&msmgpio 37 GPIO_ACTIVE_HIGH>; + + vccio-supply = <&pm8916_l17>; + vcca-supply = <&pm8916_l6>; + vccs-supply = <&pm8916_l7>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + + edp_bridge_in: endpoint { + remote-endpoint = <&dsi_out>; + }; + }; + + port@1 { + reg = <1>; + + edp_bridge_out: endpoint { + remote-endpoint = <&edp_panel_in>; + }; + }; + }; +}
Document the bindings used for the sn65dsi86 DSI to eDP bridge. Signed-off-by: Sandeep Panda <spanda@codeaurora.org> --- .../bindings/display/bridge/ti,sn65dsi86.txt | 75 ++++++++++++++++++++++ 1 file changed, 75 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt