From patchwork Thu Apr 19 09:31:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 10351979 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 27C16602B7 for ; Fri, 20 Apr 2018 07:34:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 136C22823D for ; Fri, 20 Apr 2018 07:34:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F17AB286A1; Fri, 20 Apr 2018 07:34:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8F62F2823D for ; Fri, 20 Apr 2018 07:34:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5D1C66E1A9; Fri, 20 Apr 2018 07:33:01 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by gabe.freedesktop.org (Postfix) with ESMTPS id A0D6C6E611 for ; Thu, 19 Apr 2018 09:31:41 +0000 (UTC) X-Originating-IP: 2.224.242.101 Received: from w540.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101]) (Authenticated sender: jacopo@jmondi.org) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id D31F560046; Thu, 19 Apr 2018 11:31:37 +0200 (CEST) From: Jacopo Mondi To: architt@codeaurora.org, a.hajda@samsung.com, Laurent.pinchart@ideasonboard.com, airlied@linux.ie Subject: [PATCH 7/8] drm: panel: Use _LE LVDS formats for data mirroring Date: Thu, 19 Apr 2018 11:31:08 +0200 Message-Id: <1524130269-32688-8-git-send-email-jacopo+renesas@jmondi.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1524130269-32688-1-git-send-email-jacopo+renesas@jmondi.org> References: <1524130269-32688-1-git-send-email-jacopo+renesas@jmondi.org> X-Mailman-Approved-At: Fri, 20 Apr 2018 07:31:50 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Jacopo Mondi , peda@axentia.se, linux-media@vger.kernel.org MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP As now both bridges and panels report supported image formats, use the newly introduced _LE version of LVDS media bus formats in place of the DRM_BUS_FLAG_DATA_ flags defined in drm_connector.h Signed-off-by: Jacopo Mondi --- drivers/gpu/drm/panel/panel-lvds.c | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-lvds.c b/drivers/gpu/drm/panel/panel-lvds.c index 5185819..ac03eab 100644 --- a/drivers/gpu/drm/panel/panel-lvds.c +++ b/drivers/gpu/drm/panel/panel-lvds.c @@ -37,7 +37,6 @@ struct panel_lvds { unsigned int height; struct videomode video_mode; unsigned int bus_format; - bool data_mirror; struct backlight_device *backlight; struct regulator *supply; @@ -129,9 +128,6 @@ static int panel_lvds_get_modes(struct drm_panel *panel) connector->display_info.height_mm = lvds->height; drm_display_info_set_bus_formats(&connector->display_info, &lvds->bus_format, 1); - connector->display_info.bus_flags = lvds->data_mirror - ? DRM_BUS_FLAG_DATA_LSB_TO_MSB - : DRM_BUS_FLAG_DATA_MSB_TO_LSB; return 1; } @@ -149,6 +145,7 @@ static int panel_lvds_parse_dt(struct panel_lvds *lvds) struct device_node *np = lvds->dev->of_node; struct display_timing timing; const char *mapping; + bool data_mirror; int ret; ret = of_get_display_timing(np, "panel-timing", &timing); @@ -179,20 +176,26 @@ static int panel_lvds_parse_dt(struct panel_lvds *lvds) return -ENODEV; } + data_mirror = of_property_read_bool(np, "data-mirror"); + if (!strcmp(mapping, "jeida-18")) { - lvds->bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG; + lvds->bus_format = data_mirror ? + MEDIA_BUS_FMT_RGB666_1X7X3_SPWG_LE : + MEDIA_BUS_FMT_RGB666_1X7X3_SPWG; } else if (!strcmp(mapping, "jeida-24")) { - lvds->bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA; + lvds->bus_format = data_mirror ? + MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA_LE : + MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA; } else if (!strcmp(mapping, "vesa-24")) { - lvds->bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG; + lvds->bus_format = data_mirror ? + MEDIA_BUS_FMT_RGB888_1X7X4_SPWG_LE : + MEDIA_BUS_FMT_RGB888_1X7X4_SPWG; } else { dev_err(lvds->dev, "%pOF: invalid or missing %s DT property\n", np, "data-mapping"); return -EINVAL; } - lvds->data_mirror = of_property_read_bool(np, "data-mirror"); - return 0; }