| Message ID | 1526903890-35761-21-git-send-email-xieyisheng1@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, May 21, 2018 at 2:57 PM, Yisheng Xie <xieyisheng1@huawei.com> wrote: > match_string() returns the index of an array for a matching string, > which can be used intead of open coded variant. https://patchwork.kernel.org/patch/10378815/ > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > Cc: Arvind Yadav <arvind.yadav.cs@gmail.com> > Cc: dri-devel@lists.freedesktop.org > linux-fbdev@vger.kernel.org
diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c index c3d49e1..702193d 100644 --- a/drivers/video/fbdev/pxafb.c +++ b/drivers/video/fbdev/pxafb.c @@ -2115,10 +2115,8 @@ static int of_get_pxafb_display(struct device *dev, struct device_node *disp, if (ret) s = "color-tft"; - for (i = 0; lcd_types[i]; i++) - if (!strcmp(s, lcd_types[i])) - break; - if (!i || !lcd_types[i]) { + i = match_string(lcd_types, -1, s); + if (i <= 0) { dev_err(dev, "lcd-type %s is unknown\n", s); return -EINVAL; }
match_string() returns the index of an array for a matching string, which can be used intead of open coded variant. Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Cc: Arvind Yadav <arvind.yadav.cs@gmail.com> Cc: dri-devel@lists.freedesktop.org linux-fbdev@vger.kernel.org Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com> --- drivers/video/fbdev/pxafb.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)