Message ID | 1535015911-2040-3-git-send-email-smasetty@codeaurora.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | msm/drm: A6x DCVS series | expand |
On Thu, Aug 23, 2018 at 02:48:28PM +0530, Sharat Masetty wrote: > Call the devfreq_remove_device() API to remove the GPU devfreq instance > during GPU driver cleanup. > > Signed-off-by: Sharat Masetty <smasetty@codeaurora.org> > --- > drivers/gpu/drm/msm/msm_gpu.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c > index 04f9604..83fd602 100644 > --- a/drivers/gpu/drm/msm/msm_gpu.c > +++ b/drivers/gpu/drm/msm/msm_gpu.c > @@ -970,6 +970,8 @@ void msm_gpu_cleanup(struct msm_gpu *gpu) > > WARN_ON(!list_empty(&gpu->active_list)); > > + devfreq_remove_device(gpu->devfreq.devfreq); > + Because everything eventually gets a devm_ wrapper we do have devm_devfreq_add_device() - maybe that would be a better solution? Jordan > for (i = 0; i < ARRAY_SIZE(gpu->rb); i++) { > msm_ringbuffer_destroy(gpu->rb[i]); > gpu->rb[i] = NULL; > -- > 1.9.1 >
diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c index 04f9604..83fd602 100644 --- a/drivers/gpu/drm/msm/msm_gpu.c +++ b/drivers/gpu/drm/msm/msm_gpu.c @@ -970,6 +970,8 @@ void msm_gpu_cleanup(struct msm_gpu *gpu) WARN_ON(!list_empty(&gpu->active_list)); + devfreq_remove_device(gpu->devfreq.devfreq); + for (i = 0; i < ARRAY_SIZE(gpu->rb); i++) { msm_ringbuffer_destroy(gpu->rb[i]); gpu->rb[i] = NULL;
Call the devfreq_remove_device() API to remove the GPU devfreq instance during GPU driver cleanup. Signed-off-by: Sharat Masetty <smasetty@codeaurora.org> --- drivers/gpu/drm/msm/msm_gpu.c | 2 ++ 1 file changed, 2 insertions(+)