| Message ID | 1543836703-8491-7-git-send-email-ayan.halder@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add support for Arm Framebuffer Compression(AFBC) in mali display driver | expand |
On Mon, Dec 03, 2018 at 11:32:00AM +0000, Ayan Halder wrote: > We have added some new formats to be supported on DP500/DP550/DP650. Make a bit more descriptive commit message here, please! > > Signed-off-by: Ayan Kumar Halder <ayan.halder@arm.com> > > Depends on :- https://patchwork.kernel.org/patch/10460063/ Reviewed-by: Liviu Dudau <liviu.dudau@arm.com> Best regards, Liviu > --- > drivers/gpu/drm/arm/malidp_hw.c | 22 +++++++++++++++++++++- > 1 file changed, 21 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/arm/malidp_hw.c b/drivers/gpu/drm/arm/malidp_hw.c > index 55d379b..25ac5890 100644 > --- a/drivers/gpu/drm/arm/malidp_hw.c > +++ b/drivers/gpu/drm/arm/malidp_hw.c > @@ -49,6 +49,12 @@ static const struct malidp_format_id malidp500_de_formats[] = { > { DRM_FORMAT_YUYV, DE_VIDEO1, 13 }, > { DRM_FORMAT_NV12, DE_VIDEO1 | SE_MEMWRITE, 14 }, > { DRM_FORMAT_YUV420, DE_VIDEO1, 15 }, > + { DRM_FORMAT_XYUV8888, DE_VIDEO1, 16 }, > + /* These are supported with AFBC only */ > + { DRM_FORMAT_YUV420_8BIT, DE_VIDEO1, 14 }, > + { DRM_FORMAT_VUY888, DE_VIDEO1, 16 }, > + { DRM_FORMAT_VUY101010, DE_VIDEO1, 17 }, > + { DRM_FORMAT_YUV420_10BIT, DE_VIDEO1, 18 } > }; > > #define MALIDP_ID(__group, __format) \ > @@ -74,11 +80,25 @@ static const struct malidp_format_id malidp500_de_formats[] = { > { DRM_FORMAT_ABGR1555, DE_VIDEO1 | DE_GRAPHICS1 | DE_VIDEO2, MALIDP_ID(4, 1) }, \ > { DRM_FORMAT_RGB565, DE_VIDEO1 | DE_GRAPHICS1 | DE_VIDEO2, MALIDP_ID(4, 2) }, \ > { DRM_FORMAT_BGR565, DE_VIDEO1 | DE_GRAPHICS1 | DE_VIDEO2, MALIDP_ID(4, 3) }, \ > + /* This is only supported with linear modifier */ \ > + { DRM_FORMAT_XYUV8888, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(5, 0) },\ > + /* This is only supported with AFBC modifier */ \ > + { DRM_FORMAT_VUY888, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(5, 0) }, \ > { DRM_FORMAT_YUYV, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(5, 2) }, \ > + /* This is only supported with linear modifier */ \ > { DRM_FORMAT_UYVY, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(5, 3) }, \ > { DRM_FORMAT_NV12, DE_VIDEO1 | DE_VIDEO2 | SE_MEMWRITE, MALIDP_ID(5, 6) }, \ > + /* This is only supported with AFBC modifier */ \ > + { DRM_FORMAT_YUV420_8BIT, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(5, 6) }, \ > { DRM_FORMAT_YUV420, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(5, 7) }, \ > - { DRM_FORMAT_X0L2, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(6, 6)} > + /* This is only supported with linear modifier */ \ > + { DRM_FORMAT_XVYU2101010, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(6, 0)}, \ > + /* This is only supported with AFBC modifier */ \ > + { DRM_FORMAT_VUY101010, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(6, 0)}, \ > + { DRM_FORMAT_X0L2, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(6, 6)}, \ > + /* This is only supported with AFBC modifier */ \ > + { DRM_FORMAT_YUV420_10BIT, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(6, 7)}, \ > + { DRM_FORMAT_P010, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(6, 7)} > > static const struct malidp_format_id malidp550_de_formats[] = { > MALIDP_COMMON_FORMATS, > -- > 2.7.4 >
On Tue, Dec 04, 2018 at 04:57:46PM +0000, Liviu Dudau wrote: Hi Liviu, > On Mon, Dec 03, 2018 at 11:32:00AM +0000, Ayan Halder wrote: > > We have added some new formats to be supported on DP500/DP550/DP650. > > Make a bit more descriptive commit message here, please! > I will keep the following commit message :- ""We have added support for some AFBC only pixel formats like :- DRM_FORMAT_YUV420_8BIT (single plane YUV 420 8 bit format) DRM_FORMAT_VUY888 (single plane YUV 444 8 bit format) DRM_FORMAT_VUY101010 (single plane YUV 444 10 bit format) DRM_FORMAT_YUV420_10BIT (single plane YUV 420 10 bit format) Generally, these formats are supported by our hardware using the same hw-ids as the equivalent multi plane pixel formats. Also we have added support for XYUV 444 8 and 10 bit formats."" Let me know if this looks fine. Thanks, Ayan Kumar halder > > > > Signed-off-by: Ayan Kumar Halder <ayan.halder@arm.com> > > > > Depends on :- https://patchwork.kernel.org/patch/10460063/ > > Reviewed-by: Liviu Dudau <liviu.dudau@arm.com> > > Best regards, > Liviu > > > --- > > drivers/gpu/drm/arm/malidp_hw.c | 22 +++++++++++++++++++++- > > 1 file changed, 21 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/arm/malidp_hw.c b/drivers/gpu/drm/arm/malidp_hw.c > > index 55d379b..25ac5890 100644 > > --- a/drivers/gpu/drm/arm/malidp_hw.c > > +++ b/drivers/gpu/drm/arm/malidp_hw.c > > @@ -49,6 +49,12 @@ static const struct malidp_format_id malidp500_de_formats[] = { > > { DRM_FORMAT_YUYV, DE_VIDEO1, 13 }, > > { DRM_FORMAT_NV12, DE_VIDEO1 | SE_MEMWRITE, 14 }, > > { DRM_FORMAT_YUV420, DE_VIDEO1, 15 }, > > + { DRM_FORMAT_XYUV8888, DE_VIDEO1, 16 }, > > + /* These are supported with AFBC only */ > > + { DRM_FORMAT_YUV420_8BIT, DE_VIDEO1, 14 }, > > + { DRM_FORMAT_VUY888, DE_VIDEO1, 16 }, > > + { DRM_FORMAT_VUY101010, DE_VIDEO1, 17 }, > > + { DRM_FORMAT_YUV420_10BIT, DE_VIDEO1, 18 } > > }; > > > > #define MALIDP_ID(__group, __format) \ > > @@ -74,11 +80,25 @@ static const struct malidp_format_id malidp500_de_formats[] = { > > { DRM_FORMAT_ABGR1555, DE_VIDEO1 | DE_GRAPHICS1 | DE_VIDEO2, MALIDP_ID(4, 1) }, \ > > { DRM_FORMAT_RGB565, DE_VIDEO1 | DE_GRAPHICS1 | DE_VIDEO2, MALIDP_ID(4, 2) }, \ > > { DRM_FORMAT_BGR565, DE_VIDEO1 | DE_GRAPHICS1 | DE_VIDEO2, MALIDP_ID(4, 3) }, \ > > + /* This is only supported with linear modifier */ \ > > + { DRM_FORMAT_XYUV8888, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(5, 0) },\ > > + /* This is only supported with AFBC modifier */ \ > > + { DRM_FORMAT_VUY888, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(5, 0) }, \ > > { DRM_FORMAT_YUYV, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(5, 2) }, \ > > + /* This is only supported with linear modifier */ \ > > { DRM_FORMAT_UYVY, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(5, 3) }, \ > > { DRM_FORMAT_NV12, DE_VIDEO1 | DE_VIDEO2 | SE_MEMWRITE, MALIDP_ID(5, 6) }, \ > > + /* This is only supported with AFBC modifier */ \ > > + { DRM_FORMAT_YUV420_8BIT, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(5, 6) }, \ > > { DRM_FORMAT_YUV420, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(5, 7) }, \ > > - { DRM_FORMAT_X0L2, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(6, 6)} > > + /* This is only supported with linear modifier */ \ > > + { DRM_FORMAT_XVYU2101010, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(6, 0)}, \ > > + /* This is only supported with AFBC modifier */ \ > > + { DRM_FORMAT_VUY101010, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(6, 0)}, \ > > + { DRM_FORMAT_X0L2, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(6, 6)}, \ > > + /* This is only supported with AFBC modifier */ \ > > + { DRM_FORMAT_YUV420_10BIT, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(6, 7)}, \ > > + { DRM_FORMAT_P010, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(6, 7)} > > > > static const struct malidp_format_id malidp550_de_formats[] = { > > MALIDP_COMMON_FORMATS, > > -- > > 2.7.4 > > > > -- > ==================== > | I would like to | > | fix the world, | > | but they're not | > | giving me the | > \ source code! / > --------------- > ??\_(???)_/?? > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Fri, Dec 14, 2018 at 02:12:23PM +0000, Ayan Halder wrote: > On Tue, Dec 04, 2018 at 04:57:46PM +0000, Liviu Dudau wrote: > > Hi Liviu, > > On Mon, Dec 03, 2018 at 11:32:00AM +0000, Ayan Halder wrote: > > > We have added some new formats to be supported on DP500/DP550/DP650. > > > > Make a bit more descriptive commit message here, please! > > > I will keep the following commit message :- > > ""We have added support for some AFBC only pixel formats like :- > DRM_FORMAT_YUV420_8BIT (single plane YUV 420 8 bit format) > DRM_FORMAT_VUY888 (single plane YUV 444 8 bit format) > DRM_FORMAT_VUY101010 (single plane YUV 444 10 bit format) > DRM_FORMAT_YUV420_10BIT (single plane YUV 420 10 bit format) > > Generally, these formats are supported by our hardware using the same hw-ids as > the equivalent multi plane pixel formats. > > Also we have added support for XYUV 444 8 and 10 bit formats."" > > Let me know if this looks fine. Yes, LGTM. Best regards, Liviu > > Thanks, > Ayan Kumar halder > > > > > > Signed-off-by: Ayan Kumar Halder <ayan.halder@arm.com> > > > > > > Depends on :- https://patchwork.kernel.org/patch/10460063/ > > > > Reviewed-by: Liviu Dudau <liviu.dudau@arm.com> > > > > Best regards, > > Liviu > > > > > --- > > > drivers/gpu/drm/arm/malidp_hw.c | 22 +++++++++++++++++++++- > > > 1 file changed, 21 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/arm/malidp_hw.c b/drivers/gpu/drm/arm/malidp_hw.c > > > index 55d379b..25ac5890 100644 > > > --- a/drivers/gpu/drm/arm/malidp_hw.c > > > +++ b/drivers/gpu/drm/arm/malidp_hw.c > > > @@ -49,6 +49,12 @@ static const struct malidp_format_id malidp500_de_formats[] = { > > > { DRM_FORMAT_YUYV, DE_VIDEO1, 13 }, > > > { DRM_FORMAT_NV12, DE_VIDEO1 | SE_MEMWRITE, 14 }, > > > { DRM_FORMAT_YUV420, DE_VIDEO1, 15 }, > > > + { DRM_FORMAT_XYUV8888, DE_VIDEO1, 16 }, > > > + /* These are supported with AFBC only */ > > > + { DRM_FORMAT_YUV420_8BIT, DE_VIDEO1, 14 }, > > > + { DRM_FORMAT_VUY888, DE_VIDEO1, 16 }, > > > + { DRM_FORMAT_VUY101010, DE_VIDEO1, 17 }, > > > + { DRM_FORMAT_YUV420_10BIT, DE_VIDEO1, 18 } > > > }; > > > > > > #define MALIDP_ID(__group, __format) \ > > > @@ -74,11 +80,25 @@ static const struct malidp_format_id malidp500_de_formats[] = { > > > { DRM_FORMAT_ABGR1555, DE_VIDEO1 | DE_GRAPHICS1 | DE_VIDEO2, MALIDP_ID(4, 1) }, \ > > > { DRM_FORMAT_RGB565, DE_VIDEO1 | DE_GRAPHICS1 | DE_VIDEO2, MALIDP_ID(4, 2) }, \ > > > { DRM_FORMAT_BGR565, DE_VIDEO1 | DE_GRAPHICS1 | DE_VIDEO2, MALIDP_ID(4, 3) }, \ > > > + /* This is only supported with linear modifier */ \ > > > + { DRM_FORMAT_XYUV8888, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(5, 0) },\ > > > + /* This is only supported with AFBC modifier */ \ > > > + { DRM_FORMAT_VUY888, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(5, 0) }, \ > > > { DRM_FORMAT_YUYV, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(5, 2) }, \ > > > + /* This is only supported with linear modifier */ \ > > > { DRM_FORMAT_UYVY, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(5, 3) }, \ > > > { DRM_FORMAT_NV12, DE_VIDEO1 | DE_VIDEO2 | SE_MEMWRITE, MALIDP_ID(5, 6) }, \ > > > + /* This is only supported with AFBC modifier */ \ > > > + { DRM_FORMAT_YUV420_8BIT, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(5, 6) }, \ > > > { DRM_FORMAT_YUV420, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(5, 7) }, \ > > > - { DRM_FORMAT_X0L2, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(6, 6)} > > > + /* This is only supported with linear modifier */ \ > > > + { DRM_FORMAT_XVYU2101010, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(6, 0)}, \ > > > + /* This is only supported with AFBC modifier */ \ > > > + { DRM_FORMAT_VUY101010, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(6, 0)}, \ > > > + { DRM_FORMAT_X0L2, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(6, 6)}, \ > > > + /* This is only supported with AFBC modifier */ \ > > > + { DRM_FORMAT_YUV420_10BIT, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(6, 7)}, \ > > > + { DRM_FORMAT_P010, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(6, 7)} > > > > > > static const struct malidp_format_id malidp550_de_formats[] = { > > > MALIDP_COMMON_FORMATS, > > > -- > > > 2.7.4 > > > > > > > -- > > ==================== > > | I would like to | > > | fix the world, | > > | but they're not | > > | giving me the | > > \ source code! / > > --------------- > > ??\_(???)_/?? > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/arm/malidp_hw.c b/drivers/gpu/drm/arm/malidp_hw.c index 55d379b..25ac5890 100644 --- a/drivers/gpu/drm/arm/malidp_hw.c +++ b/drivers/gpu/drm/arm/malidp_hw.c @@ -49,6 +49,12 @@ static const struct malidp_format_id malidp500_de_formats[] = { { DRM_FORMAT_YUYV, DE_VIDEO1, 13 }, { DRM_FORMAT_NV12, DE_VIDEO1 | SE_MEMWRITE, 14 }, { DRM_FORMAT_YUV420, DE_VIDEO1, 15 }, + { DRM_FORMAT_XYUV8888, DE_VIDEO1, 16 }, + /* These are supported with AFBC only */ + { DRM_FORMAT_YUV420_8BIT, DE_VIDEO1, 14 }, + { DRM_FORMAT_VUY888, DE_VIDEO1, 16 }, + { DRM_FORMAT_VUY101010, DE_VIDEO1, 17 }, + { DRM_FORMAT_YUV420_10BIT, DE_VIDEO1, 18 } }; #define MALIDP_ID(__group, __format) \ @@ -74,11 +80,25 @@ static const struct malidp_format_id malidp500_de_formats[] = { { DRM_FORMAT_ABGR1555, DE_VIDEO1 | DE_GRAPHICS1 | DE_VIDEO2, MALIDP_ID(4, 1) }, \ { DRM_FORMAT_RGB565, DE_VIDEO1 | DE_GRAPHICS1 | DE_VIDEO2, MALIDP_ID(4, 2) }, \ { DRM_FORMAT_BGR565, DE_VIDEO1 | DE_GRAPHICS1 | DE_VIDEO2, MALIDP_ID(4, 3) }, \ + /* This is only supported with linear modifier */ \ + { DRM_FORMAT_XYUV8888, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(5, 0) },\ + /* This is only supported with AFBC modifier */ \ + { DRM_FORMAT_VUY888, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(5, 0) }, \ { DRM_FORMAT_YUYV, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(5, 2) }, \ + /* This is only supported with linear modifier */ \ { DRM_FORMAT_UYVY, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(5, 3) }, \ { DRM_FORMAT_NV12, DE_VIDEO1 | DE_VIDEO2 | SE_MEMWRITE, MALIDP_ID(5, 6) }, \ + /* This is only supported with AFBC modifier */ \ + { DRM_FORMAT_YUV420_8BIT, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(5, 6) }, \ { DRM_FORMAT_YUV420, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(5, 7) }, \ - { DRM_FORMAT_X0L2, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(6, 6)} + /* This is only supported with linear modifier */ \ + { DRM_FORMAT_XVYU2101010, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(6, 0)}, \ + /* This is only supported with AFBC modifier */ \ + { DRM_FORMAT_VUY101010, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(6, 0)}, \ + { DRM_FORMAT_X0L2, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(6, 6)}, \ + /* This is only supported with AFBC modifier */ \ + { DRM_FORMAT_YUV420_10BIT, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(6, 7)}, \ + { DRM_FORMAT_P010, DE_VIDEO1 | DE_VIDEO2, MALIDP_ID(6, 7)} static const struct malidp_format_id malidp550_de_formats[] = { MALIDP_COMMON_FORMATS,
We have added some new formats to be supported on DP500/DP550/DP650. Signed-off-by: Ayan Kumar Halder <ayan.halder@arm.com> Depends on :- https://patchwork.kernel.org/patch/10460063/ --- drivers/gpu/drm/arm/malidp_hw.c | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-)