From patchwork Wed Sep 11 11:50:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Huang Rui X-Patchwork-Id: 11140979 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 98C09112B for ; Wed, 11 Sep 2019 11:50:21 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8096E20872 for ; Wed, 11 Sep 2019 11:50:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8096E20872 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amd.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 434DC6EAA0; Wed, 11 Sep 2019 11:50:20 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-eopbgr780040.outbound.protection.outlook.com [40.107.78.40]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9A6606EAA1; Wed, 11 Sep 2019 11:50:17 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DRM+mDum8oxH/pChk+Gmv9bi1KtvE47ZvWn0Cgrmb1K3kV/uuM11XOlxLXIuHEDqYtL5q0pw337OWLJdxLsT2J/GBiyGPP0EngseiCcrhTGwpLdxfcuY3TmptV5ExMvbgi3oRkKBj5TX7ullA/m9YCmroqTG18zCu/FUGVpsdYINtxCXcId1oyN9mK6082T+/nk3fqaBJZixvHl0wsI8zx/WTOxEB6QG3SODctt2lg2EwnflAWzdT4P5MhZs8ksyJPFGNCDTDOEJuD+uydTdunZLf9VD0QPcGVJvxBc43I/dRhBEQ6Zse/RCs/Ti4pwEwapuMLrx9whj+BykN6WVXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JbU18eF14n6BZ6o0gwD10WfQIJuWWHfiwNQQOfQNUnc=; b=K+cVLRJTECj2HEJJu5TMPekpBLR6y4l7IOJHAJAbdbTxIUBX+lPlfvXhH9z6/f/fJPRUAO5omQvlicxvQF2q6fWCP/amBaOXm9/WWCUV/pNu+M0ITHflvqNAq4tumj2QDRWBws+/5bSsH7K0Mkjj5bakxH5JtEsbLXpzniC1ZGUxzaTzO3sw2tgyq1+l6uOG5acFPxH5/p6LIhyQIPfp/UYK3SAAzzTUixrOHO4SIHGUlpv99T61qu6Vkt+jWRLXXRJ1e4h+c7NGKqugqBiU+UpGGmR2Tc8g3zRJ7p4rcI6Z3VOXf4OZ+4MM7csOWF4dM7gYM7DE+ozZgisowh02Wg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from MN2PR12MB3309.namprd12.prod.outlook.com (20.179.83.157) by MN2PR12MB3421.namprd12.prod.outlook.com (20.178.243.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2263.17; Wed, 11 Sep 2019 11:50:15 +0000 Received: from MN2PR12MB3309.namprd12.prod.outlook.com ([fe80::e105:cd24:c71d:c38d]) by MN2PR12MB3309.namprd12.prod.outlook.com ([fe80::e105:cd24:c71d:c38d%4]) with mapi id 15.20.2241.022; Wed, 11 Sep 2019 11:50:15 +0000 From: "Huang, Ray" To: "amd-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "Deucher, Alexander" Subject: [PATCH 04/14] drm/amdgpu: add tmz feature parameter (v2) Thread-Topic: [PATCH 04/14] drm/amdgpu: add tmz feature parameter (v2) Thread-Index: AQHVaJcTCa38JOQlqUyUnCvyRYnw5Q== Date: Wed, 11 Sep 2019 11:50:15 +0000 Message-ID: <1568202584-14471-5-git-send-email-ray.huang@amd.com> References: <1568202584-14471-1-git-send-email-ray.huang@amd.com> In-Reply-To: <1568202584-14471-1-git-send-email-ray.huang@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [180.167.199.189] x-clientproxiedby: HK2PR04CA0046.apcprd04.prod.outlook.com (2603:1096:202:14::14) To MN2PR12MB3309.namprd12.prod.outlook.com (2603:10b6:208:106::29) x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.7.4 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 15331bb2-3b5c-4cbf-7dbd-08d736ae35ef x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:MN2PR12MB3421; x-ms-traffictypediagnostic: MN2PR12MB3421: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 0157DEB61B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(396003)(39860400002)(136003)(376002)(366004)(199004)(189003)(6436002)(4326008)(25786009)(450100002)(6486002)(486006)(11346002)(446003)(2616005)(305945005)(7736002)(50226002)(8936002)(316002)(110136005)(54906003)(8676002)(6116002)(3846002)(2906002)(81166006)(81156014)(36756003)(14454004)(71190400001)(71200400001)(86362001)(66446008)(478600001)(66476007)(64756008)(66556008)(66946007)(256004)(99286004)(53936002)(5660300002)(76176011)(52116002)(6512007)(6636002)(386003)(6506007)(66066001)(102836004)(26005)(186003)(476003)(2501003); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR12MB3421; H:MN2PR12MB3309.namprd12.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: kP9JV50vaXHRefbfDv85tha+x6AXZME5jKLO7evdyz98fus7HhzIJ3lQtTzzjKFNW+tMXmmHmvxk+/GpzZ+itMsYVfBBSjVQ7UyKWechwWI7haPxI9C9CU80x0TUbCNxkUytHtabOhnG3gaHrv6mPpf1K9BekJGQ3NH5iSqf/MjOnItcKf+Px5butuZtc/TS2qP9Tj2H+uf8xtRY798gRjlMJr6rBr66m5h0tAzemTJyxTrFFDUOKHd3vUk9/U6A/FbYA1TJ7c5qvXJSDLbHmWyNxW6l0jHdNgQCjzp3h/FLCBEBqWwFOBC5UwF93TC196e4vKcLKYCEO0DqsUYt94cpXbEQLsYcTzyNjNMw702jOh1TRfiQSFKo+szxmewIZupS4S2/LI5PKZjGO9IDRQDykfBKjQfXD/EcjJucumw= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 15331bb2-3b5c-4cbf-7dbd-08d736ae35ef X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Sep 2019 11:50:15.6100 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2y92nVg7xxFdH+qVr407fCC6USNtkBPzHG1283hwB5rMK9eW9zhrPcQvYhVVm0hXFG75QwtUZ4DKWHYIa8r+Qg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3421 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JbU18eF14n6BZ6o0gwD10WfQIJuWWHfiwNQQOfQNUnc=; b=iLtaTnJ4Mydu9rsuhTg4BQy76geqyinPzsHY3S+7SU6U7YAXjjXJtIdjCXrvf3axXGX3OjWsMeAf44D0aue8FtZXboGbVqwB4AMlwimQSrAdAPKdFY71u37P19to8R6212bcuySKvMjU2yq02aHhvTq8IQUhMNsSH4lW4FGjdlE= X-Mailman-Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Ray.Huang@amd.com; X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Tuikov, Luben" , "Huang, Ray" , "Koenig, Christian" , "Liu, Aaron" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This patch adds tmz parameter to enable/disable the feature in the amdgpu kernel module. Nomally, by default, it should be auto (rely on the hardware capability). But right now, it need to set "off" to avoid breaking other developers' work because it's not totally completed. Will set "auto" till the feature is stable and completely verified. v2: add "auto" option for future use. Signed-off-by: Huang Rui Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 11 +++++++++++ 2 files changed, 12 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h index a1516a3..930643c 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h @@ -172,6 +172,7 @@ extern int amdgpu_force_asic_type; #ifdef CONFIG_HSA_AMD extern int sched_policy; #endif +extern int amdgpu_tmz; #ifdef CONFIG_DRM_AMDGPU_SI extern int amdgpu_si_support; diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c index 6978d17..606f1d3 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c @@ -145,6 +145,7 @@ int amdgpu_discovery = -1; int amdgpu_mes = 0; int amdgpu_noretry = 1; int amdgpu_force_asic_type = -1; +int amdgpu_tmz = 0; struct amdgpu_mgpu_info mgpu_info = { .mutex = __MUTEX_INITIALIZER(mgpu_info.mutex), @@ -752,6 +753,16 @@ uint amdgpu_dm_abm_level = 0; MODULE_PARM_DESC(abmlevel, "ABM level (0 = off (default), 1-4 = backlight reduction level) "); module_param_named(abmlevel, amdgpu_dm_abm_level, uint, 0444); +/** + * DOC: tmz (int) + * Trust Memory Zone (TMZ) is a method to protect the contents being written to + * and read from memory. + * + * The default value: 0 (off). TODO: change to auto till it is completed. + */ +MODULE_PARM_DESC(tmz, "Enable TMZ feature (-1 = auto, 0 = off (default), 1 = on)"); +module_param_named(tmz, amdgpu_tmz, int, 0444); + static const struct pci_device_id pciidlist[] = { #ifdef CONFIG_DRM_AMDGPU_SI {0x1002, 0x6780, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_TAHITI},