| Message ID | 1598613212-1113-5-git-send-email-robert.chiras@oss.nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add new features to nwl-dsi driver | expand |
Hi, On Fri, Aug 28, 2020 at 02:13:31PM +0300, Robert Chiras (OSS) wrote: > From: Robert Chiras <robert.chiras@nxp.com> > > Add documentation for a new property: 'fsl,clock-drop-level'. > > Signed-off-by: Robert Chiras <robert.chiras@nxp.com> > --- > Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > index 8b5741b..b415f4e 100644 > --- a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > @@ -143,6 +143,10 @@ properties: > > additionalProperties: false > > + clock-drop-level: Property is called fsl,clock-drop-level. > + description: > + Specifies the level at wich the crtc_clock should be dropped > + > patternProperties: > "^panel@[0-9]+$": > type: object > -- > 2.7.4 >
Hi Robert, Thank you for the patch. On Fri, Aug 28, 2020 at 02:13:31PM +0300, Robert Chiras (OSS) wrote: > From: Robert Chiras <robert.chiras@nxp.com> > > Add documentation for a new property: 'fsl,clock-drop-level'. > > Signed-off-by: Robert Chiras <robert.chiras@nxp.com> > --- > Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > index 8b5741b..b415f4e 100644 > --- a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > @@ -143,6 +143,10 @@ properties: > > additionalProperties: false > > + clock-drop-level: > + description: > + Specifies the level at wich the crtc_clock should be dropped > + There's no "crtc_clock" defined in the bindings. As DT bindings shouldn't be tied to a particular driver implementation, could you document this property without referring to concepts specific to the driver ? I think the documentation should also be extended, looking at this patch I have no idea what this does and how to compute the value that should be set. > patternProperties: > "^panel@[0-9]+$": > type: object
On Fri, Aug 28, 2020 at 02:13:31PM +0300, Robert Chiras (OSS) wrote: > From: Robert Chiras <robert.chiras@nxp.com> > > Add documentation for a new property: 'fsl,clock-drop-level'. > > Signed-off-by: Robert Chiras <robert.chiras@nxp.com> > --- > Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > index 8b5741b..b415f4e 100644 > --- a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > @@ -143,6 +143,10 @@ properties: > > additionalProperties: false > > + clock-drop-level: fsl, ? > + description: > + Specifies the level at wich the crtc_clock should be dropped Needs a type $ref. > + > patternProperties: > "^panel@[0-9]+$": > type: object > -- > 2.7.4 >
diff --git a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml index 8b5741b..b415f4e 100644 --- a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml +++ b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml @@ -143,6 +143,10 @@ properties: additionalProperties: false + clock-drop-level: + description: + Specifies the level at wich the crtc_clock should be dropped + patternProperties: "^panel@[0-9]+$": type: object