| Message ID | 1605186891-47282-1-git-send-email-wangxiongfeng2@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/sun4i: dw-hdmi: fix error return code in sun8i_dw_hdmi_bind() | expand |
Hi! Thanks for the patch. Dne četrtek, 12. november 2020 ob 14:14:51 CET je Xiongfeng Wang napisal(a): > Fix to return a negative error code from the error handling case instead > of 0 in function sun8i_dw_hdmi_bind(). > > Fixes: b7c7436a5ff0 ("drm/sun4i: Implement A83T HDMI driver") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com> > --- > drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c > b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c index d4c0804..f010fe8 100644 > --- a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c > +++ b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c > @@ -208,6 +208,7 @@ static int sun8i_dw_hdmi_bind(struct device *dev, struct > device *master, phy_node = of_parse_phandle(dev->of_node, "phys", 0); > if (!phy_node) { > dev_err(dev, "Can't found PHY phandle\n"); > + ret = -ENODEV; That should be EINVAL because DT node doesn't have mandatory property. With that fixed, you can add: Reviewed-by: Jernej Skrabec <jernej.skrabec@siol.net> Best regards, Jernej > goto err_disable_clk_tmds; > }
Hi! On 2020/11/14 2:01, Jernej Škrabec wrote: > Hi! > > Thanks for the patch. > > Dne četrtek, 12. november 2020 ob 14:14:51 CET je Xiongfeng Wang napisal(a): >> Fix to return a negative error code from the error handling case instead >> of 0 in function sun8i_dw_hdmi_bind(). >> >> Fixes: b7c7436a5ff0 ("drm/sun4i: Implement A83T HDMI driver") >> Reported-by: Hulk Robot <hulkci@huawei.com> >> Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com> >> --- >> drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c >> b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c index d4c0804..f010fe8 100644 >> --- a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c >> +++ b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c >> @@ -208,6 +208,7 @@ static int sun8i_dw_hdmi_bind(struct device *dev, struct >> device *master, phy_node = of_parse_phandle(dev->of_node, "phys", 0); >> if (!phy_node) { >> dev_err(dev, "Can't found PHY phandle\n"); >> + ret = -ENODEV; > > That should be EINVAL because DT node doesn't have mandatory property. > > With that fixed, you can add: > Reviewed-by: Jernej Skrabec <jernej.skrabec@siol.net> Thanks for your review! I will fix it in the next version. Thanks, Xiongfeng > > Best regards, > Jernej > >> goto err_disable_clk_tmds; >> } > > > > > . >
diff --git a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c index d4c0804..f010fe8 100644 --- a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c +++ b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c @@ -208,6 +208,7 @@ static int sun8i_dw_hdmi_bind(struct device *dev, struct device *master, phy_node = of_parse_phandle(dev->of_node, "phys", 0); if (!phy_node) { dev_err(dev, "Can't found PHY phandle\n"); + ret = -ENODEV; goto err_disable_clk_tmds; }
Fix to return a negative error code from the error handling case instead of 0 in function sun8i_dw_hdmi_bind(). Fixes: b7c7436a5ff0 ("drm/sun4i: Implement A83T HDMI driver") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com> --- drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 1 + 1 file changed, 1 insertion(+)