From patchwork Fri Dec 11 01:46:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ying Liu X-Patchwork-Id: 11967487 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59FA6C4361B for ; Fri, 11 Dec 2020 08:16:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 18BEE23E56 for ; Fri, 11 Dec 2020 08:16:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 18BEE23E56 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 89E0D6EC9F; Fri, 11 Dec 2020 08:16:10 +0000 (UTC) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2059.outbound.protection.outlook.com [40.107.20.59]) by gabe.freedesktop.org (Postfix) with ESMTPS id 48A846E817 for ; Fri, 11 Dec 2020 01:54:50 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TU6syKgUCRG19ZNZch7tCUcwVhvXGhmCL+F3nhzXpZduvkc+HmrGMF3PslgS2YNM2ePKB5Mura3Tl3WElpmLPKoKGEXzsFWW7U0CO+c6xV7zZ3B6sz7fj1uikzisSdBXPSNHczpuwJ/sTxpmQhkRb/taZKnBXy9GUpfED7wPtjhasO/xw03teoheVZ5GGLEP9/+mXst/2+Xz60cBzhHp+A0xMFCNnI29nwHFzfITsV8Mj9+tkFk51zdW4nw/5zNU0apjCmftrcKnDQd9xd4PCm+rc5Se/1k72gVOCG7xe0bIdhlIS6WODr2vY/UR+xZWN+A2vrlmeIVXuHqOn7dngA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F7JCMEc2TvZTAAQajmMNmgCYyH/TNXyB8QG4yF7Olg8=; b=OEmVrt0eINLSWY3nbtPtJ4RZY6CsxFSaQCV3q2VmcWga79Y9eQMVixkQv8ZNGw61duER4YAJqUQnxFE0ToSBPEPwHIGxAvx2WG1GNUztldJbrSddrIQUjdISQ+qAlONNQ571GF0yWSJ+3tI6L31lODzKRPcweKUb9UciVGwsxyvB1BEFNwOlPZBarsWfprYtFON4oV8JsR9Y9cCVh2J11TENgO5eGOSGTu32t9Kk8WgTpxZBTH/5uHvSdlUx+x/nVG0UZHLYqtrUeDyYNnNNGEexVmg2t/PXF/c8nXeNPRj2gXu1ep4Pw/eKCU9Vs+dfYyKr+7rN7hz11HQsrwHr9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F7JCMEc2TvZTAAQajmMNmgCYyH/TNXyB8QG4yF7Olg8=; b=XH+DIHrh2wefqYV2uyHiJMlBHigg5nbluj6N535iWAnhS05noRSUDtKWPV/PY9T7kTReI8aVQukZEy5P+aw28MpDjwX9d0emOaThR95oHquQhMmngLAVMxbP0DmwO5Gr3Lj9/kVG6WmcWGx0K8vfza3YA9TB0Q7+0cnwJ0Dj2V4= Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=nxp.com; Received: from VI1PR04MB3983.eurprd04.prod.outlook.com (2603:10a6:803:4c::16) by VI1PR0402MB3952.eurprd04.prod.outlook.com (2603:10a6:803:1c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12; Fri, 11 Dec 2020 01:54:48 +0000 Received: from VI1PR04MB3983.eurprd04.prod.outlook.com ([fe80::dcb7:6117:3def:2685]) by VI1PR04MB3983.eurprd04.prod.outlook.com ([fe80::dcb7:6117:3def:2685%7]) with mapi id 15.20.3632.023; Fri, 11 Dec 2020 01:54:48 +0000 From: Liu Ying To: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 1/5] drm/bridge: nwl-dsi: Set PHY mode in nwl_dsi_enable() Date: Fri, 11 Dec 2020 09:46:18 +0800 Message-Id: <1607651182-12307-2-git-send-email-victor.liu@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1607651182-12307-1-git-send-email-victor.liu@nxp.com> References: <1607651182-12307-1-git-send-email-victor.liu@nxp.com> X-Originating-IP: [119.31.174.66] X-ClientProxiedBy: SG2P153CA0042.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::11) To VI1PR04MB3983.eurprd04.prod.outlook.com (2603:10a6:803:4c::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (119.31.174.66) by SG2P153CA0042.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3676.5 via Frontend Transport; Fri, 11 Dec 2020 01:54:42 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: bc22d55c-db69-412b-3f22-08d89d77bdaa X-MS-TrafficTypeDiagnostic: VI1PR0402MB3952: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2201; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YawtK11IMTjcTjvC1VXb+ZtgHyfVT6PktdNPo9O0Ud4iS/5LQukSrpVHMrlZEhS1LJS9juuruQEzvpv2IAX3M4dAzc/mp3bwPCnc8BixbkzLOGgk9C0Px5dpPLAaOMEX2Z7yOuHY+/+VIE71gFPH81Ij4W49aM2yeB/8GZZgq92OYLoHoZJ56K1JXmloeZWaS8FomfZ2wKPXWfrC6+H0PGhfiGHK0vBjr0rixfGoMlbBa23ZneDrRGZNC51lhccsNBNuwQIceeddDe0Jbip2w7u5R6nr5XdPM6tO8FDAmimZOe5YtYdlXgP62Q37J+XaFgE7Yv3gDRmO3+SN6o4K9g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB3983.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(376002)(39860400002)(346002)(366004)(52116002)(316002)(956004)(2616005)(5660300002)(66556008)(4326008)(66476007)(2906002)(66946007)(6512007)(7416002)(8676002)(16526019)(26005)(186003)(8936002)(6486002)(36756003)(478600001)(86362001)(6666004)(6506007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?q?+kaqbjNQDIT9onti2OTAZxnLG6anNC?= =?utf-8?q?VI4Pozy7iaHFaEubqp5UgktTVCr70lmeNfcrXUZp5Wl13Zy3UB4Gkt92PuYEOP90q?= =?utf-8?q?ann1a95PP73paBMcwwXbaDkNKLqOkX1TAVwyipQmkRfhVlWWeHAaBKqIzDqaUAEhe?= =?utf-8?q?e/JDZrx48wIO8H7eq9dA2icPMvIYqLa/hJstW+inSJZzwQJkjcQVB7x9itGSTUd8H?= =?utf-8?q?YrIhUP7ei81OjdNhMTlqSCkI59ghAvpxbPsSXTqPdeA4mv3vGe1Pst1Vp0hVO8rWG?= =?utf-8?q?ChcNgPjDiqANk16YmATj984ZwvEDbJfcAj1FLsdHOJ/ANH1nUzzsGBLV7jAfjGZ+/?= =?utf-8?q?EfUROZ3vSiMosbfe5MvYQE3ZrWUik7+LXVSM/3sq8kQV/ehWw1uZ005CpvR36QU29?= =?utf-8?q?Je4TLqtD+Ts5EBPZeayB00mMt3OmWbv9DzVXjQeDcs4mQ2TCYqmoOgAaetBB1dAHr?= =?utf-8?q?skWyiSnw0fkRYHl5+x+B1yK6SrN7cQBqRj67eZYwn1oNeCKEjxxQJqpyOPZSLMBk1?= =?utf-8?q?Yy4sCKAIQ2qFhelYpL6CUmNhm9S2a0NSrEcDdy90kyRZmXuOh9W7WnB5ZFQaVkQ0X?= =?utf-8?q?PC130Y7quNU2eyxoSXpyAajcxKQ4RqBDA9uIK+0w3XizOELHdrmDg4xO8lWW7FjKK?= =?utf-8?q?sVSXpAzimre9arm96hUOAiJ6a9b9zG1kAVndfsr8dfsGek+LSCpXVDEYsPR60tnHy?= =?utf-8?q?dTSfvTrmRRiDeL6IgnUArOhbqc3BkIni1WCtgbj94yDYIHyIVFyr2RQZjwrUBTzo8?= =?utf-8?q?LYsLMTjCRMKb1QahGRS1DKiUUx/i52zVqkd+Ob5XZG6cq5S34nqOkb7S923zM8W9V?= =?utf-8?q?mtO5DrncAgPqZquto2L/W1re5V9TnbM44oMCtbREpnPSRWPSLmCGUoV9qfZ2pkCFs?= =?utf-8?q?5loWAoe7x6jYBde54tZ4tibCTvJFWUzOr+hGA/Hohq11uR7R87cxg076Lc9WZHX8D?= =?utf-8?q?qWhR7fzrgDWcWwLJL01?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB3983.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2020 01:54:47.8846 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-Network-Message-Id: bc22d55c-db69-412b-3f22-08d89d77bdaa X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: c4Ft0Plr/xtyJRrxoICZ2Z2hTPmf2fhUWDkpSwdc0gLjH5tVHSw1RZLCjVLmzPz2b104fnRoNqpmV0EIauOJxw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3952 X-Mailman-Approved-At: Fri, 11 Dec 2020 08:16:08 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: martin.kepplinger@puri.sm, jernej.skrabec@siol.net, kernel@pengutronix.de, narmstrong@baylibre.com, airlied@linux.ie, s.hauer@pengutronix.de, jonas@kwiboo.se, kishon@ti.com, a.hajda@samsung.com, vkoul@kernel.org, robh+dt@kernel.org, Laurent.pinchart@ideasonboard.com, robert.chiras@nxp.com, shawnguo@kernel.org, agx@sigxcpu.org, linux-imx@nxp.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The Northwest Logic MIPI DSI host controller embedded in i.MX8qxp works with a Mixel MIPI DPHY + LVDS PHY combo to support either a MIPI DSI display or a LVDS display. So, this patch calls phy_set_mode() from nwl_dsi_enable() to set PHY mode to MIPI DPHY explicitly. Cc: Guido Günther Cc: Robert Chiras Cc: Martin Kepplinger Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Cc: David Airlie Cc: Daniel Vetter Cc: NXP Linux Team Reviewed-by: Guido Günther Signed-off-by: Liu Ying --- v2->v3: * No change. v1->v2: * Add Guido's R-b tag. drivers/gpu/drm/bridge/nwl-dsi.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/bridge/nwl-dsi.c b/drivers/gpu/drm/bridge/nwl-dsi.c index 66b6740..be6bfc5 100644 --- a/drivers/gpu/drm/bridge/nwl-dsi.c +++ b/drivers/gpu/drm/bridge/nwl-dsi.c @@ -678,6 +678,12 @@ static int nwl_dsi_enable(struct nwl_dsi *dsi) return ret; } + ret = phy_set_mode(dsi->phy, PHY_MODE_MIPI_DPHY); + if (ret < 0) { + DRM_DEV_ERROR(dev, "Failed to set DSI phy mode: %d\n", ret); + goto uninit_phy; + } + ret = phy_configure(dsi->phy, phy_cfg); if (ret < 0) { DRM_DEV_ERROR(dev, "Failed to configure DSI phy: %d\n", ret);