| Message ID | 1610417411-29661-1-git-send-email-tiantao6@hisilicon.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: arc: Use simple encoder | expand |
On Tue, Jan 12, 2021 at 10:10:11AM +0800, Tian Tao wrote: > The arc driver uses empty implementations for its encoders. Replace > the code with the generic simple encoder. > > Signed-off-by: Tian Tao <tiantao6@hisilicon.com> I have an entire patch series to convert arc over to simple display pipe. It's not seen much action (I sent it out in Sept last year), I'll send it out again and cc: you. -Daniel > --- > drivers/gpu/drm/arc/arcpgu_hdmi.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/arc/arcpgu_hdmi.c b/drivers/gpu/drm/arc/arcpgu_hdmi.c > index 5283993..71ef75f 100644 > --- a/drivers/gpu/drm/arc/arcpgu_hdmi.c > +++ b/drivers/gpu/drm/arc/arcpgu_hdmi.c > @@ -9,13 +9,10 @@ > #include <drm/drm_crtc.h> > #include <drm/drm_encoder.h> > #include <drm/drm_device.h> > +#include <drm/drm_simple_kms_helper.h> > > #include "arcpgu.h" > > -static struct drm_encoder_funcs arcpgu_drm_encoder_funcs = { > - .destroy = drm_encoder_cleanup, > -}; > - > int arcpgu_drm_hdmi_init(struct drm_device *drm, struct device_node *np) > { > struct drm_encoder *encoder; > @@ -34,8 +31,7 @@ int arcpgu_drm_hdmi_init(struct drm_device *drm, struct device_node *np) > > encoder->possible_crtcs = 1; > encoder->possible_clones = 0; > - ret = drm_encoder_init(drm, encoder, &arcpgu_drm_encoder_funcs, > - DRM_MODE_ENCODER_TMDS, NULL); > + ret = drm_simple_encoder_init(drm, encoder, DRM_MODE_ENCODER_TMDS); > if (ret) > return ret; > > -- > 2.7.4 >
diff --git a/drivers/gpu/drm/arc/arcpgu_hdmi.c b/drivers/gpu/drm/arc/arcpgu_hdmi.c index 5283993..71ef75f 100644 --- a/drivers/gpu/drm/arc/arcpgu_hdmi.c +++ b/drivers/gpu/drm/arc/arcpgu_hdmi.c @@ -9,13 +9,10 @@ #include <drm/drm_crtc.h> #include <drm/drm_encoder.h> #include <drm/drm_device.h> +#include <drm/drm_simple_kms_helper.h> #include "arcpgu.h" -static struct drm_encoder_funcs arcpgu_drm_encoder_funcs = { - .destroy = drm_encoder_cleanup, -}; - int arcpgu_drm_hdmi_init(struct drm_device *drm, struct device_node *np) { struct drm_encoder *encoder; @@ -34,8 +31,7 @@ int arcpgu_drm_hdmi_init(struct drm_device *drm, struct device_node *np) encoder->possible_crtcs = 1; encoder->possible_clones = 0; - ret = drm_encoder_init(drm, encoder, &arcpgu_drm_encoder_funcs, - DRM_MODE_ENCODER_TMDS, NULL); + ret = drm_simple_encoder_init(drm, encoder, DRM_MODE_ENCODER_TMDS); if (ret) return ret;
The arc driver uses empty implementations for its encoders. Replace the code with the generic simple encoder. Signed-off-by: Tian Tao <tiantao6@hisilicon.com> --- drivers/gpu/drm/arc/arcpgu_hdmi.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)