Message ID | 1613388619-3276-1-git-send-email-chen45464546@163.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | drm/i915: Remove unused function pointer typedef long_pulse_detect_func | expand |
On Mon, Feb 15, 2021 at 07:30:19PM +0800, Chen Lin wrote: > From: Chen Lin <chen.lin5@zte.com.cn> > > Remove the 'long_pulse_detect_func' typedef as it is not used. > > Signed-off-by: Chen Lin <chen.lin5@zte.com.cn> > --- > drivers/gpu/drm/i915/i915_irq.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c > index 6cdb052..c294ac6 100644 > --- a/drivers/gpu/drm/i915/i915_irq.c > +++ b/drivers/gpu/drm/i915/i915_irq.c > @@ -78,7 +78,6 @@ static inline void pmu_irq_stats(struct drm_i915_private *i915, > WRITE_ONCE(i915->pmu.irq_count, i915->pmu.irq_count + 1); > } > > -typedef bool (*long_pulse_detect_func)(enum hpd_pin pin, u32 val); > typedef u32 (*hotplug_enables_func)(struct drm_i915_private *i915, > enum hpd_pin pin); I thought we used in when passing it as an argument to intel_get_hpd_pins(), but looks like that's not the case. I guess we should unify this stuff by either removing both these typedefs and adjusting intel_hpd_hotplug_enables() accordingly, or we should use the typedef in intel_get_hpd_pins() as well.
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 6cdb052..c294ac6 100644 --- a/drivers/gpu/drm/i915/i915_irq.c +++ b/drivers/gpu/drm/i915/i915_irq.c @@ -78,7 +78,6 @@ static inline void pmu_irq_stats(struct drm_i915_private *i915, WRITE_ONCE(i915->pmu.irq_count, i915->pmu.irq_count + 1); } -typedef bool (*long_pulse_detect_func)(enum hpd_pin pin, u32 val); typedef u32 (*hotplug_enables_func)(struct drm_i915_private *i915, enum hpd_pin pin);