diff mbox series

drm/tilcdc: panel: fix platform_no_drv_owner.cocci warnings

Message ID 1614762267-98454-1-git-send-email-yang.lee@linux.alibaba.com (mailing list archive)
State New, archived
Headers show
Series drm/tilcdc: panel: fix platform_no_drv_owner.cocci warnings | expand

Commit Message

Yang Li March 3, 2021, 9:04 a.m. UTC
./drivers/gpu/drm/tilcdc/tilcdc_panel.c:402:3-8: No need to set .owner
here. The core will do it.

Remove .owner field if calls are used which set it automatically

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/gpu/drm/tilcdc/tilcdc_panel.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Jyri Sarha March 21, 2021, 7:10 p.m. UTC | #1
On 2021-03-03 11:04, Yang Li wrote:
> ./drivers/gpu/drm/tilcdc/tilcdc_panel.c:402:3-8: No need to set .owner
> here. The core will do it.
> 
> Remove .owner field if calls are used which set it automatically
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Reviewed-by: Jyri Sarha <jyri.sarha@iki.fi>

I'll merge this soon to drm-misc-next.

Best regards,
Jyri

> ---
>  drivers/gpu/drm/tilcdc/tilcdc_panel.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> index 00efc30..4235780 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> @@ -399,7 +399,6 @@ static int panel_remove(struct platform_device 
> *pdev)
>  	.probe = panel_probe,
>  	.remove = panel_remove,
>  	.driver = {
> -		.owner = THIS_MODULE,
>  		.name = "tilcdc-panel",
>  		.of_match_table = panel_of_match,
>  	},
diff mbox series

Patch

diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
index 00efc30..4235780 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
@@ -399,7 +399,6 @@  static int panel_remove(struct platform_device *pdev)
 	.probe = panel_probe,
 	.remove = panel_remove,
 	.driver = {
-		.owner = THIS_MODULE,
 		.name = "tilcdc-panel",
 		.of_match_table = panel_of_match,
 	},